Dev #354
Merged
Dev #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreMolecularModelManager.removeDeadAnnotationsAndImports takes out imports and tje json_model annotation property. This plus the CoreMolecularModelManager.fixBrokenObjectPropertiesAndAxioms for handling loader problems results in go-cams with no import statements and with all of their object properties properly declared.
Eliminate imports
updates to line up with molecular event
why wasn't this on before???
if some one makes a model and renders the evidence nodes, as can happen, they get metadata like x,y, locations. Making them @gocamentity allows this to happen.
Shex closed impl bug fix
shift to SPARQL pattern (using existing M3 sparql access) from OWL API pattern makes things way faster (again..). Added some real test cases. Dramatic speed improvements (6 seconds to 0 seconds for very large model).
No impact on anything aside from stats calculation. All tests look good locally and in travis. Merging.
this reduces junk that can overflow travis.
think this does it for #355
…-ART Modification state handling ART
If this turns out too slow might (probably) better to just add everything into the database as before and then remove the imports using sparql update. It is slow if the imports are large - as go-lego and brethren tend to be.
…a model after reset.
switching it out to a non-functional import for the import removal test. Probably better to set up a catalogue..
…o-cli-output Add shex explanation json to cli output
The explanation service was using the Golr ExternalLookupService . This is no longer operational within minerva. It was replaced by the local blazegraph ontology manager - here for label lookups. ExternalLookupService references and code could be removed from the code base - assuming the blazegraphontologymanager pattern is kept. cc @balhoff
|
Time is short, so we are taking this before tests finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incorporate recent changes related to removal of imports statements.
Impovements to shex validator and statistics calculator