Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: procedure def blocks respond to models #6673

Merged

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Nov 30, 2022

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Work on #6526

Proposed Changes

Updates procedure blocks to respond to changes in data models.

Reason for Changes

Work on getting procedures to actually use the source of truth data models!

Test Coverage

Tests for responding to updates are now enabled.

Documentation

N/A

Additional Information

Dependent on #6672

@BeksOmega BeksOmega requested a review from a team as a code owner November 30, 2022 17:24
@BeksOmega BeksOmega requested a review from cpcallen November 30, 2022 17:24
@github-actions github-actions bot added the PR: feature Adds a feature label Nov 30, 2022
@BeksOmega BeksOmega force-pushed the feat/procedure-blocks-respond-to-models branch from 7bb86bc to 765ab52 Compare December 1, 2022 19:42
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Dec 1, 2022
@BeksOmega BeksOmega force-pushed the feat/procedure-blocks-respond-to-models branch 2 times, most recently from 007dffb to fa7c1c0 Compare December 9, 2022 23:32
@BeksOmega BeksOmega force-pushed the feat/procedure-blocks-respond-to-models branch from fa7c1c0 to e90658e Compare December 14, 2022 23:17
@BeksOmega BeksOmega force-pushed the feat/procedure-blocks-respond-to-models branch from e90658e to d619c25 Compare December 20, 2022 17:47
@rachel-fenichel rachel-fenichel assigned gonfunko and unassigned cpcallen Jan 5, 2023
@rachel-fenichel rachel-fenichel requested review from gonfunko and removed request for cpcallen January 5, 2023 18:29
@BeksOmega BeksOmega changed the title feat: procedure blocks respond to models feat: procedure def blocks respond to models Jan 5, 2023
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Jan 5, 2023
@BeksOmega BeksOmega force-pushed the feat/procedure-blocks-respond-to-models branch from d619c25 to 3888526 Compare January 5, 2023 19:40
@BeksOmega BeksOmega force-pushed the feat/procedure-blocks-respond-to-models branch from 889cd87 to e2a9790 Compare January 5, 2023 22:48
@BeksOmega BeksOmega force-pushed the feat/procedure-blocks-respond-to-models branch from e2a9790 to 3b24b27 Compare January 5, 2023 23:07
@BeksOmega BeksOmega merged commit faf5a08 into google:develop Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants