Add support for actions - Do not merge!#51

Open

mauropasse wants to merge 220 commits intoirobot-ros:irobot/add-events-executorfrom mauropasse:mauro/actions-support-2

+4,446-51

Commits on Oct 2, 2020

Add EventsExecutor
Mauro
committed
Handle intra-process communication
Mauro
committed
Move apis - Add constness
Mauro
committed

Commits on Oct 5, 2020

Create raw pointer version of Executor::execute_<ENTITY>
Mauro
committed
Remove exec mutex. Add comments
Mauro
committed
remove not needed APIs
Mauro
committed
Change how to add node gc's to entities collector
Mauro
committed
Remove comments
Mauro
committed
Use EventsExecutorEntitiesCollector
Mauro
committed
restore original StaticExecutorEntitiesCollector
Mauro
committed
remove includes
Mauro
committed
Handle timers from EventsExecutorEntitiesCollector
Mauro
committed
Not ready for rebuild stuff
Mauro
committed
Some cleaning
Mauro
committed
Some reorder
Mauro
committed

Commits on Oct 6, 2020

Use or discard previous events: Guard conditions
Mauro
committed
Implement spin some
Mauro
committed
Remove node from executor support
Mauro
committed
move execute entities to executor.cpp
Mauro
committed
Move apis
Mauro
committed

Commits on Oct 7, 2020

init entities collector at executor construction
Mauro
committed
reimplement timers heap -> timers queue
Mauro
committed
rename timers queue
Mauro
committed
update timers queue
Mauro
committed

Commits on Oct 8, 2020

Move code
Mauro
committed
Use lambdas directly
Mauro
committed
Handle default event types
Mauro
committed
Fix spinsome
Mauro
committed
Check rclcpp::ok before execute timers
Mauro
committed

Commits on Oct 9, 2020

Restore timers heap
Mauro
committed
Set interrupt guard condition callback
Mauro
committed

Commits on Oct 12, 2020

create TimersManager class, implement spin() variants for EventsExecutor and fix unit tests
alsora
committed
Merge pull request #2 from alsora/asoragna/add-events-executor
iRobot ROS
authored
Rename EventQ -> ExecutorEvent
Mauro
committed
rename set_guard_condition_callback -> set_callback
Mauro
committed
remove unused handle_events() function
alsora
committed
add missing predicate to event_queue_cv wait
alsora
committed
Update events_executor.cpp
alsora
authored
Rename to set_events_executor_callback
Mauro
committed
Merge pull request #4 from alsora/asoragna/remove-handle
iRobot ROS
authored
Rename to ExecutorEventCallback
Mauro
committed
Merge branch 'irobot/add-events-executor' into mauro-irobot/add-events-executor
mauropasse
authored
Merge pull request #3 from mauropasse/mauro-irobot/add-events-executor
iRobot ROS
authored
fix linter errors
alsora
committed
rename functions in unit-tests

Soragna, Alberto
authored and
alsora
committed
Merge pull request #7 from alsora/asoragna/fix-tests
iRobot ROS
authored
add timers manager test and bug fixes
alsora
committed
Merge branch 'irobot/add-events-executor' into asoragna/add-predicate
alsora
authored
Merge pull request #5 from alsora/asoragna/add-predicate
iRobot ROS
authored
Merge pull request #6 from alsora/asoragna/linter-errors
iRobot ROS
authored

Commits on Oct 13, 2020

cleanup entities collector
alsora
committed
Merge pull request #9 from alsora/asoragna/cleanup-entities-collector
iRobot ROS
authored
Support events
Mauro
committed
Update test_timers_manager.cpp
alsora
authored
Merge pull request #8 from alsora/asoragna/timers-test
iRobot ROS
authored
override cancel
alsora
committed
Merge pull request ros2#10 from alsora/asoragna/override-cancel
iRobot ROS
authored
Merge pull request ros2#11 from mauropasse/mauro-irobot/add-events-executor
iRobot ROS
authored

Commits on Oct 14, 2020

void return on set_events_executor_callback
Mauro
committed
Update client.hpp
iRobot ROS
authored
Update qos_event.hpp
iRobot ROS
authored
Merge pull request ros2#12 from mauropasse/mauro-irobot/add-events-executor
iRobot ROS
authored
clean add/remove node APIs and make sure that event callbacks are removed when destroying executor
alsora
committed
Revert "void return on set_events_executor_callback"
iRobot ROS
authored
Merge pull request ros2#15 from irobot-ros/revert-12-mauro-irobot/add-events-executor
iRobot ROS
authored
Merge branch 'irobot/add-events-executor' into asoragna/clean-entities-collector
iRobot ROS
authored
Merge pull request ros2#14 from alsora/asoragna/clean-entities-collector
iRobot ROS
authored
more thread safety and events executor test
alsora
committed
remove atomic and use mutex to protect running_ flag
alsora
committed
Merge pull request ros2#16 from alsora/asoragna/events-executor-tests
iRobot ROS
authored

Commits on Oct 15, 2020

Commits on Oct 16, 2020

complete destruction callback implementation
alsora
committed
remove prints
alsora
committed
undo whitespace change
alsora
committed
use std:: functions for heap and minor fixes
alsora
committed
remove logs
alsora
committed
Merge pull request ros2#19 from alsora/asoragna/destruction-callback
iRobot ROS
authored
Add callback groups support
Mauro
committed
copy/paste fix
Mauro
committed
Add missing unsets
Mauro
committed
use emplace
Mauro
committed
Remove not needed unset_node_entities_callbacks
Mauro
committed
use insert
Mauro
committed
fix unit tests
alsora
committed
Adress comments
Mauro
committed
Remove not needed unset_node_entities_callbacks
Mauro
committed
fixes
Mauro
committed
Set gc's callback only if new node
Mauro
committed

Commits on Oct 19, 2020

Commits on Oct 20, 2020

Commits on Oct 21, 2020

Merge remote-tracking branch 'original/master' into irobot/add-events-executor
Soragna, Alberto
committed
Merge pull request ros2#28 from alsora/asoragna/merge-conflicts
iRobot ROS
authored
fix comments
alsora
committed
Merge pull request ros2#29 from alsora/asoragna/fix-comments
iRobot ROS
authored

Commits on Nov 13, 2020

Add spin_some default arg
Mauro Passerino
committed

Commits on Nov 17, 2020

Merge pull request ros2#30 from mauropasse/mauro/spin-no-args-support
iRobot ROS
authored

Commits on Nov 19, 2020

rename local_event_queue->execution_event_queue
Mauro Passerino
committed

Commits on Nov 20, 2020

Move rcutils/executor_event_types.h to rmw/
Mauro Passerino
committed
Merge pull request ros2#32 from mauropasse/mauro/pr-events-executor-2
iRobot ROS
authored
Merge branch 'irobot/add-events-executor' into mauro/pr-events-executor
Mauro Passerino
committed
rename event types
Mauro Passerino
committed
rename set_events_executor_callback to set_listener_callback
Mauro Passerino
committed
Revert. set_listener_callback->set_events_executor_callback
Mauro Passerino
committed
Merge pull request ros2#31 from mauropasse/mauro/pr-events-executor
iRobot ROS
authored

Commits on Dec 16, 2020

Add vectors of entities weak pointers
Mauro Passerino
committed
Use map for weak pointers
Mauro Passerino
committed
Use ownership model on timers
Mauro Passerino
committed
Use unordered map
Mauro Passerino
committed
release timers ownership when stopping
Mauro Passerino
committed

Commits on Dec 17, 2020

Rename functions
Mauro Passerino
committed
Remove entity if expired
Mauro Passerino
committed

Commits on Dec 18, 2020

Remove entities if not previously removed
Mauro Passerino
committed
Check if not removed before anything
Mauro Passerino
committed
Optimize get_<entities>
Mauro Passerino
committed
rename entity identifiers
Mauro Passerino
committed
clarify comment
Mauro Passerino
committed
clarify comment
Mauro Passerino
committed
refactor timers_manager ownership
Mauro Passerino
committed
Reimplement onwership timers
Mauro Passerino
committed

Commits on Jan 13, 2021

Correct ownership timers
Mauro Passerino
committed

Commits on Jan 14, 2021

remove mutex not needed since new ownership model
Mauro Passerino
committed
Move using TimerPtr to private section
Mauro Passerino
committed
If a timer was removed, re-heapify vector
Mauro Passerino
committed
rework timers manager weak ownership
alsora
committed
undo wrong replace
alsora
committed
cleanup linter errors
alsora
committed
Revert "If a timer was removed, re-heapify vector"
Mauro Passerino
committed
Revert "Move using TimerPtr to private section"
Mauro Passerino
committed
Merge pull request #5 from alsora/asoragna/entities-ownership
mauropasse
authored

Commits on Jan 15, 2021

EventsExecutorEntitiesCollector: Use shared_from_this()
Mauro Passerino
committed
Merge pull request ros2#33 from mauropasse/mauro/irobot-add-events-executor
iRobot ROS
authored
Merge remote-tracking branch 'upstream/master' into asoragna/cleanup-events-exec
Alberto Soragna
committed
remove some unnecessary diffs

Alberto Soragna
authored and
alsora
committed
Merge pull request ros2#34 from alsora/asoragna/cleanup-events-exec
iRobot ROS
authored
Update timers_manager.hpp documentation
Mauro Passerino
committed
Update doc
Mauro Passerino
committed

Commits on Jan 18, 2021

update APIs
Mauro Passerino
committed
Fix IPC on EventsExecutor and StaticSingle...
Mauro Passerino
committed
Add comment
Mauro Passerino
committed
Implement take_data on events_executor_notify_waitable
Mauro Passerino
committed
Compiler wants take_data defined on event_waitable.hpp
Mauro Passerino
committed
Merge pull request ros2#35 from mauropasse/mauro/irobot-add-events-executor
iRobot ROS
authored
Implement take_data only on derived classes
Mauro Passerino
committed
Fix tests compilation
Mauro Passerino
committed
fix linter errors
Mauro Passerino
committed

Commits on Jan 19, 2021

Fix TimersHeap::validate_and_lock()
Mauro Passerino
committed
Fix uncrustify errors
Mauro Passerino
committed
Fix cppcheck
Mauro Passerino
committed
Merge pull request ros2#36 from mauropasse/mauro/update-events-executor
iRobot ROS
authored

Commits on Jan 21, 2021

Merge branch 'master' into mauro/clean-events-executor
Mauro Passerino
committed
Reorder APIs arguments
Mauro Passerino
committed

Commits on Jan 22, 2021

Merge pull request ros2#37 from mauropasse/mauro/clean-events-executor
iRobot ROS
authored

Commits on Jan 27, 2021

Implement no-op on IPC subscription
Mauro Passerino
committed

Commits on Feb 1, 2021

Check if valid msg before dispatch
Mauro Passerino
committed
Add log when ring buffer is full
Mauro Passerino
committed
restore line. This shouldn't happen any more
Mauro Passerino
committed
Fix size_t log type
Mauro Passerino
committed
remove log about full ring buffer
Mauro Passerino
committed

Commits on Feb 4, 2021

Add events queue abstract class and implem
Mauro Passerino
committed

Commits on Feb 5, 2021

Apply PR suggestions
Mauro Passerino
committed
Fix ctests
Mauro Passerino
committed
EntitiesCollector not needed on events_queue
Mauro Passerino
committed
Add BoundedEventsQueue
Mauro Passerino
committed
Add unit tests for Simple and Bounded queues
Mauro Passerino
committed
Set size limit in constructor
Mauro Passerino
committed

Commits on Feb 8, 2021

Test all events queue APIs
Mauro Passerino
committed
Remove BoundedQueue, not ready yet for this
Mauro Passerino
committed
rename rmw_listener_cb_t->rmw_listener_callback_t
Mauro Passerino
committed
Merge pull request ros2#40 from mauropasse/mauro/add-events-queue-class-2
iRobot ROS
authored
Merge pull request ros2#41 from mauropasse/mauro/rename-data-type
iRobot ROS
authored
Merge pull request ros2#38 from mauropasse/mauro/clean-events-executor
iRobot ROS
authored

Commits on Feb 11, 2021

Ctests fixes
Mauro Passerino
committed

Commits on Feb 12, 2021

Merge pull request ros2#42 from mauropasse/mauro/fix-ctests
iRobot ROS
authored

Commits on Feb 15, 2021

Check validity of executor pointer
Mauro Passerino
committed
Merge pull request ros2#44 from mauropasse/mauro/check-push-event-valid-ptr
iRobot ROS
authored
use void * to pass executor ptr
Mauro Passerino
committed

Commits on Feb 17, 2021

Merge pull request ros2#45 from mauropasse/mauro/exec-void-ptr
iRobot ROS
authored
Proper spin_some behaviour on EventsExecutor
Mauro Passerino
committed

Commits on Feb 18, 2021

rework spin_some & spin_all
Mauro Passerino
committed

Commits on Feb 19, 2021

spin_some and spin_all call spin_some_impl
Mauro Passerino
committed
Use timer_was_ready_at_tp
Mauro Passerino
committed
Merge pull request ros2#46 from mauropasse/mauro/fix-spin-some-events-executor
iRobot ROS
authored
remove smart pointer definitions for virtual class

Alberto Soragna
authored and
alsora
committed

Commits on Feb 23, 2021

Merge pull request ros2#49 from irobot-ros/asoragna/cleanup
iRobot ROS
authored

Commits on Feb 26, 2021

Rework executor callback data
Mauro Passerino
committed
Use entity_id to compute hash. Add comments
Mauro Passerino
committed
Use RMW renamed file
Mauro Passerino
committed
fix hash type
Mauro Passerino
committed

Commits on Mar 10, 2021

Update EventsExecutorCallbackData
Mauro Passerino
committed
Add support for actions on EventsExecutor
Mauro Passerino
committed

Commits on Mar 11, 2021

Use RCLCPP_SMART_PTR_ALIASES_ONLY
Mauro Passerino
committed
Rename set_events_executor_callback->set_listener_callback
Mauro Passerino
committed
Merge pull request ros2#50 from mauropasse/mauro/group-callback-data
iRobot ROS
authored
Merge branch 'irobot/add-events-executor' into mauro/actions-support-2
Mauro Passerino
committed
Changes
Mauro Passerino
committed

Commits on Mar 15, 2021

time_until_trigger return MAX if canceled
Mauro Passerino
committed
time_until_trigger return MAX if canceled
Mauro Passerino
committed