Jspurlin jspurlin/combo box #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix TSLint errors in DragDropHelper.tsx * Add change file for PR
* Updating memoize to not fail in scenarios where it isn't implemented. * Adding changefile. * Updating test function.
…al params to createApp (microsoft#1939) * Add the ability to optionally pass in the app title and header links for createApp * Rush change
* add more semantic color slots * add chang efile * add documentation * address code review feedback * Update phkuo-glamor_2017-05-31-22-58.json
* Adding createTheme to exports. * Adding createTheme to exports.
* Updating all packages to use tslib. * Updating dependencies.
* Updating toggle to have a customizable theme. * Adding changefile. * Removing getTheme initializer which doesn't work in a memoized function.
* Updating node. * Update rush.json
* Make palette and font required for theme * Rush change * Update ThemePage.tsx * Rename theme to palette.
* Adding a try catch around set RTL * Fixing a typo comment * Adding the change file
* It seems the example-app-base didn't get published correctly, and the fabric-react version dependency is really old. * Adding major bump changefile.
* Adds required "length unit" to flex-basis value. * Adds change file. * Create joem-fix-textfield-flex-values_2017-06-08-00-07.json
…ecoupled the shared props/memebers from comboBox and Dropdown, and extended BaseAutoFill which allowed DynamicAutoFill to be removed
* Upgrade rtl-css-js version * Run shrinkwrap * Rush change
* First step at stepper implementation. * Add first implementation of stepper. * Add functionality to stepper * Refine the Stepper class and add tests * let's make sure to put focus back on the text field when submitting via enter * Added documentation to Stepper. * Add flexibility to current stepper implementation. * Modified example implementations. * Add aria-valuemax. * Change Stepper to SpinButton. * Add example with unit. * Implement color scheme in the ContextualMenu control to enable alternative theming. * Improvements to SpinButton. * Fix increment function calls. * Add new width optional parameter. * Add label direction. * Fix border. * Add Position enum. * `defaultValue` is now the deciding prop for using the default implementation or not. * onBlur is now onValidate. * Fix tests. * Fix warnings. * Add implementation for labelGap. * Put some polish on the styling, added some icon support, and added some more example spinButtons * Implement the bar and unit tests and component page * Add the ability for the spinButton buttons to look pressed when spinning via keyboard * Revert "Implement color scheme in the ContextualMenu control to enable alternative theming." This reverts commit 4f830cd. * Don't render an empty icon for an icon-less header menu item. * Revert "Implement Document Title Bar" * update some CSS for high contrast in ff and use css utility instead of concatenating string classnames * Fix quotation issue * Fix Spin Button properties table. * Fix Spin Button example code * Use iconProps instead of string * Extracted `spinning` out of state * Add autobind instead of manually binding private functions to this * Change `+` syntax for more explicit `Number()` * Remove unnecessary cast * Fix typos * `incrementButtonIcon` and `decrementButtonIcon` are now IIconProps * Add KeyboardSpinDirection enum * Fix test description * Fix SpinButton tests * Remove unused onChange callback from SpinButton * Revert onChange * Remove old Stepper.ts file * Use module css instead of global * Fix missing word in comment * Callback functions now allow for void return (state to be updated outside) * Use `_async` instead of window * Fix minor rendering issue with browser zoom * Rename `_spinning` to `_spinningByMouse` for clarity * Fix tests * Fix extra space before label * Remove width outside of SpinButton component and fix styling * Add more tests to SpinButton * Fix SpinButton documentation * Fix typo * Fix AppDefinition for SpinButton and Spinner * Add missing documentation to SpinButton title prop * Various SpinButton fixes * Fix SpinButton path for properties * Fix SpinButton styling issues * Remove labelGap property from SpinButton
…c-react into jspurlin/ComboBox
…nderOption instead. The fontFamily aspect was too specific for the generic comboBox
…1967) * Switch from React.HTMLProps to React.HTMLAttributes * Add rush files * Fix build
* Add 'cursor: pointer' to Toggle * Add change files
* Fix no implicit anys in utilities package. * Rush change * Reverse all shrinkwrap changes except the typings one.
* Updating shrinkwrap, rush, and making minify build have production flag to remove debug code. * Updates. * removing lockfile. * dropping to 7. Moving back to npm run build. * Downgrading rush.
* Use Fabric Core 7.1.0 for the website
* Adjust position of caret's in header so that they spin around central axis
* Update to latest icon font from dev.office.com for header and move outside out :global{} to fix build issue
* Remove a u- prefix that was missed earlier
* Update dev.office.com header with the latest navigation links
* Add change file
* withResponsiveMode: Adding error handling around the case where window.innerWidth throws an exception * adding change log file * Create withResponsiveMode.tsx
…e-ui-fabric-react into jspurlin-jspurlin/ComboBox
jspurlin
pushed a commit
that referenced
this pull request
Mar 20, 2018
…b font (microsoft#4206) * By default, use the system segoe-ui * Fix it more consistently * Rush change * Snapshot updates * Make it work for IE and Edge as well. * Update snapshots * Add some snapshots for the before state of createFontStyles * Refactor #1 * Update default font styles * Another refactor * Remove unused import * Update snapshot
jspurlin
pushed a commit
that referenced
this pull request
May 17, 2018
* Mv Slider implementation to .base.tsx * Export Slider.base * Slider impl with getStyles and interface imports * Refactor hierarchy to Slider.styles and expose via interfaces * Reflect current set of style attrs and globals * + changefile * Update Slider snapshot test * Refactor Slider tests to test SliderBase * Add SliderBase type param throughout Slider tests * Test Slider for snapshot comparison only * Minor typing fix per PR feedback.
jspurlin
pushed a commit
that referenced
this pull request
Oct 26, 2018
* Fix microsoft#6360 microsoft#12 - Unique IDs for CtxMenu demo page examples. * Fix microsoft#6360 #2: Add label for hover delay TextField example * Fix microsoft#6360 #1: Add aria-label to search input on filter CtxMenu example * Add changefiles * Update ContextualMenu snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
(give an overview)
Focus areas to test
(optional)