Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Manager shortcut remap only remains active when all keys are pressed #3331

Closed
WinkelCode opened this issue May 20, 2020 · 2 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@WinkelCode
Copy link

Environment

Windows build number: [Version 10.0.18363.836]
PowerToys version: 0.18.0
PowerToy module for which you are reporting the bug (if applicable): Keyboard Manager

Steps to reproduce

Remap Alt + Space to Win + Space

Expected behavior

The Keyboard language selector works as usual, it stays open when only holding the modifier key so you can slowly rotate through the available options.

I.e. As long as the previous keys of the shortcut are still being held the shortcut will remain active, only when either releasing the keys or pressing another button not part of the shortcut will it release or change the shortcut remap.

Actual behavior

The selector is kinda broken as the window will close immediately when releasing the space key while still holding the modifier key.

@arjunbalgovind
Copy link
Contributor

Can repro easily. This seems to be happening because of the current logic that we have which is like this:

  • If Alt+Space is remapped to Win+Space and the user presses Alt+Space and then lets go of Space we immediately revert back to Alt being held down logically. This was done so that a user can continue pressing something like Alt+Tab (or another other Alt shortcut) without having to let go of Alt.
    Maybe the logic has to be tweaked such that we switch back to Alt only if some other "non-remapped" shortcut is pressed.

@arjunbalgovind arjunbalgovind added the Issue-Bug Something isn't working label May 20, 2020
@saahmedm saahmedm added the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label May 29, 2020
@saahmedm saahmedm added this to the v1.0 Release milestone Jun 3, 2020
@arjunbalgovind arjunbalgovind added the Status-In progress This issue or work-item is under development label Jun 3, 2020
@arjunbalgovind arjunbalgovind self-assigned this Jun 5, 2020
@arjunbalgovind arjunbalgovind added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jun 5, 2020
@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release

@crutkas crutkas closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants