Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An intuitive placement of a download button or link near the viewer, in addition to the file manager at the bottom of the page #774

Closed
9 tasks
Tracked by #903
jillpe opened this issue Sep 8, 2023 · 4 comments
Closed
9 tasks
Tracked by #903

An intuitive placement of a download button or link near the viewer, in addition to the file manager at the bottom of the page #774

jillpe opened this issue Sep 8, 2023 · 4 comments
Assignees
@ShanaLMoore @kirkkwang
Labels
Blocked Sprint: Odds and Ends

Comments

@jillpe
Copy link

jillpe commented Sep 8, 2023 •
edited by ShanaLMoore
Loading

Summary

A download button and file manager is near the viewer in an intuitive spot for the user.

  • the file manager button is already near the viewer by default so we did not change this behavior.
  • a download button has been added. The download button will only display when the flag on the files tab is selected.

Acceptance Criteria

  • A download button and file manager is near the viewer in an intuitive spot for the user

Testing Instructions

  • Create or open the show page of a work with multiple PDFs attached to it
    NOTE: the File Manager button will not get displayed if there is only one file attached
    PS. No work was done on the file manager button. It is currently displaying default behavior.

  • Default Theme

    • Download button is in an intuitive spot
    • File manager is in an intuitive spot

  • Cultural Theme

    • Download button is in an intuitive spot
    • File manager is in an intuitive spot

  • Scholarly Theme

    • Download button is in an intuitive spot
    • File manager is in an intuitive spot

  • ReShare Theme

    • Download button is in an intuitive spot
    • File manager is in an intuitive spot
@jillpe jillpe mentioned this issue Sep 8, 2023
Closed
51 tasks
@kirkkwang
Copy link
Contributor

Possible solution can be adding a download button near the top so it hopefully won't interfere much with themes. The only other question is if we always show the download button or is it something like, when the viewer shows, show the download button, when it's just a thumbnail, don't show the download button?

image

@jillpe jillpe moved this to Ready for Development in palni-palci Sep 11, 2023
@ShanaLMoore ShanaLMoore mentioned this issue Sep 11, 2023
Merged
ShanaLMoore pushed a commit that referenced this issue Sep 15, 2023
🧹 [i774] - Updating index type to bsi (boolean)
a10ad25 
This commit is a follow up for issue #774 show_pdf_viewer and show_pdf_download_button should store boolean values and have a solr index type as _bsi.
@ShanaLMoore ShanaLMoore mentioned this issue Sep 15, 2023
Closed
ShanaLMoore pushed a commit that referenced this issue Sep 15, 2023
🧹 [i774] - Updating index type to bsi (boolean)
6f8c35c 
This commit is a follow up for issue #774 show_pdf_viewer and show_pdf_download_button should store boolean values and have a solr index type as _bsi.
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Sep 15, 2023 •
edited
Loading

QA RESULTS: Needs Rework ❌ Cultural theme button size looks weird

Tested with: https://dev.commons-archive.org/concern/generic_works/dd2d7762-8617-4f77-8210-28d572dce399?locale=en

Acceptance Criteria

  • A download button and file manager is near the viewer in an intuitive spot for the user

Testing Instructions

  • Create or open the show page of a work with a PDF attached to it

Default Theme

Pass ✅

SHOW PDF.JS VIEWER: FALSE

  • Download button is in an intuitive spot
  • File manager is in an intuitive spot
    image

SHOW PDF.JS VIEWER: TRUE

  • Download button is in an intuitive spot
  • File manager is in an intuitive spot

image

Cultural Theme

Needs Rework ❌

SHOW PDF.JS VIEWER: FALSE

  • Download button is in an intuitive spot ⚠️
    • Yes but it may look better if it's the same size as Citation.
  • File manager is in an intuitive spot
    image

SHOW PDF.JS VIEWER: TRUE

  • Download button is in an intuitive spot ⚠️
    - [ ] Yes but it may look better if it's the same size as Citation.

  • File manager is in an intuitive spot

    image

Scholarly Theme

Pass ✅

SHOW PDF.JS VIEWER: FALSE

  • Download button is in an intuitive spot
  • File manager is in an intuitive spot

image

SHOW PDF.JS VIEWER: TRUE

  • Download button is in an intuitive spot
  • File manager is in an intuitive spot

image

ReShare Theme ✅

  • Not relevant for QA: ReShare will not be using PDF.js

@ShanaLMoore ShanaLMoore moved this from Ready for Development to In Development in palni-palci Sep 15, 2023
@jillpe jillpe moved this from In Development to Ready for Development in palni-palci Sep 18, 2023
@ShanaLMoore ShanaLMoore moved this from Ready for Development to SoftServ QA in palni-palci Sep 18, 2023
@kirkkwang
Copy link
Contributor

Cultural Theme

Pass ✅

Image

@kirkkwang kirkkwang moved this from SoftServ QA to PALs QA in palni-palci Sep 18, 2023
@ndroark ndroark moved this from PALs QA to Deploy to Production in palni-palci Sep 18, 2023
@ShanaLMoore ShanaLMoore moved this from Deploy to Production to Client Verification in palni-palci Sep 21, 2023
@ShanaLMoore
Copy link
Contributor

Requires reindexing prod

@ndroark ndroark moved this from Client Verification to Done in palni-palci Oct 2, 2023
@jillpe jillpe closed this as completed Oct 3, 2023
@jillpe jillpe mentioned this issue Nov 8, 2023
Closed
32 tasks
jeremyf pushed a commit to samvera/hyku that referenced this issue Dec 19, 2023
@kirkkwang @jeremyf
🎁 Contributions from PALNI/PALCI
6a1e0c5 
Which were resolved via the following PRs:

- notch8/palni-palci#768
- notch8/palni-palci#786
- notch8/palni-palci#790
- notch8/palni-palci#807
- notch8/palni-palci#850
- notch8/palni-palci#781
- notch8/palni-palci#787
- notch8/palni-palci#795
- notch8/palni-palci#788
- notch8/palni-palci#793
- notch8/palni-palci#782
- notch8/palni-palci#798
- notch8/palni-palci#866
- notch8/palni-palci#846
- notch8/palni-palci#849
- notch8/palni-palci#868
- notch8/palni-palci#875
- notch8/palni-palci#884
- notch8/palni-palci#876
- notch8/palni-palci#952

Contribute back the following features:

- notch8/palni-palci#125
- notch8/palni-palci#740
- notch8/palni-palci#742
- notch8/palni-palci#746
- notch8/palni-palci#772
- notch8/palni-palci#773
- notch8/palni-palci#774
- notch8/palni-palci#776
- notch8/palni-palci#778
- notch8/palni-palci#839
- notch8/palni-palci#840
- notch8/palni-palci#864

Co-authored-by: Shana Moore <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
@jeremyf jeremyf mentioned this issue Dec 19, 2023
Closed
@jeremyf jeremyf mentioned this issue Dec 22, 2023
Closed
This was referenced Jan 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

@kirkkwang kirkkwang

Labels
Blocked Sprint: Odds and Ends
Projects
palni-palci
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @kirkkwang @jillpe