🐛 Fix user despositing to specific admin sets #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add back the ability for everyone to be able to create a work. This is one of the conditionals that need to be met for a user to deposit a work to an admin set. The other is already being met, which is that the user has to have either a depositor role for that specific admin set or in a group that has a depositor role for that specific admin set. Ref: - #864
ShanaLMoore
approved these changes
Oct 19, 2023
jeremyf
pushed a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Which were resolved via the following PRs: - notch8/palni-palci#768 - notch8/palni-palci#786 - notch8/palni-palci#790 - notch8/palni-palci#807 - notch8/palni-palci#850 - notch8/palni-palci#781 - notch8/palni-palci#787 - notch8/palni-palci#795 - notch8/palni-palci#788 - notch8/palni-palci#793 - notch8/palni-palci#782 - notch8/palni-palci#798 - notch8/palni-palci#866 - notch8/palni-palci#846 - notch8/palni-palci#849 - notch8/palni-palci#868 - notch8/palni-palci#875 - notch8/palni-palci#884 - notch8/palni-palci#876 - notch8/palni-palci#952 Contribute back the following features: - notch8/palni-palci#125 - notch8/palni-palci#740 - notch8/palni-palci#742 - notch8/palni-palci#746 - notch8/palni-palci#772 - notch8/palni-palci#773 - notch8/palni-palci#774 - notch8/palni-palci#776 - notch8/palni-palci#778 - notch8/palni-palci#839 - notch8/palni-palci#840 - notch8/palni-palci#864 Co-authored-by: Shana Moore <[email protected]> Co-authored-by: Kirk Wang <[email protected]>
This was referenced Dec 19, 2023
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
This commit will add back the ability for everyone to be able to create a work. This is one of the conditionals that need to be met for a user to deposit a work to an admin set. The other is already being met, which is that the user has to have either a depositor role for that specific admin set or in a group that has a depositor role for that specific admin set.
Ref:
Expected Behavior Before Changes
Prior to this commit, even if a user was granted the role of depositor to an admin set, they could not add a work. If they were added in a group that had the depositor role, they still were not able to create a work.
Expected Behavior After Changes
Now, users who have the depositor role or in a group with the depositor role can deposit to admin sets.
Screenshots / Video
Screen.Recording.2023-10-18.at.16.09.56.mp4