🎁 Enable snippet highlighting for search #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we are indexing the pdf text onto the parent record, adding a highlight to the matching search results and displaying the snippet in the search catalog.
kirkkwang
approved these changes
Sep 11, 2023
We could make our own css file and include it in application css |
added 2 commits
September 12, 2023 07:25
…/scientist-softserv/palni-palci into i772-enable-snippet-highlighting
jeremyf
pushed a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Which were resolved via the following PRs: - notch8/palni-palci#768 - notch8/palni-palci#786 - notch8/palni-palci#790 - notch8/palni-palci#807 - notch8/palni-palci#850 - notch8/palni-palci#781 - notch8/palni-palci#787 - notch8/palni-palci#795 - notch8/palni-palci#788 - notch8/palni-palci#793 - notch8/palni-palci#782 - notch8/palni-palci#798 - notch8/palni-palci#866 - notch8/palni-palci#846 - notch8/palni-palci#849 - notch8/palni-palci#868 - notch8/palni-palci#875 - notch8/palni-palci#884 - notch8/palni-palci#876 - notch8/palni-palci#952 Contribute back the following features: - notch8/palni-palci#125 - notch8/palni-palci#740 - notch8/palni-palci#742 - notch8/palni-palci#746 - notch8/palni-palci#772 - notch8/palni-palci#773 - notch8/palni-palci#774 - notch8/palni-palci#776 - notch8/palni-palci#778 - notch8/palni-palci#839 - notch8/palni-palci#840 - notch8/palni-palci#864 Co-authored-by: Shana Moore <[email protected]> Co-authored-by: Kirk Wang <[email protected]>
This was referenced Dec 19, 2023
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are indexing the pdf text onto the parent record, adding a highlight to the matching search results and displaying the snippet in the search catalog. An index will be required when we deploy to the various environments.
Story
Refs #772
Expected Behavior Before Changes
Search results were not displaying as a highlight on the search catalog page.
Expected Behavior After Changes