🐛 Skip rendering badges on search_only tenants #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
approved these changes
Dec 15, 2023
jeremyf
force-pushed
the
i951-search-only-skip-collection-type
branch
from
13d044c to
88f8a4c
Compare
*Background:* A search_only tenant renders SOLR documents that had home tenants different than the search_only tenant. Part of that rendering includes the underlying Work's collection type. The SOLR document stores the `Hyrax::CollectionType`'s ID. The search_only tenant might have the same ID for `Hyrax::CollectionType` but it is not the same thing. Further, the home tenant might have an ID that is not in the search_only tenant, which results in an `ActiveRecord::RecordNotFound` error. Prior to this commit, we always attempted to render the badge. With this commit, we add some guarding logic to avoid rendering the badge when we're likely not rendering within the SOLR documents home tenant. Related to: - #951 - samvera/hyku#1815
jeremyf
force-pushed
the
i951-search-only-skip-collection-type
branch
3 times, most recently
from
fad8bc0 to
94ed0c7
Compare
Prior to this commit we were relying on a SHA; one that looks like it might not be all that durable. With this commit, we instead favor using a test strategy to turn it on.
jeremyf
force-pushed
the
i951-search-only-skip-collection-type
branch
from
94ed0c7 to
f326a2b
Compare
jeremyf
pushed a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Which were resolved via the following PRs: - notch8/palni-palci#768 - notch8/palni-palci#786 - notch8/palni-palci#790 - notch8/palni-palci#807 - notch8/palni-palci#850 - notch8/palni-palci#781 - notch8/palni-palci#787 - notch8/palni-palci#795 - notch8/palni-palci#788 - notch8/palni-palci#793 - notch8/palni-palci#782 - notch8/palni-palci#798 - notch8/palni-palci#866 - notch8/palni-palci#846 - notch8/palni-palci#849 - notch8/palni-palci#868 - notch8/palni-palci#875 - notch8/palni-palci#884 - notch8/palni-palci#876 - notch8/palni-palci#952 Contribute back the following features: - notch8/palni-palci#125 - notch8/palni-palci#740 - notch8/palni-palci#742 - notch8/palni-palci#746 - notch8/palni-palci#772 - notch8/palni-palci#773 - notch8/palni-palci#774 - notch8/palni-palci#776 - notch8/palni-palci#778 - notch8/palni-palci#839 - notch8/palni-palci#840 - notch8/palni-palci#864 Co-authored-by: Shana Moore <[email protected]> Co-authored-by: Kirk Wang <[email protected]>
jeremyf
added a commit
to samvera/hyku
that referenced
this pull request
Dec 19, 2023
Related to Issues: - #1815 - notch8/palni-palci#951 Related to Pull Requests: - notch8/palni-palci#952
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: A search_only tenant renders SOLR documents that had home
tenants different than the search_only tenant. Part of that rendering
includes the underlying Work's collection type. The SOLR document
stores the
Hyrax::CollectionType's ID.The search_only tenant might have the same ID for
Hyrax::CollectionTypebut it is not the same thing. Further, the hometenant might have an ID that is not in the search_only tenant, which
results in an
ActiveRecord::RecordNotFounderror.Prior to this commit, we always attempted to render the badge.
With this commit, we add some guarding logic to avoid rendering the
badge when we're likely not rendering within the SOLR documents home
tenant.
Related to: