Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TTML percentage of extent and origin scaled down unnecessarily #3029

Closed
dhmmNagra opened this issue Dec 7, 2020 · 5 comments
Closed

TTML percentage of extent and origin scaled down unnecessarily #3029

dhmmNagra opened this issue Dec 7, 2020 · 5 comments
Assignees
@michellezhuogg
Labels
component: TTML The issue involves TTML subtitles specifically status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.1

Comments

@dhmmNagra
Copy link

dhmmNagra commented Dec 7, 2020 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
v3.0.6

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Win & Mac
Chrome v87, Firefox v83, Edge v87

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
https://dash.akamaized.net/dash264/CTA/imsc1/IT1-20171027_dash.mpd

What did you do?

  1. Play this stream
  2. Enable the English subtitle stream
  3. Observe the subtitles throughout

What did you expect to happen?
The specific percentage origin and extent attributes are expected to be honoured for correct placement.

What actually happened?
Subtitles appear at top left and off screen.

image

If a percentage is specified then the region width and height apply the scaling unnecessarily. Same issue exists for the origin just after.

https://github.com/google/shaka-player/blob/56bb045ff68325d6b9de7cb3d56265ce3162f164/lib/text/ttml_text_parser.js#L365
@michellezhuogg michellezhuogg self-assigned this Dec 7, 2020
@michellezhuogg
Copy link
Contributor

Hello @dhmmNagra , thank you for your report! Would you like to submit a PR for this?

@dhmmNagra dhmmNagra mentioned this issue Dec 8, 2020
Closed
@dhmmNagra
Copy link
Author

Hi @michellezhuogg thanks for the opportunity, I am drafting a PR - I'm a first time contributor so there will be a delay whilst my employer sorts out the CLA signing.

@david-hm-morgan
Copy link
Contributor

pull request drafted at #3044

shaka-bot pushed a commit that referenced this issue Feb 3, 2021
@michellezhuogg
fix: Fix build failures
2371bd8 
1. Added hdr as a property in stream when constructing.
Fixes build failure from commit
7137286 .
PR #3116
Issue #2813

2. Fixed the test error from commit
d3640d1 .
PR #3044
Issue #3029

3. Fixed the new line with no other arguments from commit
0845843 .
PR #3060

Change-Id: I5833e49c1a95172742c4ec820960c9c5a7bf0cca
@TheModMaker TheModMaker added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically and removed needs triage labels Feb 22, 2021
@TheModMaker TheModMaker added this to the v3.1 milestone Feb 22, 2021
@avelad
Copy link
Member

avelad commented Mar 31, 2021

I think that it was resolved with #3044 and d3640d1 so it could be closed, what do you think?

@david-hm-morgan
Copy link
Contributor

Yes its all been wrapped up already

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 30, 2021
@shaka-project shaka-project locked and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellezhuogg michellezhuogg

Labels
component: TTML The issue involves TTML subtitles specifically status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
6 participants
@TheModMaker @avelad @shaka-bot @michellezhuogg @david-hm-morgan @dhmmNagra