Skip to content

Commit

Permalink
fix: Fix build failures
Browse files Browse the repository at this point in the history
1. Added hdr as a property in stream when constructing.
Fixes build failure from commit
7137286 .
PR #3116
Issue #2813

2. Fixed the test error from commit
d3640d1 .
PR #3044
Issue #3029

3. Fixed the new line with no other arguments from commit
0845843 .
PR #3060

Change-Id: I5833e49c1a95172742c4ec820960c9c5a7bf0cca
  • Loading branch information
michellezhuogg committed Feb 2, 2021
1 parent 2634bc9 commit 2371bd8
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions lib/hls/hls_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -1365,6 +1365,7 @@ shaka.hls.HlsParser = class {
channelsCount,
audioSamplingRate: null,
closedCaptions,
hdr: undefined,
};

return {
Expand Down
2 changes: 2 additions & 0 deletions test/test/util/manifest_generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,8 @@ shaka.test.ManifestGenerator.Stream = class {
this.audioSamplingRate = null;
/** @type {Map.<string, string>} */
this.closedCaptions = null;
/** @type {(string|undefined)} */
this.hdr = undefined;
}

/** @type {shaka.extern.Stream} */
Expand Down
3 changes: 1 addition & 2 deletions test/text/ssa_text_parser_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,7 @@ describe('SsaTextParser', () => {
const expected = cues.map((cue) => {
if (cue.nestedCues) {
cue.nestedCues = cue.nestedCues.map(
(nestedCue) => jasmine.objectContaining(nestedCue)
);
(nestedCue) => jasmine.objectContaining(nestedCue));
}
return jasmine.objectContaining(cue);
});
Expand Down
2 changes: 1 addition & 1 deletion test/text/ttml_text_parser_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@ describe('TtmlTextParser', () => {
],
'<tt xmlns:tts="http://www.w3.org/ns/ttml#styling" tts:extent="1920px 1080px">' +
'<layout>' +
'<region xml:id="subtitleArea" tts:origin="108px 192px"/>' +
'<region xml:id="subtitleArea" tts:origin="192px 108px"/>' +
'</layout>' +
'<body region="subtitleArea"><div>' +
'<p begin="01:02.05" end="01:02:03.200">Test</p>' +
Expand Down

0 comments on commit 2371bd8

Please sign in to comment.