Extract HDR metadata from HLS manifests #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
commented
Jan 25, 2021
| @@ -44,6 +44,9 @@ shaka.util.MimeUtils = class { | |||
| components.push(mimeKey + '="' + value + '"'); | |||
| } | |||
| }); | |||
| if (stream.hdr == 'PQ') { | |||
There was a problem hiding this comment.
The HLS specification allows: SDR, PQ, HLG. Should we also add HLG to the list?
There was a problem hiding this comment.
@michellezhuogg do you have any preference about it?
There was a problem hiding this comment.
I am not familiar with HLG and its according mimetype. Shall we skip HLG until we are sure about how to represent it with mimetype?
There was a problem hiding this comment.
OK, I think it's best to skip it for now. So this is ready to be merged whenever you want.
michellezhuogg
approved these changes
Jan 26, 2021
shaka-bot
pushed a commit
that referenced
this pull request
Feb 3, 2021
1. Added hdr as a property in stream when constructing. Fixes build failure from commit 7137286 . PR #3116 Issue #2813 2. Fixed the test error from commit d3640d1 . PR #3044 Issue #3029 3. Fixed the new line with no other arguments from commit 0845843 . PR #3060 Change-Id: I5833e49c1a95172742c4ec820960c9c5a7bf0cca
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2813
More info: https://tools.ietf.org/html/draft-pantos-hls-rfc8216bis-08 , section 4.4.6.2. (VIDEO-RANGE)