fix TTML extent and origin percentage calculations #3029 #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-hm-morgan
changed the title
joeyparrish
requested changes
Dec 23, 2020
- !== replaced with != - whitespace
|
Hello @david-hm-morgan , Would you please resolve the conflicts and then we can merge your commit? |
|
Hi @michellezhuogg now resolved! |
michellezhuogg
approved these changes
Jan 29, 2021
shaka-bot
pushed a commit
that referenced
this pull request
Feb 3, 2021
1. Added hdr as a property in stream when constructing. Fixes build failure from commit 7137286 . PR #3116 Issue #2813 2. Fixed the test error from commit d3640d1 . PR #3044 Issue #3029 3. Fixed the new line with no other arguments from commit 0845843 . PR #3060 Change-Id: I5833e49c1a95172742c4ec820960c9c5a7bf0cca
|
Unfortunately, this change doesn't cherry-pick well to v2.5.x. I tried to clean it up and eventually gave up. It does cherry-pick cleanly to v3.0.x. This will be part of v3.0.8. |
|
It cherry-picked cleanly to v3.0.x, but the tests fail. So I think the changes may depend on some other changes in the TTML parser that didn't get cherry-picked. So this will be in v3.1.0 instead of v3.0.x. |
6 tasks
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.