Skip to content
This repository has been archived by the owner on May 21, 2022. It is now read-only.

Scrobbles last played track twice. #80

Closed
augustonasser opened this issue Apr 3, 2013 · 31 comments
Closed

Scrobbles last played track twice. #80

augustonasser opened this issue Apr 3, 2013 · 31 comments
Labels
bugs Functionality is broken. Ambiguous.

Comments

@augustonasser
Copy link

After I play an album, the last track is scrobbled but is kept on cache. When I play something again, SLS scrobbles this cached scrobble, so the song is scrobbled twice.

Galaxy X (brazilian Galaxy Nexus).
Default music player (Google Play).

@timurrrr
Copy link

timurrrr commented Jun 6, 2013

As a simple solution: can you make an option to filter out repeating scrobbles for the users of Google Play Music?
Not scrobbling in a rare "repeat one track" scenario is a small price for the correct scrobble numbers in the most common scenario.

@kevjs1982
Copy link

timurrr's suggestion would be perfect - Simple Last FM scrobbler works so much better than the official app when coping with Google Music but does have the knack of multiple scrobbles - just deleted 30 scrobbles of the last track I played in Google Music from Last FM :( It's very rare that I listen to the same track over and over and would rather loose those than have 100+ plays showing for one track in the last 7 days when it's more like a dozen in reality.

@Voodooguru
Copy link

I came here to report this bug, as I'm having this problem with Google Play music; it happens consistently, although the actual number of scrobbled final tracks varies from 2 to over 100. Timurrr's suggestion would be an acceptable solution, if it can't be easily fixed.

@bmos
Copy link

bmos commented Jul 2, 2013

I wouldn't call his solution “perfect" if it results in some people not having songs scrobbled.
This app isn't being actively developed right now AFAIK.

@timurrrr
Copy link

timurrrr commented Jul 3, 2013

if it results in some people not having songs scrobbled.

All songs will be scrobbled, but repeating plays will only be scrobbled once.
I admit it's not "perfect". Also, you can always switch back to the default behavior from the options menu...

@johnmaguire
Copy link

Really surprised that other people are having this issue. I haven't seen this at all.

@metanota
Copy link
Contributor

So you're the lucky one :) Sadly this issue still remains reproducible.

@johnmaguire
Copy link

Well now I'm paranoid. :) Perhaps I've got lots of false scrobbles. This happens using the Google Play Music app? How often do you get the false scrobbles would you say? And what phone/tablet are you using?

@timurrrr
Copy link

2013/11/11 John Maguire [email protected]

This happens using the Google Play Music app?

Yes

How often do you get the false scrobbles would you say?

Once for the last track of each album and many for each play before a
few-days pause.

And what phone/tablet are you using?

Reproduces with Galaxy Nexus, Nexus 4 and 7 at least.

@johnmaguire
Copy link

@timurrrr When you say "one for the last track of each album", is that when the last track of the album is also the end of the current playlist (e.g. once that song plays, playback stops)? I want to test on the Nexus 5.

And I'm confused what you mean by "before a few-days pause"?

@timurrrr
Copy link

@timurrrr https://github.com/timurrrr When you say "one for the last
track of each album", is that when the last track of the album is also the
end of the current playlist (e.g. once that song plays, playback stops)? I
want to test on the Nexus 5.

Yes, I think so.

@johnmaguire
Copy link

@timurrrr And what do you mean "many for each play before a few-days pause"? If you don't listen to music for a few days, it will scrobble the last track played many times?

@timurrrr
Copy link

If you don't listen to music for a few days, it will scrobble the last
track played many times?

Yes, exactly.
One thing to note is that these scrobbles end up in the cache first and are
then dumped online altogether when I start playing the next track.

@johnmaguire
Copy link

Just checked my scrobble cache and I'm at least having one symptom... The
song I last listened to is showing up in the cache despite it having
scrobbled before. I think I'll check out the SLS source in the next few
days and see if I can determine what's wrong...
On Nov 11, 2013 4:17 AM, "timurrrr" [email protected] wrote:

If you don't listen to music for a few days, it will scrobble the last
track played many times?

Yes, exactly.
One thing to note is that these scrobbles end up in the cache first and are
then dumped online altogether when I start playing the next track.


Reply to this email directly or view it on GitHubhttps://github.com//issues/80#issuecomment-28182952
.

@timurrrr
Copy link

Sounds great, thanks for your involvement!

@barsnick
Copy link

I observe exactly the same thing. Just by coincidence, I noticed it again this morning while checking my recent scrobbles in the Last.fm (Windows) desktop program. Even before resuming play in the music player, the last-listened-to track gets scrobbled twice.

It seems this is regardless of whether I pause playback midway through a track or an album, or the player stops at the end of an album.

I had this on my previous device, a Lenovo K900, but I can't figure out what the default music player app is called. Now I have this on my new device, a Sony Xperia Z2, using the Sony Walkman app.

I do not have any other last.fm app installed, nor have I given any other app than the Simple Scrobbler my last.fm credentials.

@arkdae
Copy link

arkdae commented Nov 6, 2014

I also have this problem with my new Sony Xperia Z3v and Google Play Music. Spotify scrobbles very reliably natively, but that app has its own problems. SLS works very well, but consistently scrobbles the last track twice.

I am willing to pay to get this fixed. I am also willing to help debug this problem. I can run debug builds with logs and send them to a devleoper. The one thing I can't do is fix it myself.

I really hope someone can take up this issue and get it fixed. That will bring me one more step closer to music listening nirvana.

@Sagehorn
Copy link

Same problem with google play music and shuttle. SLS scrobbles twice when single/last(?) track is played..

@a-r-db
Copy link
Contributor

a-r-db commented Apr 30, 2015

Duplicate #52
Potential solution. #149 Check it out!

@a-r-db a-r-db added the bugs Functionality is broken. Ambiguous. label May 1, 2015
@a-r-db
Copy link
Contributor

a-r-db commented May 2, 2015

@augustonasser @timurrrr @kevjs1982 @Voodooguru @johnmaguire @barsnick @arkdae @Sagehorn
https://drive.google.com/file/d/0B9lPaMaVVtiJYTVVVDR4YkU1QUU/view?usp=sharing
This is a beta testing version. Let me know if it solves your problem.
It has a different key so you'll have to uninstall and setup SLS again.

Please reply to me if this did or did not fix your issues. Thanks!

@arkdae
Copy link

arkdae commented May 5, 2015

This not only doesn't fix the issue for me, but seems to make it worse.

Firstly, I am not confident that I have this APK. When I go to about, it still lists as version 1.48. A build number or some other way to verify that I have installed this testing version would be helpful. I did uninstall the one from Google Play, because it said this one has a different signature, and then I clicked on the link in the email to install this one (after enabling unknown sources on my phone).

The original issue for me is two fold. First is as reported here. After completing a queue, if you start a new queue, the last song from the last queue will be scrobbled a second time. I often select whole albums to play, not just individual songs. So, in my example, I can select an album and hit the orange play button. When it is done, I can select a new album, hit the orange play button, and the last song from the last album will be scrobbled a second time as it starts playing the new album.

The second issue has been touched upon in this thread. I often pause and play music throughout the day, and from one day to the next. If I pause the music at night, for example, and then start it up again the next morning, I will have two scrobbles for the song, even though I never restarted the song, just picked up where it left off.

Now, with this version, I find that the second issue is worse. Previously, I would only get duplicate scrobbles. Now, I am getting many repeated scrobbles. It has only happened twice in the two days I have been using this version, but I have gotten six and seven identical consecutive scrobbles from this issue, where I would normally get only two.

So, please, undo this change, as it makes it worse for me.

Additional info: I'm running this on a Sony Xperia Z3V, with OS version 4.4.4

@arkdae
Copy link

arkdae commented May 5, 2015

Also, I would say that this is not a duplicate of issue #52 . In that, he states that the issue happens after every song, not just the last in a queue. Also, he states that it was fixed when he changed hardware.

@arkdae
Copy link

arkdae commented May 5, 2015

Sorry for the repeated messages, but one more thing. What is the option "Also scrobble when you've finished listening to a playlist?" I can't imagine what this will do, except scrobble a second time. I've disabled it, but it does not help.

@a-r-db
Copy link
Contributor

a-r-db commented May 6, 2015

@arkdae THANK YOU!!! Your feedback is much appreciated.
I am in the process of reverting a bunch of changes.
Please, send as many messages as you like.
I am currently having a shortage of testers.
Updates are useless if nobody tests them before the next release.

a-r-db pushed a commit that referenced this issue May 6, 2015
8tracks not scrobbling and other users are reporting our changes as
making things worse.
#80 @arkdae
@metanota
Copy link
Contributor

metanota commented May 6, 2015

@arkdae You haven't named the app that you're using for listening and scrobbling music so we can only guess, why it happens to be much harder for you then for anyone else ;)

There are my thoughts about the situation: your app sends both generic android intents together with app's specific ones. (I know for sure that PowerAmp does that, for example). Every intent processes separately, while poor sls tracks only one context at a time. It handles these different intents as like the user turn's on some another app for playing music, and decides that the track needs to be sent to server for every switching player (if it may be scrobbled at this point, of course). This behaviour is legit since user may be really switching his app... but it ruins everything when app is designed to send different intents from several names on every action.

When the application sends generic android intents, there is "Android Music Player" point appears in the "Enabled apps" menu point. It says "Won't scrobble music from this app"; do not believe it! For now I can't fix this programmatically, so users should uncheck this point manually. This was the issue before #149 and will remain after. sadly. @arkdae you may probably already done it before; but since you've completely removed the app to switch it with another one (with the different signature) the settings were restored to default "all checked" value.

TL;DR
@arkdae: go to the "Enabled apps" preference an uncheck all the scrobbling applications that you aren't using. "Android Music Player" is the most suspicious point in the list. Write me if it won't help.

developers: this issue have bothered me for the long time (see #94, #119, #123 for example) and I still didn't found the right solution. Forcing users to do some extra actions in preferences is very bad design decision (especially when the relation is unclear and punishes for not knowing it at the same time).

@arkdae
Copy link

arkdae commented May 7, 2015

No need to guess, just ask nicely. I am using Google Play Music. I did mention that in my first comment on this thread, but forgot to repeat it. For that I am deeply sorry.

@arkdae
Copy link

arkdae commented May 7, 2015

The only application listed in "Enabled apps" is "Android Music Player" I have unchecked that and I will monitor for any changes in behavior.

@arkdae
Copy link

arkdae commented May 7, 2015

When I uncheck "Android Music Player," there are no longer any scrobbles from Google Play Music to last.fm.

@arkdae
Copy link

arkdae commented May 7, 2015

This is interesting. After I completed playing an album, I then checked "Android Music Player" to resume scrobbling again. I selected a new album, and the last track of the previous album was scrobbled. My guess is that Google Play Music is sending some message to scrobble that last track again when you start playing a new song.

Perhaps there is some way to inspect the message or "intent" as you put it, to differentiate these secondary messages from actual plays?

Or, could some timing be put into place? My observation with duplicate scrobbles of the last track of a queue is that it doesn't scrobble until you start a new album or song. So, perhaps you'll get two messages in rapid succession, the last song, and the new one. If you just drop the first message, that should deal with duplicates in this instance. Since songs usually last more than one second, messages in rapid succession do not indicate actual plays.

@a-r-db
Copy link
Contributor

a-r-db commented Jun 30, 2016

Hello. If anybody wants a copy of the newest SLS that has fixed some bugs with Google Play Music,
please let me know. I provide support and maintenance for the lead developers.

Here is the main issue with scrobbling.

There are two major issues with doing this and two major compatibility issues.

SLS provides support for a variety of applications.
OR
SLS provides support for single track repeat and more structured scrobbling.

Some of these applications don't share track duration (well).
and
Some of these applications don't tell SLS when the track is paused or completed, so SLS cannot find out when the track officially started or finished.

I am manually going through all the applications to see which ones don't work with a more compatible scrobbling service.

The Queue method works for now.

@a-r-db
Copy link
Contributor

a-r-db commented Jul 8, 2016

Please try this version.

https://drive.google.com/open?id=0B9lPaMaVVtiJaGwwdkt0UjBNVHc

@a-r-db a-r-db closed this as completed Jul 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugs Functionality is broken. Ambiguous.
Projects
None yet
Development

No branches or pull requests