Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmuldrew/performance testing #345

Draft
wants to merge 77 commits into
base: develop
Choose a base branch
from
Draft

Dmuldrew/performance testing #345

wants to merge 77 commits into from

Conversation

dmuldrew
Copy link
Collaborator

@dmuldrew dmuldrew commented Feb 13, 2023 •
edited
Loading

Pull Request doc

Purpose

  1. Fix a bug where a single urban area was not compatible with iteration loop
  2. Fix immediate demand scaling for leap years
  3. Divide immediate demand by 1000 to get MW
  4. Optimize immediate charging code to only calculate demand shape once per state
  5. Create script to output US immediate demand pickle files on the dev server

Testing

manual testing

Time estimate

~15min

isond and others added 30 commits February 1, 2023 15:16
@isond @rouille
feat: adding data processing script (#243)
2851f06
@isond @rouille
feat: generate profiles for immediate charging (#266)
8c92469
@danielolsen @rouille
style: update style from #266
a50d408
@danielolsen @rouille
feat: add function to calculate VMT share for each day of the year (#298
2173fe0 
)
@isond @rouille
fix: negative dwell time calculation in data processing (#299)
c495e54
@isond @rouille
feat: generate profiles for smart charging (#287)
183f7cd
@dmuldrew @rouille
refactor: calculate constraints all at once (#300)
86a6a89
@dmuldrew @rouille
feat: generate charging profiles for immediate charging HDV (#302)
3c6ebdc
@dmuldrew @rouille
feat: generate charging profiles for smart charging HDV (#301)
906b757
@dmuldrew @rouille
refactor: move to common data columns (#311)
4223b77
@dmuldrew @rouille
refactor: reconcile LDV and HDV implementations into one (#314)
754e2f7
@dmuldrew @rouille
refactor: merge existing LDV and HDV implementations into a common co…
8e4a49a 
…debase (#318)
@rouille
docs: create demand electrification section
ebdb0b8
@dmuldrew @rouille
refactor: change scaling of LDV model year profiles (#321)
cd35848
@rouille
docs: write summary section of transportation electrification
80fd598
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
4f2e9f1
@rouille
Merge pull request #328 from Breakthrough-Energy/ben/docs
baeb485 
Add summary section of transportation electrification
@dmuldrew @rouille
feat: add demand profile interface
736444c
@rouille
docs: write capabilities and data section of transportation electrifi…
1768446 
…cation (#329)
@dmuldrew @rouille
refactor: merge LDV/HDV smart charging functions
f14b4e2
@rouille
docs: write user manual section of transportation electrification (#330)
273b57f
@dmuldrew @rouille
Merge pull request #327 from Breakthrough-Energy/dmuldrew/demand_prof…
c82ed86 
…ile_interface

feat: state demand profile interface function
@rouille
feat: write function to load NREL EFS annual data
e6e4b4c
@rouille
docs: fix docstrings (#334)
536dbd8
@rouille
feat: get VMT projections for states
cf558c4
@rouille
feat: calculate urban and rural annual VMT fractions (#333)
8b9edad
@rouille
Merge pull request #335 from Breakthrough-Energy/ben/nrel
0962ca7 
Retrieve the projected annual VMT from NREL EFS
@rouille
feat: generate scaling factors for each year (#337)
888420b
@rouille
docs: write methodology section of transportation electrification (#336)
3404d1c
@rouille
style: format files following black update (#341)
c3c5c72
@dmuldrew dmuldrew self-assigned this Feb 13, 2023
@rouille
Copy link
Collaborator

rouille commented Feb 13, 2023

In the generate_BEV_vehicle_profiles module, I would raise a ValueError within a else statement after the elif:

  • raise ValueError("Invalid veh_type. Choose from ldv | ldt | mdv | hdv")
  • raise ValueError("Invalid charging_strategy. Choose from immediate | smart")

@dmuldrew
fix: package install include scaling files
df014fd
@dmuldrew
feat: add timer for state processing
95b7c93
@dmuldrew
test: adjust annual scaling test
2ccee71
@dmuldrew
test: assert almost equal
f1f8114
@dmuldrew
feat: add census region cache script
cf62dd1
@dmuldrew
refactor: add correct file paths
120f7f5
@dmuldrew
fix: convert command line veh_range to int
897a5b3
@dmuldrew
fix: hdv immediate function call
2fca851
@dmuldrew
fix: output path as string
b038845
@dmuldrew
fix: script file pathes, shell scripts
e8639fa
@dmuldrew
refactor: add mdv/hdv script
9385929
@dmuldrew
fix: run all census regions
3c44807
@dmuldrew
fix: leap years in immediate_hdv_charging.py
3134d6c
@dmuldrew
fix: aggregation indentation
2f4f2e2
@dmuldrew
refactor: use demand shape cache; use state list
404c000
@dmuldrew
fix: separate dictionary bev_vmt from compute logic
4f21ddc
@dmuldrew
refactor: add LDV cases; cache refinement
a4d7386
@dmuldrew
feat: mdv/hdv demand shape cache
7b2f26b
@dmuldrew
feat: add LDV/LDT cache files
f073f16
@dmuldrew
fix: range length bug
77ce757
@dmuldrew
test: fix failing test
ea260c1
@dmuldrew
fix: process DC as urban area
2f64505
@dmuldrew
chore: flake, black formatting; doc string update
9ac1289
@jenhagg jenhagg force-pushed the transportation_electrification branch 2 times, most recently from 14b16b7 to 800792c Compare February 24, 2023 00:26
@rouille rouille force-pushed the transportation_electrification branch from 800792c to 59872b6 Compare February 24, 2023 12:45
@dmuldrew dmuldrew changed the base branch from transportation_electrification to develop February 24, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouille rouille rouille left review comments

@danlivengood danlivengood Awaiting requested review from danlivengood

@jenhagg jenhagg Awaiting requested review from jenhagg

At least 1 approving review is required to merge this pull request.

Assignees

@dmuldrew dmuldrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmuldrew @rouille @isond @danielolsen