Fix errors of clang-tidy-pr-comments

[kenji-miyake]

• https://github.com/autowarefoundation/autoware.universe/pull/332/files#r805538343
• feat(osqp_interface): add interface to give csc matrix directly to enable warm start for computation time improvement. #378 (review)

[kenji-miyake]

Sometimes it fails to check out?
https://github.com/autowarefoundation/autoware.universe/runs/5194193198?check_suite_focus=true

[kenji-miyake]

Not errors but a bit noisy.
#445 (comment)
#445 (comment)

[esteve]

@kenji-miyake is this issue still valid? I haven't seen this test fail on the CI lately

[kenji-miyake]

@esteve I guess it's still valid.

I haven't seen this test fail on the CI lately

It's because the workflow is disabled now.

The reason why I disabled it was it's noisy.

[kenji-miyake]

I think there are two ways to test this. (Except for the checkout issue.)

1. Re-enable the workflow.
2. Download the artifact of the build-and-test-differential workflow, and test it locally.
   

[kenji-miyake]

By the way, I should have used the Autoware Docker container here, because ubuntu-latest doesn't have necessary libraries.

autoware.universe/.github/workflows/clang-tidy-pr-comments.yaml

Line 13 in 7a6d391

runs-on: ubuntu-latest

-> Ah, it might be false. The generated artifacts might have all necessary information, so we can use any container for this workflow.

[kenji-miyake]

I re-enabled the workflow. If it's still noisy and contains a lot of errors, I'll disable it again. 😞

[kenji-miyake]

@esteve @xmfcx What do you think about this result? #997

fixes.yaml

[kenji-miyake]

Regarding these proposals, they should be done at once.

  - DiagnosticName:  modernize-pass-by-value
    DiagnosticMessage:
      Message:         'pass by value and use std::move'
      FilePath:        '/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/include/behavior_path_planner/scene_module/scene_module_bt_node_interface.hpp'
      FileOffset:      1000
      Replacements:
        - FilePath:        '/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/include/behavior_path_planner/scene_module/scene_module_bt_node_interface.hpp'
          Offset:          909
          Length:          0
          ReplacementText: '#include <utility>

'
        - FilePath:        '/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/include/behavior_path_planner/scene_module/scene_module_bt_node_interface.hpp'
          Offset:          1000
          Length:          19
          ReplacementText: 'std::string '
        - FilePath:        '/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/include/behavior_path_planner/scene_module/scene_module_bt_node_interface.hpp'
          Offset:          1037
          Length:          0
          ReplacementText: 'std::move('
        - FilePath:        '/__w/autoware.universe/autoware.universe/planning/behavior_path_planner/include/behavior_path_planner/scene_module/scene_module_bt_node_interface.hpp'
          Offset:          1038
          Length:          0
          ReplacementText: ')'

I guess technically we can send a PR to https://github.com/platisd/clang-tidy-pr-comments to fix this behavior, but it seems a bit difficult.

[kenji-miyake]

It might be useful if we can change the triggering event from workflow_run to workflow_dispatch so that we can run it anytime we want.

[kenji-miyake]

Another result. #723

[kenji-miyake]

I'll try to change the trigger condition of clang-tidy-pr-comments.yaml so that we can run it manually.
It's because currently we have too many issues and the check becomes a bit noisy.

Or if somebody is interested, you can implement it instead of me.

[kenji-miyake]

I think it's resolved by autowarefoundation/autoware-github-actions#172.