Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2130: Merge Dev to Test #914

Merged
merged 10 commits into from
Jan 20, 2023
Merged

BHBC-2130: Merge Dev to Test #914

merged 10 commits into from
Jan 20, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2130

Description of relevant changes

Promote Dev to Test.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

cgarrettjones and others added 5 commits January 5, 2023 15:14
Incorporate New Template Transformation Engine
* BHBC-2068: Migrate Keycloak to Standard Realm
 * Added User GUID as a required field when filling out the Add System User form.
 * API endpoints now distinguish users by GUID rather than user identifier
 * Added new Keycloak utils for parsing Keycloak tokens and determining GUIDs, identifiers
 * New User Service method to maintain system user records
 * Added user_guid to the system users table.
 * Removed IDIR test users from the users table seeder; Added user GUIDs to active developer IDIR accounts.
 * Distinguished BCeID basic and business identity sources
* Added a new endpoint and API hook for retreiving S3 files through the backend;
* Removed hardcoded links to S3 from the Resources page;
* Added helper functions for retrieving lists of files for a given S3 folder
* Replaced globally-scoped variables in the file utils module with appropriate getters
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #914 (03b793f) into test (4a8f3eb) will decrease coverage by 0.84%.
The diff coverage is 42.07%.

@@            Coverage Diff             @@
##             test     #914      +/-   ##
==========================================
- Coverage   66.48%   65.64%   -0.84%     
==========================================
  Files         339      353      +14     
  Lines       10877    11304     +427     
  Branches     1908     1966      +58     
==========================================
+ Hits         7232     7421     +189     
- Misses       3243     3488     +245     
+ Partials      402      395       -7     
Impacted Files Coverage Δ
.../src/paths/project/{projectId}/participants/get.ts 96.00% <ø> (ø)
api/src/paths/user/list.ts 85.71% <ø> (ø)
api/src/paths/user/self.ts 96.29% <ø> (ø)
api/src/paths/user/{userId}/get.ts 96.42% <ø> (ø)
api/src/repositories/error-repository.ts 100.00% <ø> (ø)
api/src/repositories/project-repository.ts 83.92% <ø> (ø)
api/src/repositories/validation-repository.ts 84.21% <ø> (ø)
api/src/services/summary-service.ts 82.14% <0.00%> (-2.61%) ⬇️
...utils/media/csv/validation/csv-header-validator.ts 94.44% <ø> (ø)
api/src/utils/media/media-utils.ts 78.72% <ø> (ø)
... and 72 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

KjartanE and others added 5 commits January 18, 2023 12:12
…912)

* Update api route annotations to disable sticky sessions
* Update pipeline files from latest biohub improvements
* Update git workflows from latest biohub workflows
* Disable codecov annotations
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@NickPhura NickPhura merged commit 5cb5f2a into test Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants