Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Time #1339

Merged
merged 25 commits into from
Mar 20, 2023
Merged

Redesign Time #1339

merged 25 commits into from
Mar 20, 2023

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Jan 17, 2023

Please check if the PR fulfills these requirements

Main modifies:

  • Redesign Time and unified time unit to second
  • Add oasis_ElapsedTime and oasis_DeltaTime for build-in shader variables
  • Migrate PhysicsManager maxAllowedTimeStep to Time maximumDeltaTime

@GuoLei1990 GuoLei1990 added this to the 1.0 milestone Jan 17, 2023
@GuoLei1990 GuoLei1990 requested a review from zhuxudong January 17, 2023 09:52
@GuoLei1990 GuoLei1990 marked this pull request as draft January 17, 2023 09:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +4.21 🎉

Comparison is base (6996eff) 45.05% compared to head (81c41f7) 49.27%.

❗ Current head 81c41f7 differs from pull request most recent head 12a8910. Consider uploading reports for the commit 12a8910 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.0    #1339      +/-   ##
===========================================
+ Coverage    45.05%   49.27%   +4.21%     
===========================================
  Files          361      361              
  Lines        18343    18358      +15     
  Branches      2636     2636              
===========================================
+ Hits          8265     9046     +781     
+ Misses        9302     8380     -922     
- Partials       776      932     +156     
Impacted Files Coverage Δ
packages/core/src/2d/text/SubFont.ts 12.90% <0.00%> (ø)
packages/core/src/Script.ts 89.23% <ø> (ø)
packages/core/src/animation/Animator.ts 12.83% <0.00%> (+4.11%) ⬆️
packages/core/src/particle/ParticleRenderer.ts 3.54% <0.00%> (ø)
packages/core/src/physics/PhysicsManager.ts 29.62% <0.00%> (-0.68%) ⬇️
packages/core/src/shadow/ShadowUtils.ts 3.20% <0.00%> (ø)
packages/loader/src/AnimatorControllerLoader.ts 6.12% <0.00%> (-0.40%) ⬇️
packages/core/src/Engine.ts 87.75% <75.00%> (ø)
...ges/core/src/RenderPipeline/BasicRenderPipeline.ts 56.29% <100.00%> (+4.63%) ⬆️
packages/core/src/Scene.ts 71.97% <100.00%> (+1.42%) ⬆️
... and 1 more

... and 54 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 mentioned this pull request Mar 16, 2023
37 tasks
* dev/1.0: (41 commits)
  fix: package.json
  Support device lost  (galacean#1374)
  "v0.9.0-beta.70"
  fix: add shadow parser (galacean#1411)
  Add `toJSON` in base math class (galacean#1380) (galacean#1409)
  refactor(particle): Add an infinite bounding box to the particle system and it will never be clipped (galacean#1410)
  "v0.9.0-beta.69"
  Fix glTF SkinnedMeshRenderer default local bounds (galacean#1405)
  Support shader replacement and sub shader (galacean#1394)
  Fix camera cull bug (galacean#1396)
  "v0.9.0-beta.68"
  fix: InputManager default listener target
  "v0.9.0-beta.67"
  Fix shader compile performance on some windows device (galacean#1390)
  Move font map cache from `Font` to `Engine` (galacean#1387)
  "v1.0.0-alpha.0"
  glTF parse support custom extsnions and parser (galacean#1008)
  Optimization `Transform` direction related API (galacean#1381)
  refactor: opt code
  refactor: opt code
  ...
@GuoLei1990 GuoLei1990 marked this pull request as ready for review March 16, 2023 07:35
@GuoLei1990 GuoLei1990 changed the title refactor Time Redesign Time Mar 16, 2023
@GuoLei1990 GuoLei1990 added enhancement New feature or request breaking breaking change labels Mar 16, 2023
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 01d8877 into galacean:dev/1.0 Mar 20, 2023
@GuoLei1990 GuoLei1990 deleted the pr/refactor-time branch September 18, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants