chore: creates TreeItem and basic Tree #25742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against ee15af6700870457f304bca6bcb4724a50b621f1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 632ac32:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6b90a6e90a71bb3ca36a6bc633d0d535ccb717e9 (build) |
bsunderhus
force-pushed
the
react-tree/chore--create-treeItem-and-basic-tree
branch
3 times, most recently
from
4d3e688 to
856d56f
Compare
ling1726
reviewed
Nov 23, 2022
packages/react-components/react-tree/src/components/Tree/useTree.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Nov 23, 2022
ling1726
reviewed
Nov 23, 2022
packages/react-components/react-tree/src/components/Tree/useTree.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Nov 23, 2022
packages/react-components/react-tree/src/components/Tree/useTree.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Nov 23, 2022
packages/react-components/react-tree/src/components/TreeItem/TreeItem.types.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Nov 23, 2022
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.ts
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Nov 23, 2022
packages/react-components/react-tree/src/components/TreeItem/useTreeItem.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-tree/chore--create-treeItem-and-basic-tree
branch
from
856d56f to
c626b50
Compare
bsunderhus
force-pushed
the
react-tree/chore--create-treeItem-and-basic-tree
branch
from
4307493 to
c7d0bb0
Compare
bsunderhus
force-pushed
the
react-tree/chore--create-treeItem-and-basic-tree
branch
from
c7d0bb0 to
48071f7
Compare
ling1726
reviewed
Nov 24, 2022
| return normalizeOpenSubtrees(openSubtrees); | ||
| } | ||
|
|
||
| function updateOpenSubtrees(data: TreeOpenChangeData, previousOpenSubtrees: string[]) { |
There was a problem hiding this comment.
not blocking, but have you considered using Set, I started using it for Table selection scenarios and honestly it makes updating things with ids so much cleaner
There was a problem hiding this comment.
Set is actually slower than Array.includes methods for small sets of data, according to some benchmarks. I'm not sure I'd go for that, but we might analyze that in the future
There was a problem hiding this comment.
yeah it's not about perf, but the code is much cleaner
ling1726
reviewed
Nov 24, 2022
packages/react-components/react-tree/src/components/Tree/useTree.ts
Outdated
Show resolved
Hide resolved
ling1726
approved these changes
Nov 24, 2022
…ee.ts Co-authored-by: ling1726 <[email protected]>
bsunderhus
deleted the
react-tree/chore--create-treeItem-and-basic-tree
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 29, 2022
* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* chore: initial Tree & TreeItem implementation * chore: convert context to use context selector * chore: converts focus to use a tree walker * Update packages/react-components/react-tree/src/components/Tree/useTree.ts Co-authored-by: ling1726 <[email protected]> Co-authored-by: ling1726 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
TreeandTreeItemTreeBranchandTreeLeafcomponentsNext steps
TreeItemLayoutcomponent to integrate proper design spec