Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add examples for DataGrid #25783

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

ling1726
Copy link
Member

Adds usages examples scenarios and props

Adds usages examples scenarios and props
@size-auditor
Copy link

size-auditor bot commented Nov 25, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0df4721efb626b749f2d4962526d9cdde745f53c (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.975 kB
17.687 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.411 kB
53.077 kB
react-components
react-components: FluentProvider & webLightTheme
33.48 kB
11.037 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 0df4721efb626b749f2d4962526d9cdde745f53c

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acc4c31:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1610 1724 5000
Button mount 1176 1182 5000
FluentProvider mount 1998 1923 5000
FluentProviderWithTheme mount 812 837 10
FluentProviderWithTheme virtual-rerender 760 764 10
FluentProviderWithTheme virtual-rerender-with-unmount 775 815 10
MakeStyles mount 2364 2414 50000
SpinButton mount 3180 3125 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.size+active+badge.normal.chromium.png 4 Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png 8 Changed

@ling1726 ling1726 merged commit c093fbb into microsoft:master Nov 25, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 29, 2022
* master: (34 commits)
  chore(react-tooltip): migrate to new package structure (microsoft#25818)
  chore(react-field): migrate to new package structure (microsoft#25817)
  Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772)
  feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710)
  fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806)
  feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786)
  applying package updates
  chore(react-spinbutton): migrate to new package structure (microsoft#25813)
  chore(react-spinner): migrate to new package structure (microsoft#25814)
  chore(react-provider): migrate to new package structure (microsoft#25809)
  chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810)
  chore(react-theme): migrate to new package structure (microsoft#25812)
  docs: add Fluent UI Insights EP04 to README (microsoft#25775)
  chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679)
  docs: Improves `Table` documentation (microsoft#25787)
  feat: improve react-18 tests (microsoft#25758)
  docs: Add examples for DataGrid (microsoft#25783)
  chore(react-tree): scaffold TreeItemLayout (microsoft#25781)
  perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754)
  chore: creates TreeItem and basic Tree (microsoft#25742)
  ...
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Adds usages examples scenarios and props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants