fix(tools): bump northstar packages v9 deps on dep mismatch resolution #25806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
commented
Nov 28, 2022
| @@ -197,7 +197,7 @@ export function isPackageVersionConverged(versionString: string) { | |||
|
|
|||
| export function isPackageVersionPrerelease(versionString: string) { | |||
| const version = semver.parse(versionString); | |||
| return version?.prerelease?.length && version?.prerelease?.length > 0; | |||
| return Boolean(version?.prerelease?.length && version?.prerelease?.length > 0); | |||
There was a problem hiding this comment.
casted to explicitly return boolean instead of undefined/number/boolean
|
|
||
| updateJson(tree, config.paths.packageJson, (packageJson: PackageJson) => { | ||
| if (packageJson.dependencies) { | ||
| packageJson.dependencies = getUpdatedDependencies(tree, packageJson.dependencies); | ||
| packageJson.dependencies = getUpdatedDependencies(tree, { dependencies: packageJson.dependencies, scope }); |
There was a problem hiding this comment.
more args needed -> refactored to options pattern
| @@ -125,7 +125,7 @@ describe('dependency-mismatch generator', () => { | |||
| }); | |||
| await generator(appTree); | |||
|
|
|||
| const packageJson: PackageJson = await readTargetPackageJson(); | |||
There was a problem hiding this comment.
these awaits dont do anything as readTargetPackageJson is sync
📊 Bundle size report🤖 This report was generated against 0da8d7556d18b42a7c702c513e702ba3723d64d3 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0da8d7556d18b42a7c702c513e702ba3723d64d3 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f3bd52a:
|
Hotell
changed the title
ling1726
reviewed
Nov 28, 2022
| @@ -73,3 +84,11 @@ function getUpdatedDependencies(tree: Tree, dependencies: Record<string, string> | |||
| return acc; | |||
| }, dependencies); | |||
| } | |||
|
|
|||
| function getProjectScope(project: ReturnType<typeof getProjectConfig>) { | |||
There was a problem hiding this comment.
yeah I was hesitant about that :D , we can do that later if we find shared usage for this
There was a problem hiding this comment.
will do a follow - normalizing all tags and tweaking this to utils
ling1726
approved these changes
Nov 28, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 29, 2022
* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)