Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Fluent UI Insights EP04 to README #25775

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

layershifter
Copy link
Member

New Behavior

Fluent UI Insights EP04 is present in README.

@size-auditor
Copy link

size-auditor bot commented Nov 24, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0da8d7556d18b42a7c702c513e702ba3723d64d3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1598 1546 5000
Button mount 1134 1112 5000
FluentProvider mount 1868 1854 5000
FluentProviderWithTheme mount 751 743 10
FluentProviderWithTheme virtual-rerender 691 700 10
FluentProviderWithTheme virtual-rerender-with-unmount 741 737 10
MakeStyles mount 2285 2257 50000
SpinButton mount 3024 3067 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a372092:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2022

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 2 screenshots added, 0 screenshots removed, 1037 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png 0 Added
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png 0 Added

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.153 kB
1.299 kB
react-accordion
Accordion (including children components)
79.294 kB
24.443 kB
react-alert
Alert
86.891 kB
21.708 kB
react-avatar
Avatar
51.076 kB
14.285 kB
react-avatar
AvatarGroup
15.006 kB
6.009 kB
react-avatar
AvatarGroupItem
65.654 kB
18.382 kB
react-badge
Badge
23.357 kB
7.361 kB
react-badge
CounterBadge
24.247 kB
7.643 kB
react-badge
PresenceBadge
24.001 kB
7.049 kB
react-button
Button
36.86 kB
9.913 kB
react-button
CompoundButton
43.885 kB
11.131 kB
react-button
MenuButton
41.537 kB
11.187 kB
react-button
SplitButton
48.983 kB
12.588 kB
react-button
ToggleButton
52.685 kB
11.415 kB
react-card
Card - All
71.873 kB
20.936 kB
react-card
Card
67.651 kB
19.892 kB
react-card
CardFooter
8.617 kB
3.62 kB
react-card
CardHeader
9.792 kB
3.995 kB
react-card
CardPreview
8.718 kB
3.674 kB
react-combobox
Combobox (including child components)
78.244 kB
25.015 kB
react-combobox
Dropdown (including child components)
77.531 kB
24.927 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.975 kB
17.687 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.411 kB
53.077 kB
react-components
react-components: FluentProvider & webLightTheme
33.48 kB
11.037 kB
react-dialog
Dialog (including children components)
83.036 kB
24.754 kB
react-divider
Divider
16.515 kB
5.921 kB
react-image
Image
10.836 kB
4.283 kB
react-infobutton
InfoButton
117.922 kB
35.391 kB
react-input
Input
24.194 kB
7.89 kB
react-label
Label
9.394 kB
3.88 kB
react-link
Link
11.862 kB
4.885 kB
react-menu
Menu (including children components)
117.61 kB
36.287 kB
react-menu
Menu (including selectable components)
120.679 kB
36.82 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
57.131 kB
15.951 kB
react-popover
Popover
103.666 kB
31.858 kB
react-portal
Portal
10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.826 kB
7.417 kB
react-progress
Progress
13.536 kB
5.107 kB
react-provider
FluentProvider
15.817 kB
5.905 kB
react-radio
Radio
36.446 kB
12.123 kB
react-radio
RadioGroup
14.304 kB
5.72 kB
react-select
Select
23.474 kB
8.017 kB
react-slider
Slider
32.118 kB
10.192 kB
react-spinbutton
SpinButton
44.502 kB
12.812 kB
react-spinner
Spinner
20.013 kB
6.446 kB
react-switch
Switch
33.453 kB
10.581 kB
react-text
Text - Default
11.838 kB
4.625 kB
react-text
Text - Wrappers
15.148 kB
5.06 kB
react-textarea
Textarea
25.733 kB
8.328 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.722 kB
6.462 kB
react-theme
Teams: Light theme
17.51 kB
5.075 kB
react-tooltip
Tooltip
42.032 kB
14.739 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 0da8d7556d18b42a7c702c513e702ba3723d64d3

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2022

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.size+active+badge.normal.chromium.png 16 Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png 4 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 301 277 1.09:1
FormMinimalPerf.default 433 399 1.09:1
GridMinimalPerf.default 377 345 1.09:1
RefMinimalPerf.default 231 211 1.09:1
AttachmentMinimalPerf.default 173 160 1.08:1
HeaderMinimalPerf.default 402 374 1.07:1
LoaderMinimalPerf.default 365 345 1.06:1
PortalMinimalPerf.default 173 163 1.06:1
SkeletonMinimalPerf.default 397 375 1.06:1
AccordionMinimalPerf.default 159 152 1.05:1
AvatarMinimalPerf.default 216 205 1.05:1
LabelMinimalPerf.default 425 406 1.05:1
TableMinimalPerf.default 454 432 1.05:1
AnimationMinimalPerf.default 590 570 1.04:1
ButtonSlotsPerf.default 637 615 1.04:1
DividerMinimalPerf.default 394 380 1.04:1
ListMinimalPerf.default 571 551 1.04:1
AttachmentSlotsPerf.default 1229 1192 1.03:1
DatepickerMinimalPerf.default 6270 6116 1.03:1
EmbedMinimalPerf.default 4089 3983 1.03:1
HeaderSlotsPerf.default 870 847 1.03:1
RadioGroupMinimalPerf.default 488 476 1.03:1
TableManyItemsPerf.default 2120 2067 1.03:1
TextMinimalPerf.default 369 359 1.03:1
LayoutMinimalPerf.default 383 374 1.02:1
ListNestedPerf.default 613 599 1.02:1
MenuButtonMinimalPerf.default 1864 1827 1.02:1
RosterPerf.default 2407 2362 1.02:1
PopupMinimalPerf.default 662 647 1.02:1
SegmentMinimalPerf.default 370 364 1.02:1
SliderMinimalPerf.default 1724 1687 1.02:1
IconMinimalPerf.default 711 694 1.02:1
CustomToolbarPrototype.default 2787 2736 1.02:1
ButtonOverridesMissPerf.default 1454 1442 1.01:1
ChatWithPopoverPerf.default 401 398 1.01:1
CheckboxMinimalPerf.default 2334 2317 1.01:1
DialogMinimalPerf.default 837 826 1.01:1
DropdownManyItemsPerf.default 742 734 1.01:1
DropdownMinimalPerf.default 2834 2809 1.01:1
ItemLayoutMinimalPerf.default 1308 1290 1.01:1
ListWith60ListItems.default 673 664 1.01:1
ProviderMinimalPerf.default 418 413 1.01:1
StatusMinimalPerf.default 737 732 1.01:1
TooltipMinimalPerf.default 2546 2522 1.01:1
TreeMinimalPerf.default 876 867 1.01:1
VideoMinimalPerf.default 792 788 1.01:1
CarouselMinimalPerf.default 508 507 1:1
InputMinimalPerf.default 1227 1229 1:1
ListCommonPerf.default 683 683 1:1
ProviderMergeThemesPerf.default 1280 1275 1:1
ReactionMinimalPerf.default 422 424 1:1
SplitButtonMinimalPerf.default 4787 4769 1:1
TreeWith60ListItems.default 173 173 1:1
CardMinimalPerf.default 593 601 0.99:1
ChatMinimalPerf.default 789 793 0.99:1
FlexMinimalPerf.default 301 305 0.99:1
MenuMinimalPerf.default 911 920 0.99:1
TextAreaMinimalPerf.default 539 542 0.99:1
BoxMinimalPerf.default 360 368 0.98:1
ImageMinimalPerf.default 421 429 0.98:1
ToolbarMinimalPerf.default 1016 1039 0.98:1
AlertMinimalPerf.default 292 301 0.97:1
ButtonMinimalPerf.default 181 188 0.96:1

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 24, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1376 1383 5000
Breadcrumb mount 3469 3468 1000
Checkbox mount 3102 3043 5000
CheckboxBase mount 2737 2777 5000
ChoiceGroup mount 5187 5186 5000
ComboBox mount 1451 1529 1000
CommandBar mount 11094 11233 1000
ContextualMenu mount 12581 12537 1000
DefaultButton mount 1615 1615 5000
DetailsRow mount 4279 4299 5000
DetailsRowFast mount 4207 4103 5000
DetailsRowNoStyles mount 4056 4074 5000
Dialog mount 3615 3607 1000
DocumentCardTitle mount 664 683 1000
Dropdown mount 3840 3759 5000
FocusTrapZone mount 2299 2332 5000
FocusZone mount 2256 2402 5000
GroupedList mount 2227 2496 2
GroupedList virtual-rerender 1312 1328 2
GroupedList virtual-rerender-with-unmount 1899 1925 2
GroupedListV2 mount 663 665 2
GroupedListV2 virtual-rerender 624 650 2
GroupedListV2 virtual-rerender-with-unmount 654 657 2
IconButton mount 2223 2244 5000
Label mount 832 859 5000
Layer mount 5051 5059 5000
Link mount 968 957 5000
MenuButton mount 1941 1966 5000
MessageBar mount 2740 2747 5000
Nav mount 3743 3796 1000
OverflowSet mount 1569 1584 5000
Panel mount 2972 3030 1000
Persona mount 1455 1547 1000
Pivot mount 1898 1926 1000
PrimaryButton mount 1787 1769 5000
Rating mount 8053 8247 5000
SearchBox mount 1756 1750 5000
Shimmer mount 3330 3374 5000
Slider mount 2493 2474 5000
SpinButton mount 5396 5423 5000
Spinner mount 946 952 5000
SplitButton mount 3609 3664 5000
Stack mount 1004 952 5000
StackWithIntrinsicChildren mount 2802 2799 5000
StackWithTextChildren mount 5705 5780 5000
SwatchColorPicker mount 12157 12197 5000
TagPicker mount 3130 3100 5000
TeachingBubble mount 95103 95855 5000
Text mount 927 915 5000
TextField mount 1853 1827 5000
ThemeProvider mount 1771 1785 5000
ThemeProvider virtual-rerender 1248 1262 5000
ThemeProvider virtual-rerender-with-unmount 2489 2535 5000
Toggle mount 1310 1316 5000
buttonNative mount 635 654 5000

@layershifter layershifter marked this pull request as ready for review November 28, 2022 18:07
@layershifter layershifter reopened this Nov 28, 2022
@layershifter layershifter enabled auto-merge (squash) November 28, 2022 18:29
@layershifter layershifter merged commit c732446 into microsoft:master Nov 28, 2022
@layershifter layershifter deleted the docs/ep04 branch November 28, 2022 19:16
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 29, 2022
* master: (34 commits)
  chore(react-tooltip): migrate to new package structure (microsoft#25818)
  chore(react-field): migrate to new package structure (microsoft#25817)
  Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772)
  feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710)
  fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806)
  feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786)
  applying package updates
  chore(react-spinbutton): migrate to new package structure (microsoft#25813)
  chore(react-spinner): migrate to new package structure (microsoft#25814)
  chore(react-provider): migrate to new package structure (microsoft#25809)
  chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810)
  chore(react-theme): migrate to new package structure (microsoft#25812)
  docs: add Fluent UI Insights EP04 to README (microsoft#25775)
  chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679)
  docs: Improves `Table` documentation (microsoft#25787)
  feat: improve react-18 tests (microsoft#25758)
  docs: Add examples for DataGrid (microsoft#25783)
  chore(react-tree): scaffold TreeItemLayout (microsoft#25781)
  perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754)
  chore: creates TreeItem and basic Tree (microsoft#25742)
  ...
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants