-
-
Notifications
You must be signed in to change notification settings - Fork 44
Comparing changes
Open a pull request
base repository: rubocop/rubocop-minitest
base: v0.22.2
head repository: rubocop/rubocop-minitest
compare: v0.27.0
Commits on Oct 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6e78333 - Browse repository at this point
Copy the full SHA 6e78333View commit details
Commits on Oct 13, 2022
-
[Fix #157] Add new
Minitest/EmptyLineBeforeAssertionMethods
copFixes #157. This PR adds new `Minitest/EmptyLineBeforeAssertionMethods` cop. This cop enforces empty line before assertion method because it separates assertion phase. ```ruby # bad do_something assert_equal(expected, actual) # good do_something assert_equal(expected, actual) ```
Configuration menu - View commit details
-
Copy full SHA for 6d8a9e7 - Browse repository at this point
Copy the full SHA 6d8a9e7View commit details
Commits on Oct 15, 2022
-
Merge pull request #163 from koic/add_new_minitest_empty_line_before_…
…assertion_method_cop [Fix #157] Add new `Minitest/EmptyLineBeforeAssertionMethods` cop
Configuration menu - View commit details
-
Copy full SHA for 11f5529 - Browse repository at this point
Copy the full SHA 11f5529View commit details
Commits on Oct 29, 2022
-
Follow up rubocop/rubocop#10987. ```console % bundle exec rake (snip) NoMethodError: undefined method `disabled' for nil:NilClass registry.disabled(config).each do |cop| ^^^^^^^^^ /Users/koic/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/rubocop-479e588e16cd/lib/rubocop/comment_config.rb:94:in `inject_disabled_cops_directives' /Users/koic/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/rubocop-479e588e16cd/lib/rubocop/comment_config.rb:78:in `analyze' /Users/koic/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/rubocop-479e588e16cd/lib/rubocop/comment_config.rb:45:in `cop_disabled_line_ranges' ``` It supports multiple RuboCop core versions for compatibility with #156.
Configuration menu - View commit details
-
Copy full SHA for 0234244 - Browse repository at this point
Copy the full SHA 0234244View commit details
Commits on Oct 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4f0c4aa - Browse repository at this point
Copy the full SHA 4f0c4aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17cdc58 - Browse repository at this point
Copy the full SHA 17cdc58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c13d92 - Browse repository at this point
Copy the full SHA 1c13d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3176a8 - Browse repository at this point
Copy the full SHA e3176a8View commit details
Commits on Oct 31, 2022
-
[Fix #187] Fix an error for
Minitest/EmptyLineBeforeAssertionMethods
Fixes #187. This PR fixes an error for `Minitest/EmptyLineBeforeAssertionMethods` when using method call with block.
Configuration menu - View commit details
-
Copy full SHA for 1bb5d1b - Browse repository at this point
Copy the full SHA 1bb5d1bView commit details -
Merge pull request #188 from koic/fix_an_error_for_minitest_empty_lin…
…e_before_assertion_methods [Fix #187] Fix an error for `Minitest/EmptyLineBeforeAssertionMethods`
Configuration menu - View commit details
-
Copy full SHA for 7864020 - Browse repository at this point
Copy the full SHA 7864020View commit details
Commits on Nov 1, 2022
-
Fix a false negative for
Minitest/EmptyLineBeforeAssertionMethods
Fixes part of #189. This PR fixes a false negative for `Minitest/EmptyLineBeforeAssertionMethods` when using non assertion method statement before assertion method used in a block.
Configuration menu - View commit details
-
Copy full SHA for 7d612d7 - Browse repository at this point
Copy the full SHA 7d612d7View commit details
Commits on Nov 2, 2022
-
[Fix #190] Fix an incorrect autocorrect for `Minitest/EmptyLineBefore…
…AssertionMethods` Fixes #190. This PR fixes an incorrect autocorrect for `Minitest/EmptyLineBeforeAssertionMethods` when using method call with source code comment before assertion method.
Configuration menu - View commit details
-
Copy full SHA for 980995b - Browse repository at this point
Copy the full SHA 980995bView commit details -
Merge pull request #191 from koic/fix_false_negative_for_minitest_emp…
…ty_line_before_assertion_methods Fix a false negative for `Minitest/EmptyLineBeforeAssertionMethods`
Configuration menu - View commit details
-
Copy full SHA for 62abedc - Browse repository at this point
Copy the full SHA 62abedcView commit details
Commits on Nov 3, 2022
-
Fix a false positive for
Minitest/EmptyLineBeforeAssertionMethods
Follow up #189 (comment). This PR fixes a false positive for `Minitest/EmptyLineBeforeAssertionMethods` when using `rescue` before assertion method.
Configuration menu - View commit details
-
Copy full SHA for e3b4936 - Browse repository at this point
Copy the full SHA e3b4936View commit details
Commits on Nov 4, 2022
-
Merge pull request #193 from koic/fix_a_false_positive_for_minitest_e…
…mpty_line_before_assertion_methods Fix a false positive for `Minitest/EmptyLineBeforeAssertionMethods`
Configuration menu - View commit details
-
Copy full SHA for 80595d0 - Browse repository at this point
Copy the full SHA 80595d0View commit details -
Merge pull request #192 from koic/fix_an_incorrect_autocorrect_for_mi…
…nitest_empty_line_before_assertion_methods [Fix #190] Fix an incorrect autocorrect for `Minitest/EmptyLineBeforeAssertionMethods`
Configuration menu - View commit details
-
Copy full SHA for f4c6b6a - Browse repository at this point
Copy the full SHA f4c6b6aView commit details -
[Fix #189] Fix a false positive for `Minitest/EmptyLineBeforeAssertio…
Configuration menu - View commit details
-
Copy full SHA for ec4848c - Browse repository at this point
Copy the full SHA ec4848cView commit details
Commits on Nov 5, 2022
-
Merge pull request #195 from koic/fix_false_positive_for_minitest_emp…
…ty_line_before_assertion_methods [Fix #189] Fix a false positive for `Minitest/EmptyLineBeforeAssertionMethods`
Configuration menu - View commit details
-
Copy full SHA for acdbdef - Browse repository at this point
Copy the full SHA acdbdefView commit details
Commits on Nov 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 038f8f0 - Browse repository at this point
Copy the full SHA 038f8f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e45ad2 - Browse repository at this point
Copy the full SHA 0e45ad2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e822d6e - Browse repository at this point
Copy the full SHA e822d6eView commit details
Commits on Nov 11, 2022
-
[Fix #196] Fix a false positive for
EmptyLineBeforeAssertionMethods
Addresses #196 Fix a false positive when using an assertion method as the first line within a test block Co-authored-by: Ryan Quanz <ryan.quanz@shopify.com>
Configuration menu - View commit details
-
Copy full SHA for 8802a80 - Browse repository at this point
Copy the full SHA 8802a80View commit details -
Merge pull request #197 from krishanbhasin-shopify/master
Fix a false positive for `Minitest/EmptyLineBeforeAssertionMethods`
Configuration menu - View commit details
-
Copy full SHA for dca5659 - Browse repository at this point
Copy the full SHA dca5659View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bfe349 - Browse repository at this point
Copy the full SHA 5bfe349View commit details -
Configuration menu - View commit details
-
Copy full SHA for f126ead - Browse repository at this point
Copy the full SHA f126eadView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4f9d8b - Browse repository at this point
Copy the full SHA c4f9d8bView commit details
Commits on Nov 12, 2022
-
Apply some changelog format tests to changelog directory
This commit applies some changelog format tests to changelog directory to prevent the following error when running `rake changelog:merge`. ```console % bundle exec rake changelog:merge rake aborted! NoMethodError: undefined method `[]' for nil:NilClass entry.match(/\. \((?<contributors>.+)\)\n/)[:contributors].split(',') ^^^^^^^^^^^^^^^ /Users/koic/src/github.com/rubocop/rubocop-minitest/tasks/changelog.rb:130:in `block in contributors' /Users/koic/src/github.com/rubocop/rubocop-minitest/tasks/changelog.rb:129:in `each' /Users/koic/src/github.com/rubocop/rubocop-minitest/tasks/changelog.rb:129:in `flat_map' /Users/koic/src/github.com/rubocop/rubocop-minitest/tasks/changelog.rb:129:in `contributors' /Users/koic/src/github.com/rubocop/rubocop-minitest/tasks/changelog.rb:123:in `new_contributor_lines' /Users/koic/src/github.com/rubocop/rubocop-minitest/tasks/changelog.rb:105:in `merge_content' /Users/koic/src/github.com/rubocop/rubocop-minitest/tasks/changelog.rb:94:in `merge!' tasks/changelog.rake:21:in `block (2 levels) in <top (required)>' /Users/koic/.rbenv/versions/3.1.2/bin/bundle:25:in `load' /Users/koic/.rbenv/versions/3.1.2/bin/bundle:25:in `<main>' Tasks: TOP => changelog:merge (See full trace by running task with --trace) ``` This error occurs when there is no period in the changelog format. It is because the tests applied to CHANGELOG.md were not applied to the changelog directory.
Configuration menu - View commit details
-
Copy full SHA for 06bd6bf - Browse repository at this point
Copy the full SHA 06bd6bfView commit details
Commits on Nov 22, 2022
-
It needs to be `File.read` to test a changelog content. Otherwise it remains the path returned by `Dir.glob`.
Configuration menu - View commit details
-
Copy full SHA for 870dad0 - Browse repository at this point
Copy the full SHA 870dad0View commit details
Commits on Nov 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 87abc2c - Browse repository at this point
Copy the full SHA 87abc2cView commit details
Commits on Nov 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f2d0dda - Browse repository at this point
Copy the full SHA f2d0ddaView commit details
Commits on Nov 25, 2022
-
Merge pull request #199 from fatkodima/skip_without_comment-cop
Add new `Minitest/SkipWithoutComment` cop
Configuration menu - View commit details
-
Copy full SHA for aa58a56 - Browse repository at this point
Copy the full SHA aa58a56View commit details
Commits on Nov 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 28d63d8 - Browse repository at this point
Copy the full SHA 28d63d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0223d10 - Browse repository at this point
Copy the full SHA 0223d10View commit details -
Configuration menu - View commit details
-
Copy full SHA for df7b29d - Browse repository at this point
Copy the full SHA df7b29dView commit details
Commits on Nov 30, 2022
-
Added dependabot for GitHub Actions
How about using dependabot in this way? When this works, a PullRequest is created as follows: - ruby/bigdecimal#242 It was created with reference to the following: - ruby/csv#265
Configuration menu - View commit details
-
Copy full SHA for 63ca919 - Browse repository at this point
Copy the full SHA 63ca919View commit details -
Merge pull request #201 from ydah/dependabot
Added dependabot for GitHub Actions
Configuration menu - View commit details
-
Copy full SHA for 1bb18b7 - Browse repository at this point
Copy the full SHA 1bb18b7View commit details -
Bump actions/setup-python from 2 to 4
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 4. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v2...v4) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for c1c363f - Browse repository at this point
Copy the full SHA c1c363fView commit details
Commits on Dec 3, 2022
-
Merge pull request #202 from rubocop/dependabot/github_actions/action…
…s/setup-python-4 Bump actions/setup-python from 2 to 4
Configuration menu - View commit details
-
Copy full SHA for 0c34fed - Browse repository at this point
Copy the full SHA 0c34fedView commit details -
[Fix #200] Support
it
testing block for minitest/specFixes #200. This PR supports `it` testing block for minitest/spec. `Minitest/GlobalExpectations` is already supported, so `it` testing block can also be supported by RuboCop Minitest.
Configuration menu - View commit details
-
Copy full SHA for f913555 - Browse repository at this point
Copy the full SHA f913555View commit details
Commits on Dec 5, 2022
-
Merge pull request #203 from koic/support_it_block
[Fix #200] Support `it` testing block for minitest/spec
Configuration menu - View commit details
-
Copy full SHA for 2ae881b - Browse repository at this point
Copy the full SHA 2ae881bView commit details
Commits on Dec 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 169aa24 - Browse repository at this point
Copy the full SHA 169aa24View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca5ddbf - Browse repository at this point
Copy the full SHA ca5ddbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b97ae78 - Browse repository at this point
Copy the full SHA b97ae78View commit details
Commits on Dec 17, 2022
-
Raise severity of some cops to warning
The cops below belong to linting, not style preference, so make set the severity to warning. The following emulates warnings for deprecated APIs: - Minitest/GlobalExpectations (#60) The following suggests incorrect usage of APIs: - Minitest/AssertRaisesWithRegexpArgument: - Minitest/AssertWithExpectedArgument: - Minitest/SkipEnsure: - Minitest/UnreachableAssertion:
Configuration menu - View commit details
-
Copy full SHA for 1061906 - Browse repository at this point
Copy the full SHA 1061906View commit details
Commits on Dec 23, 2022
-
[Fix #206] Make
Minitest/AssertWithExpectedArgument
aware of messag……e variable Fixes #206. This PR makes `Minitest/AssertWithExpectedArgument` aware of message variable. The second argument to the `assert` method named `message` and `msg` is allowed. Because their names are inferred as message arguments.
Configuration menu - View commit details
-
Copy full SHA for a4f7cd4 - Browse repository at this point
Copy the full SHA a4f7cd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f60f45 - Browse repository at this point
Copy the full SHA 8f60f45View commit details -
Merge pull request #208 from koic/make_minitest_assert_with_expected_…
…argument_aware_of_message_variable [Fix #206] Make `Minitest/AssertWithExpectedArgument` aware of message variable
Configuration menu - View commit details
-
Copy full SHA for 36dcb4c - Browse repository at this point
Copy the full SHA 36dcb4cView commit details
Commits on Dec 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d9e0050 - Browse repository at this point
Copy the full SHA d9e0050View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba2ed64 - Browse repository at this point
Copy the full SHA ba2ed64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 319cb38 - Browse repository at this point
Copy the full SHA 319cb38View commit details
There are no files selected for viewing