Lro v3 #1
Draft
Lro v3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Packages impacted by this PR @azure/event-hubs ### Issues associated with this PR N/A ### Describe the problem that is addressed by this PR This PR does the following: - migrates Event Hubs client library to the new world of using TSHY for building the library and using vitest as the test runner - consolidates client building in a single module and uses fully qualified name spaces and token credentials to build clients instead of using connection strings - runs mock-hub once instead of in every test module - disables min/max testing and samples testing because they're not playing well with TSHY and vitest at the moment. I'll open an issue to track turning them back on once the testing pipelines have been upgraded. Live Tests are passing: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4000037&view=results ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8721 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall <[email protected]>
Azure#30570) ### Packages impacted by this PR @azure/identity ### Issues associated with this PR Resolves Azure#29592 ### Describe the problem that is addressed by this PR SNI authentication is a 1p certificate feature supported by ClientCertificateCredential. In order to implement SNI based auth one has to use ClientCertificateCredential directly instead of DefaultAzureCredential because there's no way to configure sendCertificateChain from DAC. For consistency with other languages, we're adding support for AZURE_CLIENT_SEND_CERTIFICATE_CHAIN as an env var here ### Provide a list of related PRs _(if any)_ Azure/azure-sdk-for-java#41031
### Packages impacted by this PR @azure/identity ### Issues associated with this PR - Resolves Azure#25740 - Resolves Azure#30383 - Resolves Azure#30560 ### Describe the problem that is addressed by this PR This PR adds various documentation updates ported over from other languages, improving verbiage around `authenticate` usage and the azure authority host. --------- Co-authored-by: Scott Addie <[email protected]> Co-authored-by: Christopher Scott <[email protected]>
Post release automated changes for azure-rest-ai-translation-document Co-authored-by: Jeremy Meng <[email protected]>
### Packages impacted by this PR N/A ### Issues associated with this PR N/A ### Describe the problem that is addressed by this PR This updates the Code Owners for JS SDK as few team members have left the team. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A ### Are there test cases added in this PR? _(If not, why?)_ N/A ### Provide a list of related PRs _(if any)_ N/A ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
…re#30583) In live test pipeline, our DefaultAzureCredential would succeed in getting a token from MSI but that token doesn't work with our test resources. This PR works around the issue by passing a fake Msi client id to DefaultAzureCredential constructor, thus cause token retrieval to fail, and DefaultAzureCredential can continue to try the next credential type in the chain.
Addresses issue Azure#4 in Azure#30555.
The verbose reporter writes out the status of each unit test after it gets executed. This is inline with our experience with mocha before and it helps us track progress better in real time.
…30590) as the sample has been removed.
- add dev dependency to `@eslint/js` and `typescript-eslint` - add a flat config eslint.config.mjs for dev-tool
…nt and MetricsClient (Azure#30589) ### Packages impacted by this PR @azure/monitor-query ### Issues associated with this PR NA ### Describe the problem that is addressed by this PR The audience values set for MetricsQueryClient is incorrect and has to be fixed. Also, new Audience values are introduced for LogsQueryClient and MetricsClient. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? No specific design considerations or big API changes. ### Are there test cases added in this PR? _(If not, why?)_ No. They are just changes to enum values. ### Provide a list of related PRs _(if any)_ NA ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ NA ### Checklists - [X] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary) @srnagar @xirzec Please review and approve the PR.
- update CHANGELOG
This is an automatic PR generated weekly with changes from running the command rush update --full
The browser tests are [failing](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4009481&view=logs&j=8f098e13-557e-5a76-9331-06424800e0fa&t=52fc44a1-b208-5374-c579-e601a962726b) because some test suites import test-utils that imports chai@^4.0.0 which conflicts with chai@^5.0.0 that vitest depends on. This PR consolidates the tests that depend on test-utils in one test suite and excludes it from the browser tests for now. Live tests run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4013779&view=results
…30137) 1. Support to generate MQTT JWT Token for Azure WebPubSub. Essentially we need to identify if clients want to establish a default WebPubSub connection or an MQTT connection, then we will generate the Client Connection URL for them accordingly. - Example Client URL for: - Default Connection: `wss://exampleHost.com/client/hubs/exampleHub` - MQTT Connection: `wss://exampleHost.com/clients/mqtt/hubs/exampleHub` 2. Upgrade API version to '2024-01-01' 3. Add tests to get MQTT Token --------- Co-authored-by: Chuong Nguyen <[email protected]>
### Packages impacted by this PR @azure/cosmos ### Issues associated with this PR ### Describe the problem that is addressed by this PR This PR adds support for MakeList and MakeSet aggregates. Changes are based on PR: https://github.com/Azure/azure-cosmos-dotnet-v3/pull/4490/files#diff-f5144c66029f18b314e4895030a98d36fbb2323877f035a7edbcd9415e8b89f3 ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes, but currently they are skipped as feature is not supported by the latest public emulator. ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]>
Azure#30503) ### Packages impacted by this PR @azure/cosmos ### Issues associated with this PR ### Describe the problem that is addressed by this PR - This PR removes the support of float 16 from vector embedding data type - This PR adds support to block `nonStreamingOrderBy` queries which do not have a TOP or LIMIT+OFFSET present in the query. This check can be disabled by using `allowUnboundedNonStreamingQueries` flag in options. - An additional check is placed for internal buffer size. If calculated buffer size is greater than the default buffer size, an error is thrown. This is done as a safeguard from excessive memory consumption. Max buffer size can be increased using `vectorSearchBufferSize` in the options. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
) ### Packages impacted by this PR @azure/cosmos ### Issues associated with this PR ### Describe the problem that is addressed by this PR This PR fixes the partition key format for bulk delete, patch, and read operations. Due to wrong partition key format, these operations were failing in bulk operations. It also manages the partition key format in batch operations for non-partitioned containers or containers without a predefined partition key. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ yes ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Aditishree . <[email protected]>
### Packages impacted by this PR @azure/cosmos ### Issues associated with this PR ### Describe the problem that is addressed by this PR This PR updates the example in documentation for connection policy and cosmos client. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Aditishree . <[email protected]>
### Packages impacted by this PR @azure/cosmos ### Issues associated with this PR ### Describe the problem that is addressed by this PR This PR generates v4 samples and removes v4 features from v3 sample folder. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Aditishree . <[email protected]>
…0597) and update code to adapt the changes.
Now that the product issue is fixed and released in identity, we no longer needs this workaround. This PR removes it.
…to v2 (Azure#30600) - upgrade for app-configuration - upgrade for ai-language-conversations - upgrade for container-registry - upgrade for event hubs checkpoint stores - upgrade for mock-hub
### Packages impacted by this PR @azure/identity ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? In order to improve the error experience for Managed Identity we want to do a few things: 1. Remove misleading error messages like authority_not_found for any 400 2. Display the error's cause / InnerException / etc. 3. Provide helpful debugging information in the exception message (1) and (2) are done here, (3) is still in flux as I need to think about what information will be helpful without being overwhelming. ### Are there test cases added in this PR? _(If not, why?)_ Printing out the error's cause is an implementation detail of the runtime and _not_ something that gets stringified Co-authored-by: Christopher Scott <[email protected]>
to be consistent with `eslint` version. Also removed the eslint plugin helper. It was added to help vscode-eslint extension to resolve plugin packages. With flat config it is no longer needed.
…dev (Azure#30902) because dev-tool is using @summary and @azsdk-weight when publishing samples.
…zure#30810) In our current setup, tshy won't build test and samples-dev folder even they are included in tsconfig.json. This PR adds a command that does the type-checking for all files included in tsconfig.json, and allow additional files to be passed in as well.
Successful run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4083622&view=results This PR introduces a new Azure DevOps pipeline that automatically lints all Bicep files in the repository and generates a report of any linting warnings. These reports are stored as artifacts and uploaded to Azure Blob Storage for tracking over time. ### Benefits - Automated Linting: Ensures that all Bicep files are consistently checked for best practices and potential issues. - Historical Tracking: By appending the date to the lint warnings file, we can monitor progress and improvements over time. ### Next Steps - Monitor the lint warnings reports over time to identify and address recurring issues. - Use the stored reports to guide refactoring efforts and improve Bicep code quality across the repository. ### Current warnings: ``` WARNING: /home/codespace/window3/sdk/textanalytics/test-resources.bicep(32,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/textanalytics/test-resources.bicep(33,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/formrecognizer/test-resources.bicep(60,41) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/formrecognizer/test-resources.bicep(61,157) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/formrecognizer/test-resources.bicep(62,155) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/formrecognizer/test-resources.bicep(63,184) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/translation/test-resources.bicep(67,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/storage/test-resources.bicep(294,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(295,33) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(296,115) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(299,33) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(300,37) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(301,127) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(304,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(305,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(308,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(309,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(310,124) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(313,41) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(314,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(315,131) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(318,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(319,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/storage/test-resources.bicep(320,139) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/mixedreality/test-resources.bicep(25,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(28,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(29,66) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(31,50) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(52,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(53,66) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(55,55) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/template/test-resources.bicep(29,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/remoterendering/test-resources.bicep(111,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/remoterendering/test-resources.bicep(112,57) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/remoterendering/test-resources.bicep(117,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/tables/test-resources.bicep(62,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/tables/test-resources.bicep(63,31) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/tables/test-resources.bicep(64,133) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/tables/test-resources.bicep(65,115) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/eventgrid/test-resources.bicep(139,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/cognitivelanguage/test-resources.bicep(153,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/cognitivelanguage/test-resources.bicep(154,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(5,9) : Warning BCP334: The provided value can have a length as small as 3 and may be too short to assign to a target with a configured minimum length of 6. /home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(13,12) : Warning BCP035: The specified "resource" declaration is missing the following required properties: "location". If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues] /home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(23,44) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(11,39) : Warning no-hardcoded-env-urls: Environment URLs should not be hardcoded. Use the environment() function to ensure compatibility across clouds. Found this disallowed host: "core.windows.net" [https://aka.ms/bicep/linter/no-hardcoded-env-urls] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(16,5) : Warning decompiler-cleanup: The name of variable 'eventHubsNamespace_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(19,5) : Warning decompiler-cleanup: The name of variable 'storageAccount_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(22,5) : Warning no-unused-vars: Variable "eventHubsAuthRuleResourceId" is declared but never used. [https://aka.ms/bicep/linter/no-unused-vars] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(26,9) : Warning BCP334: The provided value can have a length as small as 3 and may be too short to assign to a target with a configured minimum length of 6. /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(36,9) : Warning use-parent-property: Resource "eventHubsNamespace_eventHubName" has its name formatted as a child of resource "eventHubsNamespace". The syntax can be simplified by using the parent property. [https://aka.ms/bicep/linter/use-parent-property] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(37,3) : Warning BCP187: The property "location" does not exist in the resource or type definition, although it might still be valid. If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(48,9) : Warning use-parent-property: Resource "eventHubsNamespace_eventHubName_eventHubAuthRuleName" has its name formatted as a child of resource "eventHubsNamespace_eventHubName". The syntax can be simplified by using the parent property. [https://aka.ms/bicep/linter/use-parent-property] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(66,5) : Warning BCP073: The property "tier" is read-only. Expressions cannot be assigned to read-only properties. If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(81,71) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2019-04-01-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed. /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(90,64) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2019-04-01-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed. /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(101,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(104,35) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(105,129) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(105,156) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to Azure/bicep#2017 if you believe this will impact your workflow. /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(107,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(107,69) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to Azure/bicep#2017 if you believe this will impact your workflow. WARNING: /home/codespace/window3/sdk/servicebus/test-resources.bicep(123,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/servicebus/test-resources.bicep(124,54) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/servicebus/test-resources.bicep(131,36) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/servicebus/service-bus/perf-resources.bicep(9,5) : Warning decompiler-cleanup: The name of variable 'authorizationRuleName_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup] /home/codespace/window3/sdk/servicebus/service-bus/perf-resources.bicep(38,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/servicebus/service-bus/test/stress/stress-test-resources.bicep(9,5) : Warning decompiler-cleanup: The name of variable 'authorizationRuleName_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup] /home/codespace/window3/sdk/servicebus/service-bus/test/stress/stress-test-resources.bicep(38,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/web-pubsub/test-resources.bicep(57,39) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/web-pubsub/test-resources.bicep(58,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/web-pubsub/test-resources.bicep(59,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/web-pubsub/test-resources.bicep(60,56) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/search/test-resources.bicep(19,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAdminKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/search/test-resources.bicep(20,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAdminKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/maps/test-resources.bicep(43,39) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(64,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(65,168) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(66,161) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(67,187) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(68,189) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(69,179) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(70,186) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets] WARNING: /home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(21,7) : Warning no-unused-params: Parameter "deploymentTime" is declared but never used. [https://aka.ms/bicep/linter/no-unused-params] /home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(32,9) : Warning BCP334: The provided value can have a length as small as 0 and may be too short to assign to a target with a configured minimum length of 3. /home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(168,26) : Warning BCP081: Resource type "microsoft.healthdataaiservices/deidservices@2024-02-28-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed. ``` --------- Co-authored-by: Wes Haggard <[email protected]>
### Packages impacted by this PR @azure/keyvault-certificates ### Issues associated with this PR Azure#30822 ### Describe the problem that is addressed by this PR When migrating keyvault-certificates to ESM and vitest I forgot to port over the extended timeout needed for these tests (see [this diff](Azure@58ac994#diff-238f0a9c86d168f8a93aba09420e13a2cdc1bb6d157e76949a197eacd26774a3L54)) and noticed that the live tests started failing with a timeout. This commit adds the timeout back in a command line argument. It also addresses an issue in our dependency-testing script where min/max tests were no longer carrying over the timeout from the package json's path in tests that have migrated to vitest.
- [eslint-plugin] github-source-headers rule should use "MIT License". This change updates our linter rule and the whole repository to have consistent license header. ***NO_CI*** - remove "All rights reserved." from header - "MIT license" => "MIT License"
Use AzureCLI@2 task to generate a SAS for cache write credential so we don't need to store secrets anymore.
add sdk/batch/batch-rest/test/utils/fakeTestSecrets.ts to credscan suppression list.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8875 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Siddharth Singha Roy <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
### Packages impacted by this PR - @azure/cosmos ### Issues associated with this PR - Azure#30914 ### Describe the problem that is addressed by this PR Adds better checks for `process` which is not global in environments such as Deno/Bun/React-Native and other places. Assumes the environment variable is false in the browser case. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ - Azure#30295 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]> Co-authored-by: Manik Khandelwal <[email protected]>
…x ESM/Webpack (Azure#30922) ### Packages impacted by this PR @azure/monitor-opentelemetry ### Issues associated with this PR Azure#30900 ### Describe the problem that is addressed by this PR Removes the usage of a relative path such that changing the module location will not break imports. ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
…ct slugs (Azure#30937) ### Packages impacted by this PR @azure/create-microsoft-playwright-testing @azure/microsoft-playwright-testing ### Issues associated with this PR 1. Missing sample build script 2. Invalid product slugs ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
…nit logs (Azure#30912) ### Packages impacted by this PR @azure/create-microsoft-playwright-testing ### Issues associated with this PR None ### Describe the problem that is addressed by this PR 1. Refactor reporter comments in service config file 2. Add list reporter by default 3. Init logs printed to console refactoring ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? None ### Are there test cases added in this PR? _(If not, why?)_ None, existing modified ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
…ure#30881) ### Packages impacted by this PR @azure/microsoft-playwright-testing ### Issues associated with this PR Minimum playwright version required is 1.47. ### Describe the problem that is addressed by this PR This PR enforces the >=1.47 playwright version check. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary)
…#30924) There's some change in `typescript-eslint` that breaks some eslint test cases. Previously when running tests, in a rule's `create()` method, we get a relative path for `context.filename`, and when we pass a setting of `{ main: "src/test.ts" }` in rule tester option, the two were considered the same file, therefore the following condition check failed, and we continue to report error for default exports. https://github.com/Azure/azure-sdk-for-js/blob/6dd8b582e2f5a3257befab368bab0e64499f4d57/common/tools/eslint-plugin-azure-sdk/src/rules/ts-modules-only-named.ts#L31 After the upgrade, `context.filename` now contains the full path, the file `src/test.ts` in our test fixture has a full path of `/.../common/tools/eslint-plugin-azure-sdk/tests/fixture/src/test.ts`. It is not considered the same file as the passed settings implies `/.../common/tools/eslint-plugin-azure-sdk/src/test.ts` when we run the tests. So we return earlier instead of going to check for default exports. This is not an issue in real scenario where we have settings of `{ main: "src/index.ts" }`, which would match the full path of the file we are linting when we run `eslint` from a package directory. This PR fixes the test by passing `tests/fixture/src/test.ts` in the settings so that it matches the full path of `context.filename` we get in `create()`.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8878 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Scott Beddall <[email protected]>
Post release automated changes for azure-arm-datafactory
github-actions
bot
added
EngSys
dev-tool
eslint plugin
Mgmt
Farmbeats
App Configuration
Attestation
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists