Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prod - Requested changes to the TTA Overview widgets - add non-grantees, tta hours, fix region order #486

Merged
merged 44 commits into from
Jun 28, 2021

Conversation

kryswisnaskas
Copy link
Collaborator

@kryswisnaskas kryswisnaskas commented Jun 25, 2021

Description of change

Follow-up PR to the TTA overview widget. Fixes region order in the region select dropdown. Adds non-grantees to the widget and combines duration into one item. Additionally, it includes the legacy reports in statistics and limits the reports to approved ones. This PR also creates a script that allows to extract the non-grantee data from the legacy imported field.

How to test

  • go to staging
    https://tta-smarthub-staging.app.cloud.gov/activity-reports
  • assign yourself permissions to a lower number region (you might have to remove one first if having permissions to all)
  • verify that the available regions in the region selectors are displayed in an ascending order
  • add an activity report for a non-grantee
  • verify that the widget was updated

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

dcloud and others added 30 commits June 8, 2021 11:13
…m-Operations

Add links to TTAHUB System Operations wiki page.
* Debug logger

* Move the run time from midnight to 4am
Update the grant and grantee job
* First pass at a pattern for widgets

* Set coverage limits to 0 so we deploy to staging

These limits will be increased back to what they are on main before
merging.

* Reset coverage limits

* TTA Overview widget initial commit

* Add backend tests

* Deploy to sandbox

* Fix lint error

* Fix frontend lint errors

* Merge main and fix invalid region

* Refactor test

* Add frontend tests

* Add frontend tests

* Styling improvements

* Add region number in caption

* Update mocks in landing tests

* Adjusted sizing, flickering

* Add temp border to overview widget

Co-authored-by: Josh Salisbury <[email protected]>
…Landing

Ttahub 138 al tp survey on ar landing
AdamAdHocTeam and others added 14 commits June 22, 2021 14:01
* Add non-grantees; layout changes

* Deploy to sandbox

* Include legacy reports in statistics; limit to approved reports only

* Increase frontend test timeout

* Add a script to connect non-grantees to activity reports for legacy data

* Add a script to connect non-grantees to activity reports for legacy data

* Add a script to connect non-grantees to activity reports for legacy data

* Fix lint errors

* Fix test

* Remove non-legacy filter

* Remove statement

* Adjust test

* Remove new test
Debug intermittent rendering issue
Requested changes to the TTA Overview widgets - add non-grantees, combine tta hours, fix region order
Copy link
Contributor

@OHS-christine-nguyen OHS-christine-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

@OHS-christine-nguyen OHS-christine-nguyen merged commit 0525290 into production Jun 28, 2021
thewatermethod added a commit that referenced this pull request Nov 15, 2021
* Bump validator from 13.6.0 to 13.7.0

Bumps [validator](https://github.com/validatorjs/validator.js) from 13.6.0 to 13.7.0.
- [Release notes](https://github.com/validatorjs/validator.js/releases)
- [Changelog](https://github.com/validatorjs/validator.js/blob/master/CHANGELOG.md)
- [Commits](validatorjs/validator.js@13.6.0...13.7.0)

---
updated-dependencies:
- dependency-name: validator
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* welcoming robots in certain situations

* Update known vulnerabilities

* trying a different approach in the config

* is this how we set vars?

* fix var name

* test on dev since sandbox does not do what I thought

* update trusworks with modal changes

* need to learn how to do bash

* more bash better

* for christmas sake

* testing complete

* fix bash script var names

* updated file uploader modal

* updated external resource modal

* move logic to circlci config

* awaken robot on prod

* Update .circleci/config.yml

Co-authored-by: Josh Salisbury <[email protected]>

* add approvedat migration

* update approvedAt on approval

* clean up constants, add new one

* add approved and created dates to fe landing page

* add approved and created date to csv download

* remove console statement

* fixing tests

* fixed modal unit tests

* updated my alert test

* fixed modal tests for external resource

* partial fixes for ui tests

* clean up prop type

* cleanup UI tests

* more unit test fixes for trussworks2

* idle modal test fixes

* add backend tests

* fixed accessibility issue and added test coverage

* add target populations to ar

* add approved and created date to ar, table css fixes

* fix failing ui test

* fix failing tooltip test

* unique id value

* update known issues

* fix axe

* Update known vulnerabilities

* fix axe again

* fix axe issues again

* try heading axe fix

* update test for axe

* update

* see if remvoing display none fixes issue

* hide headings

* limit number of headings

* added cusom accordion with heading size prop

* added test for accordion

* fix capitalizations while we're here

* fixes based on Kryss comments

* fix css bug w/checkboxes

* linter fixes

* audit vuln

* update ignored FE vulns

* writing FE tests

* change unlock report button css to outline

* working on more tests

* provide some missing UI tests

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: unknown <[email protected]>
Co-authored-by: Adam Levin <[email protected]>
Co-authored-by: Josh Salisbury <[email protected]>
Co-authored-by: Adam Levin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants