-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHBC-2106: Migrate Dev to Test #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed false positive on template validation
…es (#882) * BHBC-2078: Amend summary species template validation * BHBC-2078: Make new migration file * BHBC-2078: use on conflict instead of insert ignore Co-authored-by: AlfredRosenthal <[email protected]>
General UI/ API improvements to allow for the securing of documents and reports in SIMS Related Tickets: BHBC-1097 BHBC-2055 BHBC-2045 BHBC-2020 BHBC-2047 BHBC-1276
Taxonomic elastic search now filters out expired results
BHBC-2040: Added template validation rule to validate if column(s) are unique
* BHBC-2041: Adds a new validation rule that can check if one or more columns are unique (not duplicates) in order to validate keys. * Added a new submission message error type (with corresponding migration). * Added validation rules that run on workbooks. * Changed the Darwin Core Archive and Summary services to also run workbook validations.
…bmitting Occurrences (#888)
* - remove artifact security components - removing temaplate configuration from database migration - removing unused directories - further directory cleanup * - first pass at removing artifact security concepts * - remove extrenuous file * - minor sql adjustments * - removal of security concept from app * - removed security rule concept * - lint and format fix * - removed dashboard component * Fix last_modified date. Co-authored-by: Nick Phura <[email protected]>
BHBC-1952: Moose Template Validation. Added script to generate validation schemas based on configured object
BHBC-2095 Part 3: More queries moved into repositories and more tests fixed
…dow Table in SIMS and Elasticsearch Index
* survey repo test coverage * increase coverage
curtisupshall
previously approved these changes
Jan 4, 2023
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## test #904 +/- ##
==========================================
- Coverage 73.05% 66.48% -6.57%
==========================================
Files 353 339 -14
Lines 12905 10877 -2028
Branches 2317 1908 -409
==========================================
- Hits 9428 7232 -2196
- Misses 2994 3243 +249
+ Partials 483 402 -81
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
NickPhura
approved these changes
Jan 5, 2023
curtisupshall
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Links to Jira tickets
Description of relevant changes
PR Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
Code
Style
Documentation
Tests
Linting/Formatting
See the
lint
commands in package.jsonSee the
format
commands in package.jsonSonarCloud