Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2106: Migrate Dev to Test #904

Merged
merged 18 commits into from
Jan 5, 2023
Merged

BHBC-2106: Migrate Dev to Test #904

merged 18 commits into from
Jan 5, 2023

Conversation

KjartanE
Copy link
Contributor

@KjartanE KjartanE commented Jan 4, 2023

Overview

Links to Jira tickets

  • {List all applicable Jira tickets}

Description of relevant changes

  • {List all relevant changes, in particular anything that will help the reviewers test/verify this PR}

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

AlfredRosenthal and others added 17 commits December 2, 2022 11:31
Fixed false positive on template validation
…es (#882)

* BHBC-2078: Amend summary species template validation

* BHBC-2078: Make new migration file

* BHBC-2078: use on conflict instead of insert ignore

Co-authored-by: AlfredRosenthal <[email protected]>
General UI/ API improvements to allow for the securing of documents and reports in SIMS

Related Tickets:
BHBC-1097
BHBC-2055
BHBC-2045
BHBC-2020
BHBC-2047
BHBC-1276
Taxonomic elastic search now filters out expired results
BHBC-2040: Added template validation rule to validate if column(s) are unique
* BHBC-2041: Adds a new validation rule that can check if one or more columns are unique (not duplicates) in order to validate keys.
* Added a new submission message error type (with corresponding migration).
* Added validation rules that run on workbooks.
* Changed the Darwin Core Archive and Summary services to also run workbook validations.
* - remove artifact security components
- removing temaplate configuration from database migration
- removing unused directories
- further directory cleanup

* - first pass at removing artifact security concepts

* - remove extrenuous file

* - minor sql adjustments

* - removal of security concept from app

* - removed security rule concept

* - lint and format fix

* - removed dashboard component

* Fix last_modified date.

Co-authored-by: Nick Phura <[email protected]>
BHBC-1952: Moose Template Validation. Added script to generate validation schemas based on configured object
BHBC-2095 Part 3: More queries moved into repositories and more tests fixed
* survey repo test coverage

* increase coverage
curtisupshall
curtisupshall previously approved these changes Jan 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.4% 5.4% Duplication

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #904 (4a8f3eb) into test (b99f8cb) will decrease coverage by 6.56%.
The diff coverage is 88.17%.

@@            Coverage Diff             @@
##             test     #904      +/-   ##
==========================================
- Coverage   73.05%   66.48%   -6.57%     
==========================================
  Files         353      339      -14     
  Lines       12905    10877    -2028     
  Branches     2317     1908     -409     
==========================================
- Hits         9428     7232    -2196     
- Misses       2994     3243     +249     
+ Partials      483      402      -81     
Impacted Files Coverage Δ
api/src/app.ts 0.00% <0.00%> (ø)
api/src/constants/codes.ts 100.00% <ø> (ø)
api/src/constants/notifications.ts 100.00% <ø> (ø)
api/src/json-schema/validation-schema.ts 100.00% <ø> (ø)
api/src/models/occurrence-create.ts 100.00% <ø> (ø)
api/src/models/summaryresults-create.ts 0.00% <0.00%> (-21.06%) ⬇️
api/src/models/user.ts 63.63% <ø> (-9.70%) ⬇️
api/src/openapi/schemas/administrative-activity.ts 100.00% <ø> (ø)
api/src/openapi/schemas/draft.ts 100.00% <ø> (ø)
api/src/openapi/schemas/project.ts 100.00% <ø> (ø)
... and 368 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KjartanE KjartanE merged commit bc9c447 into test Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants