Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into features/recursive-patterns #32110

Merged
merged 28 commits into from
Jan 3, 2019

Conversation

gafter
Copy link
Member

@gafter gafter commented Jan 3, 2019

No description provided.

CyrusNajmabadi and others added 27 commits December 13, 2018 11:20
Since dotnet#30868, `ContentTypeNames`
has moved to this assembly. Type forwarding doesn't seem to work for
IVT.
Azure Pipelines now supports us putting the branches which trigger PR
and CI validation into the YAML files. This change puts the current
contents of our build definition into the YAML files and updates our
creating feature branches document.

Note: i have not yet changed our build definition to read this
information. Want to commit this, give it a day to flow to the branches
then I will flip our definition over.
It was out of date in a few places as projects have been moved/renamed/created.
Move CI / PR triggers to YAML files
Cache the return values for GetIdForErrorCode
Random code comment typo fixes
Fixed adding attribute list with target specifier
…ember

 Rename an enum member to be clearer, and add docs as well.
EditorFeatures.Text IVTs for MonoDevelop
Consistently parse .editorconfig option values containing spaces
…otnet#31782)

* Fix additional newlines being added when adding all missing imports

* Use syntax formatter to remove extra newlines when adding missing imports

* Apply suggestions from code review

* Added assert to ensure we retain the final newline

* Updated the assert to include cases where a newline pre-existed
…#32005)

For each reference that doesn't have an .XML doc file we allocate and cache a FileBasedXmlDocumentationProvider that throws a first-chance exception upon first use.

Add and use a singleton NullXmlDocumentationProvider instead when the requested .XML doc file doesn't exist.
@gafter gafter requested review from a team as code owners January 3, 2019 00:05
@gafter gafter self-assigned this Jan 3, 2019
@gafter gafter added this to the 16.0.P2 milestone Jan 3, 2019
@gafter
Copy link
Member Author

gafter commented Jan 3, 2019

@jaredpar Would you like to do the honors of merging this?

@gafter gafter merged commit c4c4429 into dotnet:features/recursive-patterns Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.