Merge Features/interpolated string constants to master #49676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…polated-string-constants Merge master to features/interpolated-string-constants
* Working Constant Interpolated Strings ($"simple") This is going to break so many things... * Ensure nullable * Testing * Testing Break * Hidden Constants * Please? * Added Null Check * Matching Format Specifications, added boolean specifier * Added Skips and Changes * Update SemanticModelAPITests.vb * Update RecordParsing.cs * Escaped Constants * Updated Tests * Small changes * Uncommented Tests * Requested PR changes * Add Tests for Invalid
…polated-string-constants Merge master to features/interpolated-string-constants
#45685) * Working Constant Interpolated Strings ($"simple") This is going to break so many things... * Update ConstantTests.cs * Adds Further Testing * Working Top Level Versioning Errors * Working Recursive Feature Checking * Updated Error Checking for more specificity * Requested PR Updates * Updated to meet PR changes * Added to Versioning Tests as well. * Expanded Version Testing Breadth * Requested PR Changes * Ensure not null * Requested PR Changes * Rename to CheckLangVersionForConstantValue * Typo in Test * Update Compilers.sln
…ter-to-features/interpolated-string-constants
…polated-string-constants Merge master to features/interpolated-string-constants
…ter-to-features/interpolated-string-constants
…polated-string-constants Merge master to features/interpolated-string-constants
…stants' into merges/master-to-features/interpolated-string-constants
…polated-string-constants Merge master to features/interpolated-string-constants
* Update IntroduceVariableTests.cs * Update ConstantTests.cs * Update SemanticModelAPITests.cs * PR changes * PR changes * Update IntroduceVariableTests.cs * Update SemanticModelAPITests.cs
…features/interpolated-string-constants * upstream/master: (1950 commits) Delete extra "Return True" (#48089) Remove unused param Extract local Update help service to account for all `TypeDeclarationSyntax` (namespace+record+struct) as partial type (#48095) Don't offer to remove as cast from using statements or declarations (#48110) Cleaner solution Update tests Don't offer to remove necessary native integer casts Fix xml attribute name classification Use switch expressions. Add test for IAsyncEnumerable<string> Fix tests Add tests Update CSharpTypeInferenceService.TypeInferrer.cs Fix failure to dispose RemoteWorkspace in tests [master] Update dependencies from dotnet/roslyn (#48072) Simplify common calls to Parallel.For with a RoslynParallel.For helper Fallback to IEnumerable<> if IAsyncEnumerable<> not found Fix cancellation handling in Parallel.For Update InferTypeInForEachStatement to respect await foreach ...
…polated-string-constants Merge master to features/interpolated-string-constants
…features/interpolated-string-constants * upstream/master: (222 commits) Update dependencies from https://github.com/dotnet/roslyn build 20201004.1 (#48325) Fix code generation for records with semi-colon (#48313) More native integer tests (#48266) Add contract calls to help track down issue. Move code Fix bugs Update Nerdbank.Streams to 2.6.81 Reverts IServiceBroker changes (#48221) PR feedback Update Clashing Enum Members.md (#46816) Additional tests converting between native integers and 64-bit integers (#48229) Support checked and unchecked statements in formatting Add formatting tests with checked and unchecked Update src/EditorFeatures/CSharpTest/ConvertAutoPropertyToFullProperty/ConvertAutoPropertyToFullPropertyTests.cs Move and rename test. Add test Support feature when span is selected Update SG cookbook (#48182) Fix method consolidation Update buffer on UI thread ...
…features/interpolated-string-constants * upstream/master: (295 commits) Update F1 Keywords to differentiate between semantics of default keyword (#48500) Default constructor suggestion between members (#48318) (#48503) Adjust ERR_PartialMisplaced diagnostic message (#48524) Refactor ChangedText.Merge and add fuzz testing (#48420) Apply suggestions from code review Do not crash on unexpected exception (#48367) Reference the contributing doc in 'Analyzer Suggestion' issue template Apply suggestions from code review Hardcode skipped Regex diagnostic ID as it is not available in CodeStyle layer Add using Skip help link for Regex diagnostic analyzer Add contributing doc for IDE code style analyzer documentation Make db lock static to investigate issue. Update dependencies from https://github.com/dotnet/roslyn build 20201012.2 (#48513) Hook up help link even for AbstractCodeQualityDiagnosticAnalyzer Add destructor intellisense test for record (#48297) Remove unused method (#48429) Fix bug Update src/EditorFeatures/Core.Wpf/InlineHints/InlineHintsTag.cs Add more test ...
…polated-string-constants Merge master to features/interpolated-string-constants
…polated-string-constants Merge master to features/interpolated-string-constants
…polated-string-constants Merge master to features/interpolated-string-constants
…polated-string-constants Merge master to features/interpolated-string-constants
…polated-string-constants Merge master to features/interpolated-string-constants
* upstream/master: (265 commits) Use extra generic type parameters and apply C#-specific knowledge to all langs instead of using inheritance Cover all changed code paths Stop removing parens that are required by C# Fix unnecessary spans Failing test for preserving parens around conditional expression AddSynthesizedRecordMembersIfNecessary - avoid touching members that are known to have no effect on the outcome of the function. (#49610) Resolve follow-up comments in PR "Create default arguments during binding" (#49588) Remove restore and checkout from test jobs (#49452) 3.8.* -> 3.9.* Update PublishData.json Update Versions.props Remove Microsoft.CodeAnalysis.VisualBasic.dll from the VSPE.OptProfTests.DDRIT_RPS_ManagedLangs_Typing runs Fix the ability to expand the list of analyzers in a reference Fix comment Address feedback to ensure `/warnaserror-:ID` prevents config options from bumping a warning to an error. parallel restore on mac/linux (#49523) VSMac: Make QuickFix preview resizable and add title (#49394) Add CallerMemberNameAttributeWithImplicitObjectCreation test (#49556) Update dependencies from https://github.com/dotnet/arcade build 20201120.10 (#49541) Clarify comment ...
Merge master into features/interpolated-string-constants
jaredpar
approved these changes
Dec 1, 2020
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All commits have been individually reviewed. @jaredpar for approval. /cc @kevinsun-dev