Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor is processing gamepad input #813

Closed
adolson opened this issue Oct 23, 2014 · 4 comments
Closed

editor is processing gamepad input #813

adolson opened this issue Oct 23, 2014 · 4 comments

Comments

@adolson
Copy link
Contributor

adolson commented Oct 23, 2014

I found out that the Godot editor is processing gamepad input. Pushing some buttons on a gamepad may result in the focus moving around, and if you're not careful, changes made to your scene (including deletion of nodes, even the root node).

It seems to process joystick input even behind the scenes of a running project which is also processing joystick input. I'm using Linux.

@argylelabcoat
Copy link
Contributor

Have you made sure that the joystick isn't getting mapped in xinput to a mouse or keyboard?

I'd try running xinput list to check

@adolson
Copy link
Contributor Author

adolson commented Oct 23, 2014

I had to install xinput.. I run that, and the output is the same with a gamepad unplugged or plugged in.

@adolson
Copy link
Contributor Author

adolson commented Oct 30, 2014

@reduz: I am wondering if this bug's cause has to do with the default InputAction mappings? If so, I think all the joystick stuff should be removed from there, at least for Godot build itself, if not for everything.

As end-users, we can always add them back in on a per-project basis, if that's the solution we choose for mapping gamepad input (I really don't recommend it, considering the wide difference in gamepad button and stick ids from model to model, and currently no built-in SDL2-like way of automatic standardized remapping).

Either way, it's a dangerous potential for lost work as it currently stands.

@reduz
Copy link
Member

reduz commented Dec 6, 2014

ok, fixed, for now joystick is disabled in editor

reduz added a commit that referenced this issue Dec 7, 2014
-=-=-=-=-=-=-=-=-

-Fixed Export UV XForm (should work now). #923
-Fixed enforcement of limits in property editor. #919
-Fixed long-standing bug of export editings in script inheritance. #914, #859, #756
-Fixed horrible error reporting in shader language. #912
-Added kinematic collision with plane (please test well). #911
-Fixed double animation track insert when using 2D rigs. #904
-VKey updates offset parameter in sprite edition. #901
-Do not allow anymore a script to preload itself. (does not fix #899, but narrows it down)
-Avoid connection editor from overriding selected text. #897
-Fixed timer autostart. #876
-Fixed collision layers in 3D physics. #872
-Improved operators in shader #857
-Fixed ambient lighting bug #834
-Avoid editor from processing gamepad input #813
-Added not keyword #752

Please test!
@adolson adolson closed this as completed Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants