feat(external-database): add ability to pass readonly user to the external database #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration script Signed-off-by: instamenta <[email protected]>
…tabase-add-ability-to-pass-readonly-user-to-the-external-database
Signed-off-by: instamenta <[email protected]>
jeromy-cannon
approved these changes
Feb 11, 2025
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1350 +/- ##
==========================================
- Coverage 82.56% 82.46% -0.10%
==========================================
Files 128 128
Lines 23347 23416 +69
Branches 1539 1586 +47
==========================================
+ Hits 19276 19311 +35
- Misses 3994 4039 +45
+ Partials 77 66 -11
... and 24 files with indirect coverage changes |
instamenta
deleted the
01349-featexternal-database-add-ability-to-pass-readonly-user-to-the-external-database
branch
swirlds-automation
added a commit
that referenced
this pull request
Feb 20, 2025
## [0.35.0](v0.34.0...v0.35.0) (2025-02-20) ### Features * Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc)) * add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4)) * add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b)) * add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae)) * add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0)) * add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3)) * add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3)) * add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956)) * add factory and injection logic ([#1352](#1352)) ([c794610](c794610)) * add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47)) * add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6)) * add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998)) * add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967)) * add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1)) * add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f)) * **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486)) * **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5)) * create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c)) * **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac)) * **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095)) * **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5)) * **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c)) * **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39)) * **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43)) * **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e)) * **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab)) * Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90)) * update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592)) ### Bug Fixes * ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f)) * ensure staking updates support multi-cluster deployments ([#1432](#1432)) ([ef5435e](ef5435e)) * fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2)) * fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806)) * increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167)) * mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e)) * **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f)) * **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b)) * Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937)) * test script of google storage ([#1397](#1397)) ([370f57b](370f57b)) * update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276)) * update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f)) * use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))
|
🎉 This PR is included in version 0.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the ability to provide a readonly user name and password for the external database.
New flags:
--external-database-read-username- PostgreSQL readonly user's username.--external-database-read-password- PostgreSQL readonly user's password.the owner is set as the owner inside the mirror-node helm chart and the mirror node importer,
all of the other services use the readonly user - gRPC, restJava, web3, rest...
Related Issues