feat: add support for multi-cluster testing via KinD #1392

nathanklick · 2025-02-14T02:41:41Z

Description

This pull request changes the following:

Adds the necessary tooling and scripts to support local multi-cluster testing
- Does not enable multi-cluster tests in the CI pipelines
Must use load balancers support in Solo with this dual cluster configuration
Updates CI pipelines to use the new setup-dual-e2e.sh script with a SOLO_CLUSTER_DUALITY=1 to mimic current behavior

Related Issues

Partially Resolves Add support for multiple cluster testing via KinD #1391

Signed-off-by: Nathan Klick <[email protected]>

github-actions · 2025-02-14T02:46:34Z

Unit Test Results - Windows

1 files ±0 61 suites ±0 3s ⏱️ ±0s
237 tests ±0 237 ✅ ±0 0 💤 ±0 0 ❌ ±0
246 runs ±0 246 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit d99148a. ± Comparison against base commit fa1787e.

♻️ This comment has been updated with latest results.

github-actions · 2025-02-14T02:47:10Z

Unit Test Results - Linux

1 files ±0 61 suites ±0 2s ⏱️ ±0s
237 tests ±0 237 ✅ ±0 0 💤 ±0 0 ❌ ±0
246 runs ±0 246 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit d99148a. ± Comparison against base commit fa1787e.

♻️ This comment has been updated with latest results.

Signed-off-by: Nathan Klick <[email protected]>

github-actions · 2025-02-14T05:54:01Z

E2E Test Report

17 files 126 suites 1h 34m 55s ⏱️
254 tests 254 ✅ 0 💤 0 ❌
265 runs 265 ✅ 0 💤 0 ❌

Results for commit d99148a.

♻️ This comment has been updated with latest results.

codacy-production · 2025-02-14T05:54:17Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.04% (target: -1.00%)	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`fa1787e`)	23932	20061	83.83%
Head commit (`d99148a`)	23932 (+0)	20051 (-10)	83.78% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1392)	1	1	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-02-14T05:55:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (fa1787e) to head (d99148a).
Report is 47 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
- Coverage   82.73%   82.70%   -0.04%     
==========================================
  Files         130      130              
  Lines       23932    23932              
  Branches     1600     2189     +589     
==========================================
- Hits        19801    19792       -9     
+ Misses       4052     3963      -89     
- Partials       79      177      +98

Files with missing lines	Coverage Δ
version.ts	`100.00% <100.00%> (ø)`

... and 38 files with indirect coverage changes

## [0.35.0](v0.34.0...v0.35.0) (2025-02-20) ### Features * Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc)) * add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4)) * add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b)) * add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae)) * add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0)) * add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3)) * add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3)) * add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956)) * add factory and injection logic ([#1352](#1352)) ([c794610](c794610)) * add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47)) * add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6)) * add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998)) * add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967)) * add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1)) * add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f)) * **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486)) * **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5)) * create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c)) * **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac)) * **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095)) * **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5)) * **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c)) * **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39)) * **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43)) * **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e)) * **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab)) * Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90)) * update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592)) ### Bug Fixes * ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f)) * ensure staking updates support multi-cluster deployments ([#1432](#1432)) ([ef5435e](ef5435e)) * fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2)) * fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806)) * increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167)) * mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e)) * **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f)) * **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b)) * Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937)) * test script of google storage ([#1397](#1397)) ([370f57b](370f57b)) * update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276)) * update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f)) * use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))

swirlds-automation · 2025-02-20T01:51:36Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-02-24T01:50:40Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: add support for multi-cluster testing via KinD

36e3a08

Signed-off-by: Nathan Klick <[email protected]>

nathanklick requested review from a team and leninmehedy as code owners February 14, 2025 02:41

nathanklick requested review from andrewb1269hg, Ivo-Yankov, jeromy-cannon and instamenta February 14, 2025 02:41

jeromy-cannon previously approved these changes Feb 14, 2025

View reviewed changes

chore: integrate dual kind clusters with CI

81bebac

Signed-off-by: Nathan Klick <[email protected]>

nathanklick dismissed jeromy-cannon’s stale review via 81bebac February 14, 2025 03:22

nathanklick added 7 commits February 13, 2025 21:28

chore: fix failure due to cgexec

2297306

Signed-off-by: Nathan Klick <[email protected]>

chore: add helm step

18d9f6f

Signed-off-by: Nathan Klick <[email protected]>

chore: fix dns name

296d24f

Signed-off-by: Nathan Klick <[email protected]>

chore: ensure metallb starts

89889c7

Signed-off-by: Nathan Klick <[email protected]>

chore: add final duality support and revert CN version to v0.58.5

59b7482

Signed-off-by: Nathan Klick <[email protected]>

chore: fix smoke test and add better diag output

8beffaf

Signed-off-by: Nathan Klick <[email protected]>

chore: final smoke fixes

d99148a

Signed-off-by: Nathan Klick <[email protected]>

jeromy-cannon approved these changes Feb 14, 2025

View reviewed changes

jeromy-cannon merged commit ec7eca1 into main Feb 14, 2025
40 of 41 checks passed

jeromy-cannon deleted the dual-cluster-tests branch February 14, 2025 08:45

swirlds-automation added the released label Feb 20, 2025

swirlds-automation added the released on @0.35.x label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for multi-cluster testing via KinD #1392

feat: add support for multi-cluster testing via KinD #1392

nathanklick commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

codacy-production bot commented Feb 14, 2025 •

edited

Loading

codecov bot commented Feb 14, 2025 •

edited

Loading

swirlds-automation commented Feb 20, 2025

swirlds-automation commented Feb 24, 2025

feat: add support for multi-cluster testing via KinD #1392

feat: add support for multi-cluster testing via KinD #1392

Conversation

nathanklick commented Feb 14, 2025 • edited Loading

Description

Related Issues

github-actions bot commented Feb 14, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Feb 14, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Feb 14, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Feb 14, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Feb 14, 2025 • edited Loading

Codecov Report

swirlds-automation commented Feb 20, 2025

swirlds-automation commented Feb 24, 2025

nathanklick commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

codacy-production bot commented Feb 14, 2025 •

edited

Loading

codecov bot commented Feb 14, 2025 •

edited

Loading