feat(multi-cluster): Update `solo node setup` to support multiple clusters #1368

instamenta · 2025-02-12T00:13:46Z

Description

Related Issues

Closes #1358

… for each node Signed-off-by: instamenta <[email protected]>

Signed-off-by: instamenta <[email protected]>

github-actions · 2025-02-12T12:44:45Z

Unit Test Results - Linux

1 files ±0 61 suites ±0 3s ⏱️ -1s
237 tests ±0 237 ✅ ±0 0 💤 ±0 0 ❌ ±0
246 runs ±0 246 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit a4097ea. ± Comparison against base commit 8411ff3.

♻️ This comment has been updated with latest results.

github-actions · 2025-02-12T12:45:53Z

Unit Test Results - Windows

1 files ±0 61 suites ±0 3s ⏱️ ±0s
237 tests ±0 237 ✅ ±0 0 💤 ±0 0 ❌ ±0
246 runs ±0 246 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit a4097ea. ± Comparison against base commit 8411ff3.

♻️ This comment has been updated with latest results.

…d obsolete changes Signed-off-by: instamenta <[email protected]>

…e-setup---deployment-to-support-multiple-clusters

github-actions · 2025-02-12T14:06:24Z

E2E Test Report

17 files 126 suites 1h 27m 10s ⏱️
254 tests 254 ✅ 0 💤 0 ❌
265 runs 265 ✅ 0 💤 0 ❌

Results for commit a4097ea.

♻️ This comment has been updated with latest results.

codacy-production · 2025-02-12T14:06:58Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.05% (target: -1.00%)	✅ 97.50%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`8411ff3`)	23707	19815	83.58%
Head commit (`a4097ea`)	23786 (+79)	19894 (+79)	83.64% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1368)	120	117	97.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-02-12T14:08:03Z

Codecov Report

Attention: Patch coverage is 97.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (8411ff3) to head (a4097ea).
Report is 54 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/platform_installer.ts	94.87%	2 Missing ⚠️
src/core/helpers.ts	94.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
+ Coverage   82.51%   82.56%   +0.04%     
==========================================
  Files         130      130              
  Lines       23707    23786      +79     
  Branches     2246     1674     -572     
==========================================
+ Hits        19563    19640      +77     
- Misses       3948     4065     +117     
+ Partials      196       81     -115

Files with missing lines	Coverage Δ
src/commands/base.ts	`94.91% <100.00%> (+0.12%)`	⬆️
src/commands/node/configs.ts	`91.94% <100.00%> (+0.08%)`	⬆️
src/commands/node/handlers.ts	`84.53% <100.00%> (+0.01%)`	⬆️
src/commands/node/tasks.ts	`93.78% <100.00%> (+0.10%)`	⬆️
src/core/model/consensus_node.ts	`100.00% <100.00%> (ø)`
src/core/helpers.ts	`80.50% <94.11%> (+0.60%)`	⬆️
src/core/platform_installer.ts	`88.47% <94.87%> (+0.20%)`	⬆️

... and 48 files with indirect coverage changes

src/commands/base.ts

## [0.35.0](v0.34.0...v0.35.0) (2025-02-20) ### Features * Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc)) * add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4)) * add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b)) * add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae)) * add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0)) * add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3)) * add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3)) * add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956)) * add factory and injection logic ([#1352](#1352)) ([c794610](c794610)) * add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47)) * add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6)) * add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998)) * add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967)) * add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1)) * add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f)) * **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486)) * **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5)) * create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c)) * **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac)) * **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095)) * **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5)) * **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c)) * **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39)) * **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43)) * **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e)) * **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab)) * Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90)) * update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592)) ### Bug Fixes * ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f)) * ensure staking updates support multi-cluster deployments ([#1432](#1432)) ([ef5435e](ef5435e)) * fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2)) * fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806)) * increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167)) * mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e)) * **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f)) * **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b)) * Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937)) * test script of google storage ([#1397](#1397)) ([370f57b](370f57b)) * update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276)) * update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f)) * use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))

swirlds-automation · 2025-02-20T01:51:51Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-02-24T01:51:01Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

switched from node aliases to consesus nodes in order to have context…

62338a8

… for each node Signed-off-by: instamenta <[email protected]>

instamenta requested a review from jeromy-cannon February 12, 2025 00:13

instamenta self-assigned this Feb 12, 2025

instamenta linked an issue Feb 12, 2025 that may be closed by this pull request

Update solo node setup --deployment to support multiple clusters #1358

Closed

instamenta added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. and removed PR: Unresolved Comments A pull request where there are comments and they need to be resolved. labels Feb 12, 2025

add new helper functions and remove the temporary methods

1c8357f

Signed-off-by: instamenta <[email protected]>

instamenta added 2 commits February 12, 2025 15:25

added try catch to prevent erroring on getConsensusNodes() and remove…

2c8d889

…d obsolete changes Signed-off-by: instamenta <[email protected]>

Merge remote-tracking branch 'origin/main' into 01358-update-solo-nod…

a4097ea

…e-setup---deployment-to-support-multiple-clusters

instamenta marked this pull request as ready for review February 12, 2025 13:40

instamenta requested review from leninmehedy and a team as code owners February 12, 2025 13:40

nathanklick reviewed Feb 12, 2025

View reviewed changes

src/commands/base.ts Show resolved Hide resolved

nathanklick approved these changes Feb 13, 2025

View reviewed changes

nathanklick merged commit 4618a43 into main Feb 13, 2025
41 checks passed

nathanklick deleted the 01358-update-solo-node-setup---deployment-to-support-multiple-clusters branch February 13, 2025 06:42

swirlds-automation added the released label Feb 20, 2025

swirlds-automation added the released on @0.35.x label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(multi-cluster): Update `solo node setup` to support multiple clusters #1368

feat(multi-cluster): Update `solo node setup` to support multiple clusters #1368

instamenta commented Feb 12, 2025

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

codacy-production bot commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 12, 2025 •

edited

Loading

swirlds-automation commented Feb 20, 2025

swirlds-automation commented Feb 24, 2025

feat(multi-cluster): Update solo node setup to support multiple clusters #1368

feat(multi-cluster): Update solo node setup to support multiple clusters #1368

Conversation

instamenta commented Feb 12, 2025

Description

Related Issues

github-actions bot commented Feb 12, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Feb 12, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Feb 12, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Feb 12, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Feb 12, 2025 • edited Loading

Codecov Report

swirlds-automation commented Feb 20, 2025

swirlds-automation commented Feb 24, 2025

feat(multi-cluster): Update `solo node setup` to support multiple clusters #1368

feat(multi-cluster): Update `solo node setup` to support multiple clusters #1368

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

codacy-production bot commented Feb 12, 2025 •

edited

Loading

codecov bot commented Feb 12, 2025 •

edited

Loading