fix: fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme #1396

jeromy-cannon · 2025-02-14T17:21:40Z

Description

This pull request changes the following:

fixed issue with taskfile forcing an incorrect cluster
context and added a dual cluster readme

Related Issues

Closes #

github-actions · 2025-02-14T17:23:53Z

Unit Test Results - Linux

1 files ±0 62 suites ±0 2s ⏱️ ±0s
241 tests ±0 241 ✅ ±0 0 💤 ±0 0 ❌ ±0
250 runs ±0 250 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 767eb84. ± Comparison against base commit e73114c.

♻️ This comment has been updated with latest results.

github-actions · 2025-02-14T17:25:05Z

Unit Test Results - Windows

1 files ±0 62 suites ±0 3s ⏱️ ±0s
241 tests ±0 241 ✅ ±0 0 💤 ±0 0 ❌ ±0
250 runs ±0 250 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 767eb84. ± Comparison against base commit e73114c.

♻️ This comment has been updated with latest results.

alex-kuzmin-hg

Looks cool

Signed-off-by: Jeromy Cannon <[email protected]>

github-actions · 2025-02-14T19:25:07Z

E2E Test Report

17 files ±0 126 suites ±0 1h 35m 53s ⏱️ +16s
270 tests ±0 270 ✅ ±0 0 💤 ±0 0 ❌ ±0
285 runs ±0 285 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 767eb84. ± Comparison against base commit e73114c.

♻️ This comment has been updated with latest results.

codacy-production · 2025-02-14T19:25:23Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -1.00%)	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`e73114c`)	25165	21338	84.79%
Head commit (`767eb84`)	25165 (+0)	21338 (+0)	84.79% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1396)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-02-14T19:27:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (e73114c) to head (767eb84).
Report is 39 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1396   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files         132      132           
  Lines       25165    25165           
  Branches     1685     1633   -52     
=======================================
  Hits        21057    21057           
- Misses       4067     4089   +22     
+ Partials       41       19   -22

see 13 files with indirect coverage changes

Signed-off-by: Jeromy Cannon <[email protected]>

alex-kuzmin-hg

Totally cool

## [0.35.0](v0.34.0...v0.35.0) (2025-02-20) ### Features * Add adminKey flag to node setup command ([#1193](#1193)) ([b044fcc](b044fcc)) * add BaseCommand.getConsensusNodes() method ([#1364](#1364)) ([44703a4](44703a4)) * add BaseCommand.getContexts() method ([#1366](#1366)) ([7a5b05b](7a5b05b)) * add basic multi-cluster support to `solo network deploy` ([#1389](#1389)) ([22ed9ae](22ed9ae)) * add clusters fluent interface implementation ([#1291](#1291)) ([95c71f0](95c71f0)) * add concurrent to the task of copying hedera jar files to network node ([#1289](#1289)) ([c50f4c3](c50f4c3)) * add configmaps fluent interface implementation ([#1295](#1295)) ([2c5d6f3](2c5d6f3)) * add contexts fluent interface implementation ([#1297](#1297)) ([938a956](938a956)) * add factory and injection logic ([#1352](#1352)) ([c794610](c794610)) * add flags to support aws as storage destination ([#1372](#1372)) ([5ca0e47](5ca0e47)) * add secrets fluent interface implementation ([#1312](#1312)) ([fb92fd6](fb92fd6)) * add service and services fluent interface implementation ([#1303](#1303)) ([8ef6998](8ef6998)) * add support for --force-port-forward as a top level flag ([#1404](#1404)) ([5c18967](5c18967)) * add support for multi-cluster testing via KinD ([#1392](#1392)) ([ec7eca1](ec7eca1)) * add support for using load balancer address in gossip configuration ([#1405](#1405)) ([0e3f41f](0e3f41f)) * **cli:** add new command `solo deployment list` that lists deployments on that specific cluster ([#1220](#1220)) ([6b0b486](6b0b486)) * **cli:** reduce redundancy on context to cluster flags in command `deployment create` ([#1156](#1156)) ([4ab4dd5](4ab4dd5)) * create the v059x node-override.yaml via solo ([#1192](#1192)) ([283d35c](283d35c)) * **external-database:** add ability to pass readonly user to the external database ([#1350](#1350)) ([d9626ac](d9626ac)) * **local-remote-config:** added solo version to local config and remote config ([#1384](#1384)) ([2dca095](2dca095)) * **mirror-node:** Enhance mirror-node external database feature ([#1230](#1230)) ([bce75d5](bce75d5)) * **multi-cluster:** 'solo relay deploy' to handle cluster-ref value ([#1394](#1394)) ([e73114c](e73114c)) * **multi-cluster:** make remote config validation compatible with multi-cluster K8 implementation ([#1407](#1407)) ([7614a39](7614a39)) * **multi-cluster:** Update `solo node setup` to support multiple clusters ([#1368](#1368)) ([4618a43](4618a43)) * **remote-config:** instead of keeping just the command and the subcommand inside the remote config keep the flags as passed ([#1208](#1208)) ([a31498e](a31498e)) * **remote-config:** save reusable solo flags in remoteconfig ([#1191](#1191)) ([809d0ab](809d0ab)) * Separate concepts for namespace and deployment name ([#1231](#1231)) ([2566c90](2566c90)) * update solo to support pathPrefix of mirror node importer ([#1204](#1204)) ([d9a3592](d9a3592)) ### Bug Fixes * ensure network active check supports multi-cluster deployments ([#1431](#1431)) ([a07801f](a07801f)) * ensure staking updates support multi-cluster deployments ([#1432](#1432)) ([ef5435e](ef5435e)) * fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme ([#1396](#1396)) ([cc672c2](cc672c2)) * fixed merge issue with incorrect license header ([#1235](#1235)) ([cb91806](cb91806)) * increase number of attempts to wait for active nodes ([#1430](#1430)) ([d113167](d113167)) * mirror node command changes required for multi-cluster support ([#1433](#1433)) ([f43870e](f43870e)) * **multi-cluster:** fix 'solo node setup' command, failing when running multiple clusters ([#1421](#1421)) ([eacdf1f](eacdf1f)) * **network-command:** wrong value passed to addDebugOptions inside the 'network' command ([#1415](#1415)) ([c2e5c3b](c2e5c3b)) * Resolve `cannot read properties of undefined `error thrown during `solo network deploy` ([#1410](#1410)) ([401b937](401b937)) * test script of google storage ([#1397](#1397)) ([370f57b](370f57b)) * update default solo helm chart version ([#1378](#1378)) ([5b5e276](5b5e276)) * update RemoteConfig to handle multi-cluster networking ([#1348](#1348)) ([77b769f](77b769f)) * use better internal IPs for 0.58.5+ ([#1429](#1429)) ([26279ac](26279ac))

swirlds-automation · 2025-02-20T01:51:24Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

commit 6384dc9 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 19:20:16 2025 +0000 fix: update crypto import to remove node: prefix Signed-off-by: Jeromy Cannon <[email protected]> commit c4af736 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 19:13:33 2025 +0000 docs: add TODO regarding kube config context issues Signed-off-by: Jeromy Cannon <[email protected]> commit e4d12fd Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 18:44:50 2025 +0000 refactor: update crypto import Signed-off-by: Jeromy Cannon <[email protected]> commit 90b6aec Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 18:44:14 2025 +0000 added todo and network deploy verification Signed-off-by: Jeromy Cannon <[email protected]> commit 4ac611b Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 17:21:49 2025 +0000 clean out the cache dir before running test Signed-off-by: Jeromy Cannon <[email protected]> commit ac99403 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 17:18:14 2025 +0000 added node start Signed-off-by: Jeromy Cannon <[email protected]> commit 61155e0 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 16:48:24 2025 +0000 added network deploy Signed-off-by: Jeromy Cannon <[email protected]> commit 9aeebef Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 16:25:21 2025 +0000 added node keys to test Signed-off-by: Jeromy Cannon <[email protected]> commit be8fc62 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 15:16:38 2025 +0000 feat: add dual cluster full end-to-end test and update related configurations Signed-off-by: Jeromy Cannon <[email protected]> commit fe1cd5c Merge: 46c75a9 370f57b Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 23:30:58 2025 +0000 Merge branch 'main' into dual-cluster-relay commit 46c75a9 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 23:30:41 2025 +0000 make setupHomeDirectory more resilient Signed-off-by: Jeromy Cannon <[email protected]> commit 5ab03fa Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 23:21:13 2025 +0000 fixed issue where even though the cache dir flag is set, it was still using environment variables instead. Signed-off-by: Jeromy Cannon <[email protected]> commit 370f57b Author: JeffreyDallas <[email protected]> Date: Fri Feb 14 16:07:31 2025 -0600 fix: test script of google storage (#1397) Signed-off-by: Jeffrey Tang <[email protected]> commit cc672c2 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 22:07:08 2025 +0000 fix: fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme (#1396) Signed-off-by: Jeromy Cannon <[email protected]> commit f5798d1 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 22:06:43 2025 +0000 revert remote config changes Signed-off-by: Jeromy Cannon <[email protected]> commit 978fa08 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 22:06:28 2025 +0000 revert remote config changes Signed-off-by: Jeromy Cannon <[email protected]> commit fad945f Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:47:44 2025 +0000 fix: update dual cluster relay test to use context references instead of cluster references Signed-off-by: Jeromy Cannon <[email protected]> commit 3c26981 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:42:41 2025 +0000 feat: enhance dual cluster relay tests with improved configuration and setup Signed-off-by: Jeromy Cannon <[email protected]> commit 6d09820 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:41:14 2025 +0000 added more local config cluster context mappings Signed-off-by: Jeromy Cannon <[email protected]> commit 5706ed5 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:28:08 2025 +0000 removed unused imports Signed-off-by: Jeromy Cannon <[email protected]> commit 50f0491 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:27:44 2025 +0000 added delete verification to delete namespace Signed-off-by: Jeromy Cannon <[email protected]> commit 74edacd Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 19:38:07 2025 +0000 feat: refactor components data handling to support node aliases by cluster Signed-off-by: Jeromy Cannon <[email protected]> commit acf2032 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 17:47:41 2025 +0000 feat: add relay dual cluster test with changes to support Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

swirlds-automation · 2025-02-24T01:50:22Z

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

commit c4dc393 Author: Jeromy Cannon <[email protected]> Date: Thu Feb 20 20:54:22 2025 +0000 push latest Signed-off-by: Jeromy Cannon <[email protected]> commit 5ad515d Author: Jeromy Cannon <[email protected]> Date: Thu Feb 20 19:39:34 2025 +0000 load the remote config Signed-off-by: Jeromy Cannon <[email protected]> commit c1852d1 Author: Jeromy Cannon <[email protected]> Date: Thu Feb 20 18:09:06 2025 +0000 removed type check warnings for Long Signed-off-by: Jeromy Cannon <[email protected]> commit abdfa12 Author: Jeromy Cannon <[email protected]> Date: Thu Feb 20 18:02:39 2025 +0000 Squashed commit of the following: commit 6384dc9 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 19:20:16 2025 +0000 fix: update crypto import to remove node: prefix Signed-off-by: Jeromy Cannon <[email protected]> commit c4af736 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 19:13:33 2025 +0000 docs: add TODO regarding kube config context issues Signed-off-by: Jeromy Cannon <[email protected]> commit e4d12fd Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 18:44:50 2025 +0000 refactor: update crypto import Signed-off-by: Jeromy Cannon <[email protected]> commit 90b6aec Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 18:44:14 2025 +0000 added todo and network deploy verification Signed-off-by: Jeromy Cannon <[email protected]> commit 4ac611b Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 17:21:49 2025 +0000 clean out the cache dir before running test Signed-off-by: Jeromy Cannon <[email protected]> commit ac99403 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 17:18:14 2025 +0000 added node start Signed-off-by: Jeromy Cannon <[email protected]> commit 61155e0 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 16:48:24 2025 +0000 added network deploy Signed-off-by: Jeromy Cannon <[email protected]> commit 9aeebef Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 16:25:21 2025 +0000 added node keys to test Signed-off-by: Jeromy Cannon <[email protected]> commit be8fc62 Author: Jeromy Cannon <[email protected]> Date: Sat Feb 15 15:16:38 2025 +0000 feat: add dual cluster full end-to-end test and update related configurations Signed-off-by: Jeromy Cannon <[email protected]> commit fe1cd5c Merge: 46c75a9 370f57b Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 23:30:58 2025 +0000 Merge branch 'main' into dual-cluster-relay commit 46c75a9 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 23:30:41 2025 +0000 make setupHomeDirectory more resilient Signed-off-by: Jeromy Cannon <[email protected]> commit 5ab03fa Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 23:21:13 2025 +0000 fixed issue where even though the cache dir flag is set, it was still using environment variables instead. Signed-off-by: Jeromy Cannon <[email protected]> commit 370f57b Author: JeffreyDallas <[email protected]> Date: Fri Feb 14 16:07:31 2025 -0600 fix: test script of google storage (#1397) Signed-off-by: Jeffrey Tang <[email protected]> commit cc672c2 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 22:07:08 2025 +0000 fix: fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme (#1396) Signed-off-by: Jeromy Cannon <[email protected]> commit f5798d1 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 22:06:43 2025 +0000 revert remote config changes Signed-off-by: Jeromy Cannon <[email protected]> commit 978fa08 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 22:06:28 2025 +0000 revert remote config changes Signed-off-by: Jeromy Cannon <[email protected]> commit fad945f Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:47:44 2025 +0000 fix: update dual cluster relay test to use context references instead of cluster references Signed-off-by: Jeromy Cannon <[email protected]> commit 3c26981 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:42:41 2025 +0000 feat: enhance dual cluster relay tests with improved configuration and setup Signed-off-by: Jeromy Cannon <[email protected]> commit 6d09820 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:41:14 2025 +0000 added more local config cluster context mappings Signed-off-by: Jeromy Cannon <[email protected]> commit 5706ed5 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:28:08 2025 +0000 removed unused imports Signed-off-by: Jeromy Cannon <[email protected]> commit 50f0491 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 21:27:44 2025 +0000 added delete verification to delete namespace Signed-off-by: Jeromy Cannon <[email protected]> commit 74edacd Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 19:38:07 2025 +0000 feat: refactor components data handling to support node aliases by cluster Signed-off-by: Jeromy Cannon <[email protected]> commit acf2032 Author: Jeromy Cannon <[email protected]> Date: Fri Feb 14 17:47:41 2025 +0000 feat: add relay dual cluster test with changes to support Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon self-assigned this Feb 14, 2025

jeromy-cannon requested review from leninmehedy and a team as code owners February 14, 2025 17:21

alex-kuzmin-hg previously approved these changes Feb 14, 2025

View reviewed changes

jeromy-cannon dismissed alex-kuzmin-hg’s stale review via 5ec89a2 February 14, 2025 17:44

jeromy-cannon force-pushed the dual-cluster-readme branch from 9bbc5b5 to 364118a Compare February 14, 2025 18:15

jeromy-cannon added 5 commits February 14, 2025 18:48

feat: add README for local dual cluster testing and diagnostics

4f76ee5

Signed-off-by: Jeromy Cannon <[email protected]>

feat: add CONTEXT variable handling in Taskfile for deployment commands

bb3d4ed

Signed-off-by: Jeromy Cannon <[email protected]>

feat: add CLUSTER_REF handling in Taskfile for deployment commands

72f20f7

Signed-off-by: Jeromy Cannon <[email protected]>

fixed issue with taskfile helper

1130382

Signed-off-by: Jeromy Cannon <[email protected]>

fix: improve CONTEXT and CLUSTER_REF handling in Taskfile helper

abbb48a

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the dual-cluster-readme branch from 364118a to abbb48a Compare February 14, 2025 18:48

fix: correct SOLO_CHART_FLAG syntax in Taskfile helper

767eb84

Signed-off-by: Jeromy Cannon <[email protected]>

alex-kuzmin-hg approved these changes Feb 14, 2025

View reviewed changes

jeromy-cannon merged commit cc672c2 into main Feb 14, 2025
41 checks passed

jeromy-cannon deleted the dual-cluster-readme branch February 14, 2025 22:07

swirlds-automation added the released label Feb 20, 2025

swirlds-automation added the released on @0.35.x label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme #1396

fix: fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme #1396

jeromy-cannon commented Feb 14, 2025

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

alex-kuzmin-hg left a comment

github-actions bot commented Feb 14, 2025 •

edited

Loading

codacy-production bot commented Feb 14, 2025 •

edited

Loading

codecov bot commented Feb 14, 2025 •

edited

Loading

alex-kuzmin-hg left a comment

swirlds-automation commented Feb 20, 2025

swirlds-automation commented Feb 24, 2025

fix: fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme #1396

fix: fixed issue with taskfile forcing an incorrect cluster and context and added a dual cluster readme #1396

Conversation

jeromy-cannon commented Feb 14, 2025

Description

Related Issues

github-actions bot commented Feb 14, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Feb 14, 2025 • edited Loading

Unit Test Results - Windows

alex-kuzmin-hg left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Feb 14, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Feb 14, 2025 • edited Loading

Codecov Report

alex-kuzmin-hg left a comment

Choose a reason for hiding this comment

swirlds-automation commented Feb 20, 2025

swirlds-automation commented Feb 24, 2025

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

codacy-production bot commented Feb 14, 2025 •

edited

Loading

codecov bot commented Feb 14, 2025 •

edited

Loading