New Resource - `azurerm_function_app_flex_consumption` #28199

xiaxyi · 2024-12-06T10:11:49Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

To make a separate pr for this new feature, referring to the #27531

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…b app/ app slot

…n/flex

nzthiago · 2024-12-06T16:45:24Z

@xiaxyi - thank you for this PR. Only note from me is we don't want customers to worry about operating system, with no plans for a Windows version of Flex Consumption in the foreseeable future. Can we please simplify the name and code not to have Linux in it for Flex Consumption? Other than that I'm happy with separating it out into its own resource type, thank you.

joshvito · 2025-02-11T19:11:01Z

Patiently awaiting this feature! Thanks

ryaneastabrook · 2025-02-11T19:57:40Z

Ran into same issue, would love to see this merged!

stephybun

In addition to the local location overrides for the tests, can you please address these last few comments.

stephybun · 2025-02-12T07:35:08Z

website/docs/r/function_app_flex_consumption.html.markdown

+
+* `app_settings` - (Optional) A map of key-value pairs for [App Settings](https://docs.microsoft.com/azure/azure-functions/functions-app-settings) and custom values.
+
+~> **NOTE:** For storage related settings, please use related properties that are available such as `storage_account_access_key`, terraform will assign the value to keys such as `WEBSITE_CONTENTAZUREFILECONNECTIONSTRING`, `AzureWebJobsStorage` in app_setting.


Since these reviews, we've introduced a guide on documentation standards. Please title case all of the notes

Suggested change

~> **NOTE:** For storage related settings, please use related properties that are available such as `storage_account_access_key`, terraform will assign the value to keys such as `WEBSITE_CONTENTAZUREFILECONNECTIONSTRING`, `AzureWebJobsStorage` in app_setting.

~> **Note:** For storage related settings, please use related properties that are available such as `storage_account_access_key`, terraform will assign the value to keys such as `WEBSITE_CONTENTAZUREFILECONNECTIONSTRING`, `AzureWebJobsStorage` in app_setting.

I think this was addressed?

@xiaxyi this hasn't been addressed, I'm asking for all instances of NOTE (uppercase) in the documentation to be recased to Note (titlecase).

stephybun · 2025-02-12T07:35:21Z

internal/services/appservice/registration.go

@@ -47,6 +47,7 @@ func (r Registration) Resources() []sdk.Resource {
 		LinuxFunctionAppSlotResource{},
 		LinuxWebAppResource{},
 		LinuxWebAppSlotResource{},
+		FunctionAppFlexConsumptionResource{},


still not sorted alphabetically

stephybun · 2025-02-12T07:35:55Z

website/docs/r/linux_function_app.html.markdown

@@ -67,6 +67,8 @@ The following arguments are supported:

 * `site_config` - (Required) A `site_config` block as defined below.

+* `flex_function_app_deployment` - (Optional) A `flex_consumption_app_deployment` block as defined below.


These documentation updates on the linux function app should be removed since these properties haven't been added to the resource.

dvasdekis · 2025-02-17T03:35:56Z

Hi @stephybun it appears that the requested changes have been made in the latest commit?

ryaneastabrook · 2025-02-19T14:11:59Z

Is there any help the community can provide to get this moving again?

nzthiago · 2025-02-19T16:47:06Z

Thank you for the follow ups everyone. We are making progress. The testing automation subscription is running into a 'Flex Consumption pricing tier is not enabled for this subscription' message and we are actively working to unblock it so @xiaxyi's testing can resume.

xiaxyi · 2025-02-26T02:44:49Z

Hi @stephybun, I'm not sure about why all the test cases failed due to the 400 error, despite of the fact that I've set the test location to eastus2 via the environment ARM_TEST_LOCATION. I've ran all the failed test cases separately and now they all passed. Would you mind continue to review this PR and let me know your comments? Thanks!

stephybun · 2025-02-26T08:14:31Z

internal/services/appservice/function_app_flex_consumption_resource_test.go

+  os_type             = "Linux"
+  sku_name            = "FC1"
+}
+`, data.RandomInteger, data.Locations.Primary, data.RandomString, data.RandomInteger)


Suggested change

`, data.RandomInteger, data.Locations.Primary, data.RandomString, data.RandomInteger)

`, data.RandomInteger, "eastus2", data.RandomString, data.RandomInteger) // location needs to be hardcoded for the moment because flex isn't available in all regions yet and appservice already has location overrides in TC

@stephybun : If we are suggesting to hardcode it to eastus2, does that mean customers can only create the resource in eastus2 region, even if other regions are supported from Azure? If I'm not wrong, there are many regions which support flex consumption plans.

@pcsrijith this hardcodes the region only for our acceptance tests and has no bearing on what regions users will be able to provision this in.

nzthiago · 2025-02-26T17:40:56Z

@stephybun it looks like data.Locations.Primary is set to West Europe in the acceptance test. Flex Consumption is currently in Australia East, East Asia, East US, East US 2, North Europe, Southcentral US, Southeast Asia, Sweden Central,
UK South, West US 2, West US 3.

Not a huge deal but would data.Locations.Secondary or data.Locations.Ternary match one of those? If so, it might be better instead of fully hardcoding the region.

stephybun

Tests looks good, thanks @xiaxyi LGTM 👍

pcsrijith · 2025-02-27T09:16:13Z

Thank you @xiaxyi , @nzthiago and @stephybun for MR. Will create the resources as soon as 4.21.0 goes live.

* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: Wyatt Fry <[email protected]>

AELO23 · 2025-02-28T13:54:12Z

this is awesome!!

xiaxyi · 2025-03-03T04:41:35Z

Please try using
storage_container_endpoint= "${azurerm_storage_account.test.primary_blob_endpoint}${azurerm_storage_container.test.name}"

david-haugh · 2025-03-03T15:45:24Z

Thanks, everyone, for this! Does it include a parameter for always-ready instances?

xiaxyi added 21 commits August 26, 2024 16:49

upgrade api version from 2023-01-01 to 2023-12-01 for function and we…

91b35f2

…b app/ app slot

update code

c7a56a0

update vendor

6f59477

Merge remote-tracking branch 'origin/webapps/upgradeapi' into functio…

b572658

…n/flex

Merge remote-tracking branch 'upstream/main' into function/flex

5ba49b0

add azure linux function app new feature flex consumption

eddf5a6

update expanding error for flex consumption config

7ac0a72

Merge remote-tracking branch 'upstream/main' into function/flex

e91a283

Merge remote-tracking branch 'upstream/main' into function/flex

0afa904

update vendor

0d7e9ab

fix linter

390a5c4

sort imports

f179afb

Merge remote-tracking branch 'upstream/main' into function/flex

1f902aa

remove validation check for instance count property

1b43141

resolve conflicts

0ca185a

Merge remote-tracking branch 'upstream/main' into function/flex

1d28096

merging upstream code

bd8ec4e

resolving golinter error

f5ff78c

merging upstream

d1de89c

merging upstream

5605e28

add new resource flex consumption linux function app

747803d

xiaxyi requested a review from a team as a code owner December 6, 2024 10:11

github-actions bot added the enhancement label Dec 6, 2024

xiaxyi mentioned this pull request Dec 6, 2024

azurerm_linux_function_app - add flex consumption feature. #27531

Closed

14 tasks

github-actions bot added documentation service/app-service size/XL waiting-response labels Dec 6, 2024

Merge remote-tracking branch 'upstream/main' into azurefunction/flex

eaefc76

github-actions bot added the waiting-response label Feb 11, 2025

stephybun requested changes Feb 12, 2025

View reviewed changes

update docs

e651354

github-actions bot removed the waiting-response label Feb 12, 2025

nzthiago mentioned this pull request Feb 20, 2025

Terraform: Is it required to use azapi_resource or is there a way to do this with app_service_plan Azure-Samples/azure-functions-flex-consumption-samples#49

Open

Merge remote-tracking branch 'upstream/main' into function/flex

e7123a7

stephybun requested changes Feb 26, 2025

View reviewed changes

github-actions bot added the waiting-response label Feb 26, 2025

xiaxyi added 2 commits February 27, 2025 16:23

Merge remote-tracking branch 'upstream/main' into function/flex

7b46311

hard code test location

573e31b

github-actions bot removed the waiting-response label Feb 27, 2025

stephybun approved these changes Feb 27, 2025

View reviewed changes

stephybun merged commit 4a05d26 into hashicorp:main Feb 27, 2025
33 checks passed

github-actions bot added this to the v4.21.0 milestone Feb 27, 2025

stephybun added a commit that referenced this pull request Feb 27, 2025

Update for #28199

5505e31

xiaxyi changed the title ~~New Resource - azurerm_linux_function_app_flex_consumption~~ New Resource - azurerm_function_app_flex_consumption Feb 27, 2025

AndreuCodina mentioned this pull request Mar 2, 2025

Wrong environment variables with azurerm_function_app_flex_consumption #28925

Closed

1 task

AndreuCodina mentioned this pull request Mar 3, 2025

key_vault_reference_identity_id not expected in azurerm_function_app_flex_consumption #28928

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource - `azurerm_function_app_flex_consumption` #28199

New Resource - `azurerm_function_app_flex_consumption` #28199

xiaxyi commented Dec 6, 2024 •

edited by rcskosir

Loading

nzthiago commented Dec 6, 2024 •

edited

Loading

joshvito commented Feb 11, 2025

ryaneastabrook commented Feb 11, 2025

stephybun left a comment

stephybun Feb 12, 2025

xiaxyi Feb 12, 2025 •

edited

Loading

stephybun Feb 12, 2025 •

edited

Loading

stephybun Feb 12, 2025

stephybun Feb 12, 2025

xiaxyi Feb 12, 2025

dvasdekis commented Feb 17, 2025

ryaneastabrook commented Feb 19, 2025

nzthiago commented Feb 19, 2025

xiaxyi commented Feb 26, 2025

stephybun Feb 26, 2025

pcsrijith Feb 26, 2025

stephybun Feb 26, 2025

nzthiago commented Feb 26, 2025 •

edited

Loading

stephybun left a comment

pcsrijith commented Feb 27, 2025

AELO23 commented Feb 28, 2025

xiaxyi commented Mar 3, 2025 •

edited

Loading

david-haugh commented Mar 3, 2025


		* `app_settings` - (Optional) A map of key-value pairs for [App Settings](https://docs.microsoft.com/azure/azure-functions/functions-app-settings) and custom values.

		~> NOTE: For storage related settings, please use related properties that are available such as `storage_account_access_key`, terraform will assign the value to keys such as `WEBSITE_CONTENTAZUREFILECONNECTIONSTRING`, `AzureWebJobsStorage` in app_setting.

		@@ -67,6 +67,8 @@ The following arguments are supported:

		* `site_config` - (Required) A `site_config` block as defined below.

		* `flex_function_app_deployment` - (Optional) A `flex_consumption_app_deployment` block as defined below.

	`, data.RandomInteger, data.Locations.Primary, data.RandomString, data.RandomInteger)
	`, data.RandomInteger, "eastus2", data.RandomString, data.RandomInteger) // location needs to be hardcoded for the moment because flex isn't available in all regions yet and appservice already has location overrides in TC

New Resource - azurerm_function_app_flex_consumption #28199

New Resource - azurerm_function_app_flex_consumption #28199

Conversation

xiaxyi commented Dec 6, 2024 • edited by rcskosir Loading

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

nzthiago commented Dec 6, 2024 • edited Loading

joshvito commented Feb 11, 2025

ryaneastabrook commented Feb 11, 2025

stephybun left a comment

Choose a reason for hiding this comment

stephybun Feb 12, 2025

Choose a reason for hiding this comment

xiaxyi Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

stephybun Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

stephybun Feb 12, 2025

Choose a reason for hiding this comment

stephybun Feb 12, 2025

Choose a reason for hiding this comment

xiaxyi Feb 12, 2025

Choose a reason for hiding this comment

dvasdekis commented Feb 17, 2025

ryaneastabrook commented Feb 19, 2025

nzthiago commented Feb 19, 2025

xiaxyi commented Feb 26, 2025

stephybun Feb 26, 2025

Choose a reason for hiding this comment

pcsrijith Feb 26, 2025

Choose a reason for hiding this comment

stephybun Feb 26, 2025

Choose a reason for hiding this comment

nzthiago commented Feb 26, 2025 • edited Loading

stephybun left a comment

Choose a reason for hiding this comment

pcsrijith commented Feb 27, 2025

AELO23 commented Feb 28, 2025

xiaxyi commented Mar 3, 2025 • edited Loading

david-haugh commented Mar 3, 2025

New Resource - `azurerm_function_app_flex_consumption` #28199

New Resource - `azurerm_function_app_flex_consumption` #28199

xiaxyi commented Dec 6, 2024 •

edited by rcskosir

Loading

nzthiago commented Dec 6, 2024 •

edited

Loading

xiaxyi Feb 12, 2025 •

edited

Loading

stephybun Feb 12, 2025 •

edited

Loading

nzthiago commented Feb 26, 2025 •

edited

Loading

xiaxyi commented Mar 3, 2025 •

edited

Loading