Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_postgresql_flexible_server - add administrator_password_wo and administrator_password_wo_version #28857

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Feb 24, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Testing

=== RUN   TestAccPostgresqlFlexibleServer_writeOnlyPassword
=== PAUSE TestAccPostgresqlFlexibleServer_writeOnlyPassword
=== CONT  TestAccPostgresqlFlexibleServer_writeOnlyPassword
--- PASS: TestAccPostgresqlFlexibleServer_writeOnlyPassword (1191.57s)

=== RUN   TestAccPostgresqlFlexibleServer_updateToWriteOnlyPassword
=== PAUSE TestAccPostgresqlFlexibleServer_updateToWriteOnlyPassword
=== CONT  TestAccPostgresqlFlexibleServer_updateToWriteOnlyPassword
--- PASS: TestAccPostgresqlFlexibleServer_updateToWriteOnlyPassword (1366.91s)

image
Failure is unrelated

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_postgresql_flexible_server - add support for the administrator_password_wo and administrator_password_wo_version properties [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun, I've left a few comments inline if you wouldn't mind taking a look!

Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephybun stephybun merged commit fcd0ecb into main Feb 26, 2025
33 checks passed
@stephybun stephybun deleted the f/postgres-flexible-server-wo branch February 26, 2025 06:30
@github-actions github-actions bot added this to the v4.21.0 milestone Feb 26, 2025
stephybun added a commit that referenced this pull request Feb 26, 2025
jackofallops added a commit that referenced this pull request Feb 27, 2025
* Update CHANGELOG.md for #28840

* Update CHANGELOG.md #28808

* Update CHANGELOG.md #27962

* Update CHANGELOG.md for #28859

* Update for #28825

* Update CHANGELOG.md for #28864

* Update CHANGELOG.md #28539

* Update CHANGELOG.md #28685

* Update CHANGELOG.md for #28818

* Update for #28857 #28799 #28856

* Update for #28122

* Update for #28248 #27805

* Update for #28853

* Update for #28316 #28494 #28696

* Update for #28754

* Update CHANGELOG.md #28771

* Update CHANGELOG.md #28842

* Update for #28879

* Update for #28199

* Update CHANGELOG.md #28862

* prep for release v4.21.0

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants