Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis API to v2024-11-01 #28696

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented Feb 5, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #28578

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@xuzhang3
Copy link
Contributor Author

xuzhang3 commented Feb 6, 2025

The failed test is not relevant to this PR and is fixed in #27852

Acc Test Logs
=== RUN   TestAccRedisLinkedServer_requiresImport
=== PAUSE TestAccRedisLinkedServer_requiresImport
=== CONT  TestAccRedisLinkedServer_requiresImport
--- PASS: TestAccRedisLinkedServer_requiresImport (1540.54s)
=== RUN   TestAccRedisLinkedServer_basic
=== PAUSE TestAccRedisLinkedServer_basic
=== CONT  TestAccRedisLinkedServer_basic
--- PASS: TestAccRedisLinkedServer_basic (1801.04s)

=== RUN   TestAccRedisCacheDataSource_standard
=== PAUSE TestAccRedisCacheDataSource_standard
=== CONT  TestAccRedisCacheDataSource_standard
--- PASS: TestAccRedisCacheDataSource_standard (2089.83s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 2094.532s

=== RUN   TestAccRedisCacheAccessPolicy_basic
=== PAUSE TestAccRedisCacheAccessPolicy_basic
=== RUN   TestAccRedisCacheAccessPolicy_update
=== PAUSE TestAccRedisCacheAccessPolicy_update
=== RUN   TestAccRedisCacheAccessPolicy_multi
=== PAUSE TestAccRedisCacheAccessPolicy_multi
=== RUN   TestAccRedisCacheAccessPolicy_requiresImport
=== PAUSE TestAccRedisCacheAccessPolicy_requiresImport
=== CONT  TestAccRedisCacheAccessPolicy_basic
=== CONT  TestAccRedisCacheAccessPolicy_multi
=== CONT  TestAccRedisCacheAccessPolicy_requiresImport
=== CONT  TestAccRedisCacheAccessPolicy_update
--- PASS: TestAccRedisCacheAccessPolicy_basic (2050.74s)
--- PASS: TestAccRedisCacheAccessPolicy_requiresImport (2092.98s)
--- PASS: TestAccRedisCacheAccessPolicy_multi (2197.86s)
--- PASS: TestAccRedisCacheAccessPolicy_update (2271.76s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 2277.905s

=== RUN   TestAccRedisCache_basic
=== PAUSE TestAccRedisCache_basic
=== RUN   TestAccRedisCache_managedIdentityAuth
=== PAUSE TestAccRedisCache_managedIdentityAuth
=== RUN   TestAccRedisCache_managedIdentityAuthDisable
=== PAUSE TestAccRedisCache_managedIdentityAuthDisable
=== RUN   TestAccRedisCache_withoutSSL
=== PAUSE TestAccRedisCache_withoutSSL
=== RUN   TestAccRedisCache_requiresImport
=== PAUSE TestAccRedisCache_requiresImport
=== RUN   TestAccRedisCache_standard
=== PAUSE TestAccRedisCache_standard
=== RUN   TestAccRedisCache_premium
=== PAUSE TestAccRedisCache_premium
=== RUN   TestAccRedisCache_premiumSharded
=== PAUSE TestAccRedisCache_premiumSharded
=== RUN   TestAccRedisCache_premiumShardedScaling
=== PAUSE TestAccRedisCache_premiumShardedScaling
=== RUN   TestAccRedisCache_AadEnabled
=== PAUSE TestAccRedisCache_AadEnabled
=== RUN   TestAccRedisCache_BackupDisabled
=== PAUSE TestAccRedisCache_BackupDisabled
=== RUN   TestAccRedisCache_BackupEnabled
=== PAUSE TestAccRedisCache_BackupEnabled
=== RUN   TestAccRedisCache_BackupEnabledDisabled
=== PAUSE TestAccRedisCache_BackupEnabledDisabled
=== RUN   TestAccRedisCache_AOFBackupEnabled
=== PAUSE TestAccRedisCache_AOFBackupEnabled
=== RUN   TestAccRedisCache_AOFBackupEnabledDisabled
=== PAUSE TestAccRedisCache_AOFBackupEnabledDisabled
=== RUN   TestAccRedisCache_IgnoreAOFBackupWhenSKUNotPremium
=== PAUSE TestAccRedisCache_IgnoreAOFBackupWhenSKUNotPremium
=== RUN   TestAccRedisCache_PatchSchedule
=== PAUSE TestAccRedisCache_PatchSchedule
=== RUN   TestAccRedisCache_PatchScheduleUpdated
=== PAUSE TestAccRedisCache_PatchScheduleUpdated
=== RUN   TestAccRedisCache_PublicNetworkAccessDisabledEnabled
=== PAUSE TestAccRedisCache_PublicNetworkAccessDisabledEnabled
=== RUN   TestAccRedisCache_InternalSubnet
=== PAUSE TestAccRedisCache_InternalSubnet
=== RUN   TestAccRedisCache_InternalSubnetStaticIP
=== PAUSE TestAccRedisCache_InternalSubnetStaticIP
=== RUN   TestAccRedisCache_InternalSubnet_withZone
=== PAUSE TestAccRedisCache_InternalSubnet_withZone
=== RUN   TestAccRedisCache_SubscribeAllEvents
=== PAUSE TestAccRedisCache_SubscribeAllEvents
=== RUN   TestAccRedisCache_WithoutAuth
=== PAUSE TestAccRedisCache_WithoutAuth
=== RUN   TestAccRedisCache_ReplicasPerMaster
=== PAUSE TestAccRedisCache_ReplicasPerMaster
=== RUN   TestAccRedisCache_ReplicasPerPrimary
=== PAUSE TestAccRedisCache_ReplicasPerPrimary
=== RUN   TestAccRedisCache_RedisVersion
=== PAUSE TestAccRedisCache_RedisVersion
=== RUN   TestAccRedisCache_TenantSettings
=== PAUSE TestAccRedisCache_TenantSettings
=== RUN   TestAccRedisCache_redisConfiguration
=== PAUSE TestAccRedisCache_redisConfiguration
=== RUN   TestAccRedisCache_identity
=== PAUSE TestAccRedisCache_identity
=== RUN   TestAccRedisCache_AccessKeysAuthenticationEnabledDisabled
=== PAUSE TestAccRedisCache_AccessKeysAuthenticationEnabledDisabled
=== CONT  TestAccRedisCache_basic
=== CONT  TestAccRedisCache_PatchSchedule
=== CONT  TestAccRedisCache_premiumShardedScaling
=== CONT  TestAccRedisCache_BackupEnabledDisabled
=== CONT  TestAccRedisCache_AOFBackupEnabledDisabled
=== CONT  TestAccRedisCache_IgnoreAOFBackupWhenSKUNotPremium
=== CONT  TestAccRedisCache_ReplicasPerMaster
=== CONT  TestAccRedisCache_AccessKeysAuthenticationEnabledDisabled
=== CONT  TestAccRedisCache_identity
=== CONT  TestAccRedisCache_WithoutAuth
=== CONT  TestAccRedisCache_InternalSubnetStaticIP
=== CONT  TestAccRedisCache_redisConfiguration
=== CONT  TestAccRedisCache_premiumSharded
=== CONT  TestAccRedisCache_TenantSettings
=== CONT  TestAccRedisCache_RedisVersion
=== CONT  TestAccRedisCache_ReplicasPerPrimary
=== NAME  TestAccRedisCache_premiumShardedScaling
    testcase.go:173: Step 2/2 error: Error running apply: exit status 1

        Error: updating Redi (Subscription: "0b1f6471-1bf0-4dda-aec3-cb9272f09590"
        Resource Group Name: "acctestRG-250206113844707221"
        Redis Name: "acctestRedis-250206113844707221"): unexpected status 400 (400 Bad Request) with error: BadRequest: The following updates can't be processed in one single request, please send separate request to update them: 'properties.sku.capacity,properties.aadEnableDisable'.
        RequestID=52eb9413-70d7-4df7-ac19-a7b80e13305e

          with azurerm_redis_cache.test,
          on terraform_plugin_test.tf line 40, in resource "azurerm_redis_cache" "test":
          40: resource "azurerm_redis_cache" "test" {

--- PASS: TestAccRedisCache_TenantSettings (924.22s)
=== CONT  TestAccRedisCache_premium
--- PASS: TestAccRedisCache_RedisVersion (955.79s)
=== CONT  TestAccRedisCache_standard
--- PASS: TestAccRedisCache_PatchSchedule (969.05s)
=== CONT  TestAccRedisCache_requiresImport
--- PASS: TestAccRedisCache_ReplicasPerPrimary (973.33s)
=== CONT  TestAccRedisCache_withoutSSL
--- PASS: TestAccRedisCache_ReplicasPerMaster (977.23s)
=== CONT  TestAccRedisCache_managedIdentityAuthDisable
--- FAIL: TestAccRedisCache_premiumShardedScaling (999.42s)
=== CONT  TestAccRedisCache_managedIdentityAuth
--- PASS: TestAccRedisCache_premiumSharded (1010.35s)
=== CONT  TestAccRedisCache_PublicNetworkAccessDisabledEnabled
--- PASS: TestAccRedisCache_redisConfiguration (1063.36s)
=== CONT  TestAccRedisCache_InternalSubnet
--- PASS: TestAccRedisCache_BackupEnabledDisabled (1106.38s)
=== CONT  TestAccRedisCache_BackupDisabled
--- PASS: TestAccRedisCache_AOFBackupEnabledDisabled (1125.73s)
=== CONT  TestAccRedisCache_BackupEnabled
--- PASS: TestAccRedisCache_premium (929.59s)
=== CONT  TestAccRedisCache_SubscribeAllEvents
--- PASS: TestAccRedisCache_BackupDisabled (829.27s)
=== CONT  TestAccRedisCache_PatchScheduleUpdated
--- PASS: TestAccRedisCache_BackupEnabled (938.82s)
=== CONT  TestAccRedisCache_InternalSubnet_withZone
--- PASS: TestAccRedisCache_IgnoreAOFBackupWhenSKUNotPremium (2118.57s)
=== CONT  TestAccRedisCache_AadEnabled
--- PASS: TestAccRedisCache_identity (2248.65s)
=== CONT  TestAccRedisCache_AOFBackupEnabled
--- PASS: TestAccRedisCache_InternalSubnetStaticIP (2277.21s)
--- PASS: TestAccRedisCache_SubscribeAllEvents (818.60s)
--- PASS: TestAccRedisCache_PatchScheduleUpdated (857.07s)
--- PASS: TestAccRedisCache_requiresImport (1863.09s)
--- PASS: TestAccRedisCache_standard (1987.45s)
--- PASS: TestAccRedisCache_managedIdentityAuth (1946.89s)
--- PASS: TestAccRedisCache_withoutSSL (2015.75s)
--- PASS: TestAccRedisCache_AadEnabled (881.61s)
--- PASS: TestAccRedisCache_managedIdentityAuthDisable (2046.60s)
--- PASS: TestAccRedisCache_WithoutAuth (3039.05s)
--- PASS: TestAccRedisCache_AccessKeysAuthenticationEnabledDisabled (3047.32s)
--- PASS: TestAccRedisCache_InternalSubnet (1985.82s)
--- PASS: TestAccRedisCache_AOFBackupEnabled (896.47s)
--- PASS: TestAccRedisCache_PublicNetworkAccessDisabledEnabled (2219.12s)
--- PASS: TestAccRedisCache_InternalSubnet_withZone (1276.23s)
--- PASS: TestAccRedisCache_basic (3582.90s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 3585.954s
FAIL

=== RUN   TestAccRedisFirewallRule_basic
=== PAUSE TestAccRedisFirewallRule_basic
=== RUN   TestAccRedisFirewallRule_multi
=== PAUSE TestAccRedisFirewallRule_multi
=== RUN   TestAccRedisFirewallRule_requiresImport
=== PAUSE TestAccRedisFirewallRule_requiresImport
=== RUN   TestAccRedisFirewallRule_update
=== PAUSE TestAccRedisFirewallRule_update
=== CONT  TestAccRedisFirewallRule_update
=== CONT  TestAccRedisFirewallRule_basic
=== CONT  TestAccRedisFirewallRule_requiresImport
=== CONT  TestAccRedisFirewallRule_multi
--- PASS: TestAccRedisFirewallRule_update (877.80s)
--- PASS: TestAccRedisFirewallRule_requiresImport (890.62s)
--- PASS: TestAccRedisFirewallRule_multi (923.12s)
--- PASS: TestAccRedisFirewallRule_basic (938.80s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 941.737s

=== RUN   TestAccRedisCacheAccessPolicyAssignment_basic
=== PAUSE TestAccRedisCacheAccessPolicyAssignment_basic
=== RUN   TestAccRedisCacheAccessPolicyAssignment_multi
=== PAUSE TestAccRedisCacheAccessPolicyAssignment_multi
=== RUN   TestAccRedisCacheAccessPolicyAssignment_requiresImport
=== PAUSE TestAccRedisCacheAccessPolicyAssignment_requiresImport
=== CONT  TestAccRedisCacheAccessPolicyAssignment_basic
=== CONT  TestAccRedisCacheAccessPolicyAssignment_requiresImport
=== CONT  TestAccRedisCacheAccessPolicyAssignment_multi
--- PASS: TestAccRedisCacheAccessPolicyAssignment_basic (2209.76s)
--- PASS: TestAccRedisCacheAccessPolicyAssignment_requiresImport (2253.63s)
--- PASS: TestAccRedisCacheAccessPolicyAssignment_multi (2396.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 2402.883s

@xuzhang3 xuzhang3 marked this pull request as ready for review February 6, 2025 07:33
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, thanks @xuzhang3 LGTM 👍
image

@stephybun stephybun merged commit bc2ee51 into hashicorp:main Feb 26, 2025
30 checks passed
@github-actions github-actions bot added this to the v4.21.0 milestone Feb 26, 2025
stephybun added a commit that referenced this pull request Feb 26, 2025
jackofallops added a commit that referenced this pull request Feb 27, 2025
* Update CHANGELOG.md for #28840

* Update CHANGELOG.md #28808

* Update CHANGELOG.md #27962

* Update CHANGELOG.md for #28859

* Update for #28825

* Update CHANGELOG.md for #28864

* Update CHANGELOG.md #28539

* Update CHANGELOG.md #28685

* Update CHANGELOG.md for #28818

* Update for #28857 #28799 #28856

* Update for #28122

* Update for #28248 #27805

* Update for #28853

* Update for #28316 #28494 #28696

* Update for #28754

* Update CHANGELOG.md #28771

* Update CHANGELOG.md #28842

* Update for #28879

* Update for #28199

* Update CHANGELOG.md #28862

* prep for release v4.21.0

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Microsoft.Cache for Redis API v2024-11-01
2 participants