azurerm_fluid_relay_server - fix versionless_id support for key_vault_key_id
#28864
+68
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests all good: |
stephybun
reviewed
Feb 25, 2025
Comment on lines
430
to
472
| func (f FluidRelayResource) customerManagedKeyVersionless(data acceptance.TestData) string { | ||
| return fmt.Sprintf(` | ||
|
|
||
|
|
||
| %[1]s | ||
|
|
||
| resource "azurerm_fluid_relay_server" "test" { | ||
| name = "acctestRG-fuildRelayServer-%[2]d" | ||
| resource_group_name = azurerm_resource_group.test.name | ||
| location = azurerm_resource_group.test.location | ||
| identity { | ||
| type = "UserAssigned" | ||
| identity_ids = [azurerm_user_assigned_identity.test.id] | ||
| } | ||
| customer_managed_key { | ||
| key_vault_key_id = azurerm_key_vault_key.test.versionless_id | ||
| user_assigned_identity_id = azurerm_user_assigned_identity.test.id | ||
| } | ||
| } | ||
| `, f.templateWithCMK(data), data.RandomInteger, data.Locations.Primary) | ||
| } | ||
|
|
||
| func (f FluidRelayResource) customerManagedKeyVersionlessUpdated(data acceptance.TestData) string { | ||
| return fmt.Sprintf(` | ||
|
|
||
|
|
||
| %[1]s | ||
|
|
||
| resource "azurerm_fluid_relay_server" "test" { | ||
| name = "acctestRG-fuildRelayServer-%[2]d" | ||
| resource_group_name = azurerm_resource_group.test.name | ||
| location = azurerm_resource_group.test.location | ||
| identity { | ||
| type = "UserAssigned" | ||
| identity_ids = [azurerm_user_assigned_identity.test.id] | ||
| } | ||
| customer_managed_key { | ||
| key_vault_key_id = azurerm_key_vault_key.test.versionless_id | ||
| user_assigned_identity_id = azurerm_user_assigned_identity.test.id | ||
| } | ||
| } | ||
| `, f.templateWithCMK(data), data.RandomInteger, data.Locations.Primary) | ||
| } |
There was a problem hiding this comment.
I'm having trouble spotting the difference between these two test configs
stephybun
approved these changes
Feb 25, 2025
jackofallops
deleted the
b/fluid-relay-support-versionless-keyvault-id
branch
jackofallops
added a commit
that referenced
this pull request
Feb 25, 2025
jackofallops
added a commit
that referenced
this pull request
Feb 27, 2025
* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: Wyatt Fry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azurerm_fluid_relay_server- fixversionless_idsupport forkey_vault_key_idThis is a (please select all that apply):