azurerm_windows_web_app - fix change detection for tomcat_version
#28842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreallymatt
reviewed
Feb 24, 2025
| @@ -1005,6 +1005,28 @@ func TestAccWindowsWebApp_withJava1702Embedded(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccWindowsWebApp_withJava1702EmbeddedUpdate(t *testing.T) { | |||
There was a problem hiding this comment.
I wonder if TestAccWindowsWebApp_withJava1702EmbeddedUpdate should be merged into the existing TestAccWindowsWebApp_withJava1702Embedded test, that way we don't have to provision extra resources. Though the other tests within this file are also very granular, so maybe this is okay?
| @@ -1035,6 +1057,28 @@ func TestAccWindowsWebApp_withJava110414Tomcat10020(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccWindowsWebApp_withJava110414TomcatUpdate(t *testing.T) { | |||
There was a problem hiding this comment.
Same comment as the one on TestAccWindowsWebApp_withJava1702EmbeddedUpdate
|
@sreallymatt thanks for the idea, if nothing else it means fewer lines added and faster tests which is great. |
sreallymatt
approved these changes
Feb 26, 2025
Merged
wyattfry
added a commit
that referenced
this pull request
Feb 26, 2025
jackofallops
added a commit
that referenced
this pull request
Feb 27, 2025
* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: Wyatt Fry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This fixes the bug that prevented the
azurerm_windows_web_apppropertysite_config.application_stack.tomcat_versionfrom updating.PR Checklist
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.N/AFor example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Test Running...
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_windows_web_app- fix change detection fortomcat_version[azurerm_windows_web_app- fix change detection fortomcat_version#28842]This is a (please select all that apply):
Related Issue(s)
Fixes #28471
Note
If this PR changes meaningfully during the course of review please update the title and description as required.