-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
#28316
Conversation
azurerm_service_plan
resourceazurerm_service_plan
- Adding memory intensive SKUs that are available on Portal
azurerm_service_plan
- Adding memory intensive SKUs that are available on Portal azurerm_service_plan
- Adding memory intensive SKUs for azurerm_app_service_environment_v3
azurerm_service_plan
- Adding memory intensive SKUs for azurerm_app_service_environment_v3
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
azurerm_service_plan
- Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3
I've added necessary tests for the enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adrianfuro - This looks mostly good to me, just a docs comment that needs a little attention if can take a look? In the meantime I'll get the testing run on this change.
Co-authored-by: jackofallops <[email protected]>
Hey @jackofallops, any updates on the test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, thanks @adrianfuro LGTM 👍
* Update CHANGELOG.md for #28840 * Update CHANGELOG.md #28808 * Update CHANGELOG.md #27962 * Update CHANGELOG.md for #28859 * Update for #28825 * Update CHANGELOG.md for #28864 * Update CHANGELOG.md #28539 * Update CHANGELOG.md #28685 * Update CHANGELOG.md for #28818 * Update for #28857 #28799 #28856 * Update for #28122 * Update for #28248 #27805 * Update for #28853 * Update for #28316 #28494 #28696 * Update for #28754 * Update CHANGELOG.md #28771 * Update CHANGELOG.md #28842 * Update for #28879 * Update for #28199 * Update CHANGELOG.md #28862 * prep for release v4.21.0 --------- Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Wodans Son <[email protected]> Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: Wyatt Fry <[email protected]>
Community Note
Description
This PR will add
"I1mv2", "I2mv2", "I3mv2", "I4mv2", "I5mv2"
SKU's as available options forazurerm_service_plan
resource. These SKUs are available in Portal and API but not on Terraform since they were added in 2024 as supported SKUs officially.PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_service_plan
- adding memory intensive SKU's that are only available through API and Azure PortalThis is a (please select all that apply):
Related Issue(s)
Fixes #26853
Note
If this PR changes meaningfully during the course of review please update the title and description as required.