Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_service_plan - Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3 #28316

Merged
merged 16 commits into from
Feb 26, 2025

Conversation

adrianfuro
Copy link
Contributor

@adrianfuro adrianfuro commented Dec 17, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR will add "I1mv2", "I2mv2", "I3mv2", "I4mv2", "I5mv2" SKU's as available options for azurerm_service_plan resource. These SKUs are available in Portal and API but not on Terraform since they were added in 2024 as supported SKUs officially.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
➜  terraform-provider-azurerm git:(main) ✗ TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccServicePlanIsolated_appServiceEnvironmentV3memoryIntensive -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccServicePlanIsolated_appServiceEnvironmentV3memoryIntensive
=== PAUSE TestAccServicePlanIsolated_appServiceEnvironmentV3memoryIntensive
=== CONT  TestAccServicePlanIsolated_appServiceEnvironmentV3memoryIntensive
--- PASS: TestAccServicePlanIsolated_appServiceEnvironmentV3memoryIntensive (3517.66s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    3519.318s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_service_plan - adding memory intensive SKU's that are only available through API and Azure Portal

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #26853

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@adrianfuro adrianfuro requested a review from a team as a code owner December 17, 2024 17:21
@adrianfuro adrianfuro changed the title ENHANCEMENT: Adding memory intensive SKUs for azurerm_service_plan resource [enhancement]: azurerm_service_plan - Adding memory intensive SKUs that are available on Portal Dec 17, 2024
@adrianfuro adrianfuro changed the title [enhancement]: azurerm_service_plan - Adding memory intensive SKUs that are available on Portal [enhancement]: azurerm_service_plan - Adding memory intensive SKUs for azurerm_app_service_environment_v3 Dec 17, 2024
@adrianfuro adrianfuro changed the title [enhancement]: azurerm_service_plan - Adding memory intensive SKUs for azurerm_app_service_environment_v3 [enhancement]: azurerm_service_plan - Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3 Dec 17, 2024
@github-actions github-actions bot added size/M and removed size/XS labels Dec 18, 2024
@adrianfuro adrianfuro changed the title [enhancement]: azurerm_service_plan - Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3 azurerm_service_plan - Adding isolated memory intensive SKUs for azurerm_app_service_environment_v3 Dec 24, 2024
@adrianfuro
Copy link
Contributor Author

I've added necessary tests for the enhancement

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adrianfuro - This looks mostly good to me, just a docs comment that needs a little attention if can take a look? In the meantime I'll get the testing run on this change.

@adrianfuro
Copy link
Contributor Author

Hey @jackofallops, any updates on the test?

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, thanks @adrianfuro LGTM 👍
image

@stephybun stephybun merged commit 9322ad9 into hashicorp:main Feb 26, 2025
33 checks passed
@github-actions github-actions bot added this to the v4.21.0 milestone Feb 26, 2025
stephybun added a commit that referenced this pull request Feb 26, 2025
jackofallops added a commit that referenced this pull request Feb 27, 2025
* Update CHANGELOG.md for #28840

* Update CHANGELOG.md #28808

* Update CHANGELOG.md #27962

* Update CHANGELOG.md for #28859

* Update for #28825

* Update CHANGELOG.md for #28864

* Update CHANGELOG.md #28539

* Update CHANGELOG.md #28685

* Update CHANGELOG.md for #28818

* Update for #28857 #28799 #28856

* Update for #28122

* Update for #28248 #27805

* Update for #28853

* Update for #28316 #28494 #28696

* Update for #28754

* Update CHANGELOG.md #28771

* Update CHANGELOG.md #28842

* Update for #28879

* Update for #28199

* Update CHANGELOG.md #28862

* prep for release v4.21.0

---------

Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Wodans Son <[email protected]>
Co-authored-by: stephybun <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_service_plan not supporting skus that are available in the portal
3 participants