Updating my fork #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make the contract size limit configurable in the genesis config, making it possible to override milestone based configurations in a private network.
…SysEng#1224) * [PIE-1224] Different request limits for different request types - create `EthLimits` with max size of response according to geth (https://github.com/ethereum/go-ethereum/blob/master/eth/downloader/downloader.go) - update `EthServer` to use those constants limits instead of the default one - remove requestLimit from EthServer and EthProtocolManager constructor fix PIE-1224 * eth wire protocol request limits - add fields in `SynchronizerConfiguration` to configure per type request limit - update `EthServer` constructor to add new fields - update `EthProtocolManager` and subclasses to support new fields - update unit tests accordingly * Update SynchronizerConfiguration.java * Update EthProtocolManagerTestUtil.java * Update EthServerTest.java * Update EthProtocolManagerTest.java * Update EthServerTest.java * fix after review discussion - remove per type request limit configuration from `SynchronizerConfiguration`. - add `EthServer` constructor without new fields that use default values. - update unit tests accordingly - update instanciation of different `PantheonController` accordingly * Update EthServerTest.java * fix review - spotless - fix clean up review comment * spotlessApply
- change option name - update warning condition on dependency check
…egaSysEng#1226) * [PRIV-41] Use metrics system for private state db - Use PrivacyParametersBuilder to build PrivacyParameters - refactor PrivacyParameters to expose default options - refactor test builders to use PrivacyParameters.DEFAULT - Use URI in Enclave * Fix: enclave tests from bad merge * Fix privacy acceptance tests after db configuration changes * Switch to use nested class for PrivacyParametersBuilder
There is no need to keep entire blocks during import after they have been imported. Keep just the hashes instead.
* EWP options management - create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502 * Update EthereumWireProtocolConfiguration.java * Update PantheonCommandTest.java * fix tests * spotlessApply * fix tests and javadoc * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * fix * fix PR discussion * Update EthereumWireProtocolConfiguration.java
* EWP options management - create `EthereumWireProtocolConfiguration` object to hold per request limits - add `EthereumWireProtocolConfiguration` in `SynchronizerConfiguration` - create `PositiveNumber` class to handle command line options representing a positive number (a request limit for example) - add unit tests to cover the new options fixes PIE-1502 * Update EthereumWireProtocolConfiguration.java * Update PantheonCommandTest.java * fix tests * spotlessApply * fix tests and javadoc * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java Co-Authored-By: abdelhamidbakhta <[email protected]> * fix * fix PR discussion * Update EthereumWireProtocolConfiguration.java * fix PR 1246 discussion PegaSysEng#1246 (comment)
* Use single Db for private states * Update Rocksdb options to use a common cache
* move subclass * Update Transaction.java * fix 500 error on tx not found Returns a JSON RPC error instead of failing due to NPE. * Handle reason on revert operation Implement reason string on revert operation as in the following EIP : https://github.com/ethereum/EIPs/blob/master/EIPS/eip-140.md * Update MessageFrame.java * Update RevertOperationTest.java * fix PR discussion * fix PR * Update DebugTraceTransaction.java
Because of deep issues sometimes we get duplicate Peers that differ in small ways. Tweak the test to verify we get all of the peers we are expecting and to be tolerant of quasi-duplicate peers.
There is one check that has issues in Java 12 and has yet to be fixed. Disable it when we detect we are being built on Java 12.
…gaSysEng#1311) Implements a GraphQL interface to expose data that conforms to EIP-1767. As the EIP specifies, the implementation should allow “a complete replacement to the read-only information exposed via the present JSON-RPC interface”. Supported CLI options: * `--graphql-http-enabled` to enable GraphQL * `--graphql-http-host` and `--graphql-http-port` to configure the host and port. * `--graphql-http-cors-origins` to set the CORS-origin policies * The `--host-whitelist` option is respected. This option also applies to JSON-RPC and WS-RPC endpoints. Default port is 8547. The endpoint is `/graphrpc`, so the default URL is typically `http://127.0.0.1:8547/graphql`
…X() (PegaSysEng#1368) * Change all Stream<?> getX() and Stream<?> x() methods to Stream<?> streanX methods, such as `Stream<Peer> streamIdlePeers()` * Update coding conventions to reflect this.
…valid EnodeId (PegaSysEng#1417) * [PAN-2590] Improved error response for invalid EnodeID in Add/Remove JSON-RPC calls. * [PAN-2590] Tests.
* simple account permissioning
…ract permissioning (PegaSysEng#1430) * [PAN-2601] Renamed SmartContractPermissioningController -> NodeSmartContractPermissioningController incl. relevant fields etc. * [PAN-2601] Added account smart contract fields to SmartContractPermissioningConfiguration. * [PAN-2601] Added AccountPermissioningProvider. * [PAN-2601] Removed superfluous 'node' from some class and field names. * [PAN-2601] Spotless.
…ningProvider to better reflect the interface. (PegaSysEng#1432)
* Add slf4j to log4j bindings as a runtime dependency so any libraries that log to slf4j have their logs output to Pantheon's logs properly. * Set a default exception handler to ensure uncaught exceptions wind up in the Pantheon logs.
* Don't copy collections if we don't need to. Change types higher up if needed. * Don't use Guava's Object.equal, use Java's Objects.equals. ** add errorprone test to enforce the banning of Guava's Objects class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.