-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Donations block: Update donations block to use inner blocks #22470
Conversation
…xed components. We can now edit the presentation of the individual components of the donations block. Save is not working, some styles are missing, and other basic behaviours and checks are also missing.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
The coverage report started taking an extra 10 minutes after packages/my-jetpack added JS tests because it was reporting coverage for all of WordPress that was brought in via WorDBless. Exclude that by default. Also exclude the `jetpack_vendor/` directory from packages/composer-plugin for good measure.
Co-authored-by: Brandon Kraft <[email protected]>
This is super interesting already @rcrdortiz! Please keep in mind that we don't need all the requested features at once. At a glance, I've got a few general comments about the tabs! Is there a reason why they are three different child blocks rather than one generic tab block with different attributes and inner blocks? They seem to be practically identical, aside from the initial heading label and the payment cadence; we should be able to address them both through attributes and inner blocks. Something like this:
The structure of the block becomes like this (which is reasonable): Please make sure also to add appropriate icons to the tabs. And speaking of Premium Content, with this new format, the Donations block would have the same issue outlined here: #22426. We can address it in a follow-up, though, so there's no need to sweat over it right now. 👍 Note that the original Donations block has this in its sidebar settings: When working on inner blocks templates, keep in mind that:
Also, a bonus comment about folder structure nitpicking! 😄 Blocks typically have a flatter structure, so feel free to:
|
Co-authored-by: Jeremy Herve <[email protected]>
When creating a JS package, the CLI is pre-filling the test-coverage script with a call to `nyc`. But it wasn't also pre-adding a dependency on nyc, resulting in coverage not working for several packages. Also, add the missing dep to those packages.
* fix issue with output folder creation * [not verified] Add API and scripts * add changelog * [not verified] Add presisting Model class and use it all over the API * Exclude from PHPCS for now * Remove package from exclude list * Require PHP 8.0 * minor additions * Use the correct composer.json rules for requiring php 8 * Update projects/packages/analyzer/scripts/jp-analyze-parallel.php Co-authored-by: Brad Jorsch <[email protected]> * address feedback * some more feedback * update result generation logic * Add generic query params parser class * Add plugin downloader class * use query params in analyze controller * download requested versions of a plugins for scan * Update projects/packages/analyzer/scripts/jp-analyze-parallel.php Co-authored-by: Brad Jorsch <[email protected]> * Update projects/packages/analyzer/src/api/class-plugin-downloader.php Co-authored-by: Brad Jorsch <[email protected]> * update error message * Some changes to address issues on linux * improve not implemented output * fix an issue with empty $folder_name * Address racing issue * implement missing deserialization routines * Update projects/packages/analyzer/scripts/jp-analyze-parallel.php Co-authored-by: Brad Jorsch <[email protected]> * move phpcs rule definitions around * Use a PHP way to remove folders * replace only first occurance of the folder in zip * Fix PHPCS configuration 🤦 * Introduce load_differences() API Co-authored-by: Brandon Kraft <[email protected]> Co-authored-by: Brad Jorsch <[email protected]>
* my-jetpack: check user connectivity before to hit wpcom * changelog
…t from connection js-package (#22480)
…ntime (#22265) Co-authored-by: Jeremy Herve <[email protected]>
…nspector. Refactored directory structure. Added controls for the donations block. Merged all the views into a single view.
@Copons Implemented all your suggestions. Thanks! |
… on the front end of the site.
#22659) * [not verified] my-jetpack: extract go-back-link from connection * [not verified] my-jetpack: introduce Layout component * [not verified] my-jetpack: remove duplicated go back link from connection * [not verified] my-jetpack: tweak product interstitial layout * [not verified] my-jetpack: tweak connection-screen top margin * [not verified] changelog
… not allowed to be saved now on the custom amount field. Custom Amount block controls are now working and style the custom amount block accordingly.
Until now, the endpoint was available to anyone, and one could pass any Twitter Thread to that endpoint to make a blog-authenticated request to WordPress.com, and then, in turn, an authenticated request to the Twitter API using our app credentials. Here is an example: https://jeremy.hu/wp-json/wpcom/v2/tweetstorm/gather?url=https://twitter.com/KieranBinchy/status/1488812175372267526 That endpoint is currently used in the block editor (so only by folks with contributing capabilities on a given site) to "unroll" a Twitter Thread, i.e. pull all tweets from a thread based off a single tweet. I think it would be fine to limit that endpoint to contributors. - Related post: p3btAN-1Fc-p2 - This merges r239582-wpcom from WordPress.com (D74346-code).
* [not verified] my-jetpack: add data for search product * changelog
* Remove previous rule and exclude by file.
…em CTA when a partner coupon is detected (#22602) Co-authored-by: Jeremy Herve <[email protected]>
* [not verified] my-jetpack: mock Boost princing data * [not verified] my-jetpack: camelcasly pricingForUi * [not verified] my-jetpack: implement Free for product detail * [not verified] my-jetpack: tweak Icon in product detail * [not verified] changelog * my-jetpack: add pricing mock data for backup
* [not verified] my-jetpack: add data for search product * changelog * my-jetpack: add SearchInterstitial component * my-jetpack: change status logic, checking plan at top * mu-jetpack: register NEEDS_PURCHASE status * my-jetpack: register /add-search route connected to SearchInterstitial component * my-jetpack: lead to /add-search on search card Add * changelog
…True (#22608) * add deprecation for `useAverageColor` default change * added changelog entry * Update deprecated v4 to match blocks without useAverageColor property Co-authored-by: thedebian <[email protected]> Co-authored-by: Jeremy Herve <[email protected]>
Co-authored-by: Siobhan <[email protected]> Co-authored-by: Jeremy Herve <[email protected]>
…s instead of fixed components. We can now edit the presentation of the individual components of the donations block. Save is not working, some styles are missing, and other basic behaviours and checks are also missing.
… in the block inspector. Refactored directory structure. Added controls for the donations block. Merged all the views into a single view.
…tially rendered on the front end of the site.
…he actual donations block. The block is working asexxpected. The deprecation strategy is partially implemented, the previous version block will not break the editor but the data is not migrated yet.
… block. Text is not allowed to be saved now on the custom amount field. Custom Amount block controls are now working and style the custom amount block accordingly.
…isplayed properly and works as expected on the FE when it has not been updated to the new version. Fixed an issue that caused the Amount block to not show the decimal places correctly
…utomattic/jetpack into update/donations-block-to-inner-blocks
Fixes #17232, it also fixes other issues. I'll update this message when the PR is ready for review.
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: