Merge master into feature branch #50112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#49451) ## Summary * Removes the older beginner KQL type of signal creation in favor of newer version with filtering * Adds ability to create KQL or lucene queries that will work with the UI filters * UI state with the filters are now savable to re-hydrate UI's on the front end * Adds `saved_id` ability so the UI can tether dynamic saved queries with signals * Changed `it` to `test` as `it` is not the alias we use for tests * Updated script which converts older saved searches to work with newer mechanism * Fixed script to accept proper ndjson lines * Adds validation unit tests for the endpoint * Increases validation strictness of the endpoints * Adds more data scripts for testing scenarios * #47013 ## Testing * Run `./hard_reset.sh` script * Test with both algorithms through this toggle before starting kibana: `export USE_REINDEX_API=true` * Convert older saved searches to compatible new query filters by running: `./convert_saved_search_to_signals.sh ~/projects/saved_searches /tmp/signals` * Post them`./post_signal.sh /tmp/signals/*.json` * Hard reset again * Test smaller set of signals and REST endpoints using the typical scripts of: ```sh ./post_signal.sh ./read_signal.sh ./find_signals.sh ./update_signal.sh ./delete_signal.sh ``` or test using POSTMAN, etc... If you want to test validation. If you see any validation issues let me know as I have validation testing files and can easily fix them add another unit test to the growing large collection we have now. Change in your advanced settings of SIEM to use your signals index you configured for verification that the signals show up. ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. ~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~ ~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~ ~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~ ### For maintainers ~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~ ~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
…49103) * [Maps] hide map visualization types with default kibana.yml settings * add docs explaining xpack.maps.showMapVisualizationTypes * clean up docs * fix docs build * fix typescript failures * move docs to troubleshooting section * add message about xpack.maps.showMapVisualizationTypes in coordinate map and region map docs * doc updates based on gchaps feedback * Update docs/visualize/regionmap.asciidoc Co-Authored-By: gchaps <[email protected]> * Update docs/visualize/tilemap.asciidoc Co-Authored-By: gchaps <[email protected]>
* Add UI Indices runtime configuration - index configuration in settings page - defaults to kibana.yml configuration values * fix tests * Code review feedback and cleanup * fix i18n * Code review feedback * Address code review feedback. * Fixes bug where legacy data filter was including the .apm-agent-configuration index which caused failures in those APIs
* Moved filterManager to NP plugin * Fixed applying filters to dashbaord. * Minor fixes * fixed types * fix jest tests mock of filter * Updated karma mccks * Fixed lens test * fixed import * Removed comment
This changes the result loading indicators of the log rate analysis page such that they are rendered as an overlay to the existing panels. This has the advantage that the page layout doesn't jump during the loading process and the charts and table maintain their filter and expansion states.
* Renaming Infrastructure to Metrics whenever the context is the metrics app. * More renames, and picking up a few stray references to Infrastructure/Metrics/Logs UI too. * Fixing typo
* Move storage to kibana_utils * Updated all references to Storage and replace places where it was referenced to as "store" to avoid confusion. * fixed tests * Delete data legacy dependencies plugin * Imports fix * update snapshots
This PR adds tests for the ML advanced wizard.
* move react/jsx-a11y rules into shared react preset * autofix react/jsx-closing-tag-location * autofix react/no-unknown-property * manually fix react/no-unescaped-entities * maually fix react/jsx-pascal-case * manually fix react/prefer-stateless-function * disable known violations in specific plugins/areas * remove code override
* Removed Flexbox around header and link elements. * Removed unused EUI component * Added class to include the ellipses when name is truncated. * Fixed title in policy_details.tsx * Fixed buttons and title on policy and repository table. * Linting fixes. * Removed unused references. * Added keys to arrays of elements to resolve React errors.
* fix react hook deps * removing lint override for spaces
* Upgrade EUI to v14.8.0 * update snapshot for determinism
This slightly increases the datepicker popover `z-index` to avoid the checkbox labels (which for some reason have an increased `z-index`) from underneath showing through. fixes #49245
* [Logs UI] Fix endless scrolling to load more entries * Make scrollable list state update more robust
* [Lens] Remove default title, tweak text for consistency * Remove unused * Text update
## Summary Updates the placeholder text within the ML Anomaly Detection UI for when certain jobs are incompatible. To test, remove all `siem:defaultIndex` patterns -- this will not send any indices to the recognize API, and all jobs will be _incompatible_. Resolves #49200  ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~ - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~ - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
* Flatten metadata section objects and adding filter input text * Adding logic to filter keys and values * Extrating Section component, adding not found message and creating HeightRetainer component to fix height and avoid the page to jump when filtering * Adding filtered value to the url * Refactoring dotted component extrating pathify to an external file * Removing statefull filtered items * Refactoring names * Refactoring variable names * fixing ui * Removing space on transaction flyout and changint it to m on span flyout
… Page (#49500) * Removing points from Metrics Explorer and Metric Detail Page; Fixing bug with metric detail page labels; * Remove points configuration
* Add loading indicator to Lens workspace panel * [Expressions] [Lens] Handle loading and errors in ExpressionRenderer * Using loading$ observable and improve tests * [Lens] Fix layer crash and improve layer suggestions * Using CSS and to handle layout of expression renderer Added TODO for using chart loader when area is completely empty * Improve error handling and simplify code * Fix cleanup behavior * Fix double render and prevent error cases in xy chart * Fix context for use in dashboards * Remove className from expression rendere component * Improve handling of additional interpreter args * More layout fixes - Hide chart if Empty not Loading - Fix relative positioning for progress bar since className is no longer passed (super hacky) * Build suggestions that remove layers * Update tests and add keptLayerIds everywhere * Fix bug where datatable would accept multi-layer suggestions * Build more suggestions that work with metric/datatable * Fix issue with chart switching from empty * Fix datatable multiple layer issue
…gated filters (#49939) * Better key out negative filters * fragments not spans * Alter filter bar colors - Red border for excluded - Match pinned color to border color * Fix title by using `useInnerText` * Fix alignment of add filter button * Moving SASS variables to its own file
* Ensure cloud cannot see setup mode * Remove cloud check from collection status, as it's an injected var now * Man these tests suck
resolves #49519 If a user has previously opted out of telemetry, this PR will cause them to be prompted again, when the major or minor version of Kibana changes. Previously, once opted out, they would never get prompted again.
* Add error when there is no histogram agg when using parent pipeline * Update error message * Update message * Get rid of let
This PR include three key changes: 1. Run tasks as soon as they have been marked as running, rather than wait for the whole batch to me marked 2. Use a custom refresh setting of refresh: false where possible, in place of wait_for, in order to speed up Task Manager's internal workflow 3. Instrumentation of Task Manager exposing Activity / Inactivity metrics in Performance test runs
Dismissed @elastic/kibana-app review of import changes. ts-ignored @ts-ignore * Moved files to plugins/data/server. * Renamed IndexPatternsService to IndexPatternsFetcher and created new IndexPatternsService * Set routerPath. * Fixed type error. * Changed beats_management _fields_for_wildcard request with data/public/legacy api. * Fixed changed paths. * Fixes crashes after merge. * Updated path for clarity. * Applied Plugin interface to service. * Fixed test failure caused by non camel case local variable name. * Fixed import to IndexPatternsService to IndexPatternsFetcher.
* [a11y] add initial accessibility functional tests * add accessibility jobs * fix config path * remove percy setup from scripts * disable color-contrast rule * apply changes from @myasonik * define aria-controls/owns props even when suggestions aren't visible * [ftr/a11y] only throw error when there are errors * adding tests for management page * add a11y test for management page * adding ignore rules' to a11y * accessibility test for kibana home * 7 passing tests, 0 failures * jest snapshot update * support a11y test in pipeline job * update a11y test script for pipelines * use oss compatible ci setup * fix exclude syntax * add default exclusion syntax
Use EuiSelect instead of ComboBox for ping history Resolves elastic/uptime#98
Dismissing reviews from ml and canvas as this is only an import change. * Move @kbn/es-query into data plugin - filters folder * fix PR comments
💔 Build Failed |
/Users/jfsiii/work/kibana/x-pack/legacy/plugins/integrations_manager/public/hooks/use_links.tsx 26:20 error React Hook "useCore" is called in function "addBasePath" which is neither a React function component or a custom React Hook function react-hooks/rules-of-hooks /Users/jfsiii/work/kibana/x-pack/legacy/plugins/integrations_manager/public/screens/detail/readme.tsx 26:35 error React Hook "useLinks" cannot be called inside a callback. React Hooks must be called in a React function component or a custom React Hook function react-hooks/rules-of-hooks 39:6 error React Hook useEffect has a missing dependency: 'readmePath'. Either include it or remove the dependency array react-hooks/exhaustive-deps /Users/jfsiii/work/kibana/x-pack/legacy/plugins/integrations_manager/public/screens/home/search_results.tsx 27:42 error `"` can be escaped with `"`, `“`, `"`, `”` react/no-unescaped-entities 27:49 error `"` can be escaped with `"`, `“`, `"`, `”` react/no-unescaped-entities ✖ 5 problems (5 errors, 0 warnings) 1 error and 0 warnings potentially fixable with the `--fix` option.
💚 Build Succeeded |
jen-huang
added
the
Team:Fleet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
94b313f