Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHBC-2140: Release to Prod #941

Merged
merged 273 commits into from
Feb 10, 2023
Merged

BHBC-2140: Release to Prod #941

merged 273 commits into from
Feb 10, 2023

Conversation

NickPhura
Copy link
Collaborator

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2140

Description of relevant changes

Release Test to Prod.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

  • New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
  • I have avoided duplicating code when possible, moving re-usable pieces into functions
  • I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
  • My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
  • My code changes account for null/undefined values and handle errors appropriately
  • My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

  • My code follows the established style conventions
  • My code uses native material-ui components/icons/conventions when possible

Documentation

  • I have commented my code sufficiently, such that an unfamiliar developer could understand my code
  • I have added/updated README's and related documentation, as needed

Tests

  • I have added/updated unit tests for any code I've added/updated
  • I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

  • I have run the linter and fixed any issues, as needed
    See the lint commands in package.json
  • I have run the formatter and fixed any issues, as needed
    See the format commands in package.json

SonarCloud

  • I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

rstens and others added 30 commits November 9, 2021 15:21
* Small test script and seeding changes

* Remove Shreyas from the seed

* Details for ZAP

* Subtitute hardcoded PW with GHA- Secret
* Test Script update, login and some other details

* Add delay to login

* Remove file

* Pointing to the right authurl

* Path confusion

* And again

* It is all in the timing

* Update readme as per Nick's comment
- System admin users can delete other system users.
Update snackbar to accept ReactNode as message
* [BHBC-950] UI Cleanup

* [BHBC-950] Updating UI

* Trigger Build

* Update to test script to deal with changed id for report upload

* [BHBC-950] Fixing Request Access Table

Co-authored-by: Roland Stens <[email protected]>
Co-authored-by: Anissa Agahchen <[email protected]>
- Add project users page
- Add project users "add project participant" form
- Add delete project user functionality
- Update some api project role authorization checks
- Update some frontend role check functionality
- misc fixes/updates
* First test

* Update path

* - update older node versions to 14
- Increase tsconfig versions
- Increase a few package.json versions
- Update a few git actions to latest versions

* Revert accidental backup file change

* Set back to es2015 otherwise the test framework will fail

Co-authored-by: Nick Phura <[email protected]>
* BHBC-948: Allow users to change existing system user roles.
* BHBC-1491: Allow users to change existing project participant's roles.
anissa-agahchen and others added 20 commits January 27, 2023 11:58
* Wrap `true` value in annotation in quotes
* Fix sims svc client number
* Update entitlement names
* Update postgres dockerfile
* Clamav Updates/Fixes
* Update readme
BHBC-2162: Release Dev To Test
… implementation (#926)

* Fixed a bug with adding participants to a project;
* Removed the User GUID text field from the Add System User form;
* Made the user_guid property in the system_users table nullable;
* Added a service method for finding users by user identifier + identity source;
* Added a function which patches the user's GUID entry whenever their user context is set during a database connection.
* BHBC-2145: Fix bug re: validation completion flag
BHBC-2162-2: Release Dev To Test
* Minor UI Updates/Fixes for Production Launch
BHBC-2162-3: Release Dev To Test
* BHBC-2183: Fix/enable required column validator
BHBC-2140: Release to Test
BHBC-2140: Release to Test
@NickPhura NickPhura marked this pull request as ready for review February 10, 2023 00:54
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (prod@e2d58e0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             prod     #941   +/-   ##
=======================================
  Coverage        ?   65.78%           
=======================================
  Files           ?      350           
  Lines           ?    11308           
  Branches        ?     1959           
=======================================
  Hits            ?     7439           
  Misses          ?     3471           
  Partials        ?      398           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍨

@NickPhura NickPhura merged commit f1e28b7 into prod Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants