BHBC-2254: Promote Dev to Test

[NickPhura]

Overview

Links to Jira tickets

https://quartech.atlassian.net/browse/BHBC-2254

Description of relevant changes

Release latest Dev to Test

Added everyone as a reviewer, mainly for visibility. We will of course have the usual formal round of testing in the Test environment after we merge this PR.

PR Checklist

A list of items that are good to consider when making any changes.

Note: this list is not exhaustive, and not all items are always applicable.

Code

• New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
• I have avoided duplicating code when possible, moving re-usable pieces into functions
• I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
• My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
• My code changes account for null/undefined values and handle errors appropriately
• My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

• My code follows the established style conventions
• My code uses native material-ui components/icons/conventions when possible

Documentation

• I have commented my code sufficiently, such that an unfamiliar developer could understand my code
• I have added/updated README's and related documentation, as needed

Tests

• I have added/updated unit tests for any code I've added/updated
• I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

• I have run the linter and fixed any issues, as needed
  See the lint commands in package.json
• I have run the formatter and fixed any issues, as needed
  See the format commands in package.json

SonarCloud

• I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1010-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1010-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1010

[codecov]

Codecov Report

Merging #1010 (21374b7) into test (1f15975) will increase coverage by 2.34%.
The diff coverage is 89.89%.

@@            Coverage Diff             @@
##             test    #1010      +/-   ##
==========================================
+ Coverage   65.77%   68.11%   +2.34%     
==========================================
  Files         350      384      +34     
  Lines       11305    11900     +595     
  Branches     1960     2030      +70     
==========================================
+ Hits         7436     8106     +670     
+ Misses       3471     3333     -138     
- Partials      398      461      +63     

Impacted Files	Coverage Δ
api/src/paths/administrative-activities.ts	84.84% <ø> (ø)
...ystem-access/{administrativeActivityId}/approve.ts	87.50% <ø> (ø)
...system-access/{administrativeActivityId}/reject.ts	95.45% <ø> (ø)
api/src/paths/gcnotify/send.ts	78.26% <ø> (ø)
api/src/paths/logger.ts	84.61% <ø> (ø)
api/src/paths/publish/project.ts	0.00% <0.00%> (ø)
api/src/paths/user/add.ts	86.11% <ø> (ø)
api/src/paths/user/list.ts	85.71% <ø> (ø)
api/src/paths/user/{userId}/get.ts	96.42% <ø> (ø)
api/src/paths/user/{userId}/system-roles/update.ts	97.14% <ø> (ø)
... and 144 more

... and 49 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
5.1% Duplication